9c06209306
Code relocation info is now always allocated in old-space. Before relocation
info allocated for placeholders and builtins (which get replaced with
trampolines in nosnap builds) would become unreachable. Since read-only space
is not GCed and ReadOnlyHeapIterator doesn't check for reachability,
ValidateSnapshot would fail finding unreachable objects returned by
ReadOnlyHeapIterator.
Because trampoline relocation info gets replaced with canonical one, this only
affects no-embdded-builtins nosnap builds, which don't get much benefit from
read-only relocation info anyway.
A new check has been added to the read-only deserializer to verify that every
read-only object is reachable at mksnapshot-time.
The CombinedHeapIterator iteration order was changed to iterate over
read-only space first, because that's how HeapIterator worked.
This is a reland of 3d1d8eae77
Original change's description:
> [heap] Skip ro-space from heap iterators, add CombinedHeapIterator.
>
> Read-only space sharing requires an iterator independent of heap. This
> also enables future removal of read-only space from heap.
>
> Bug: v8:7464
> Change-Id: Ia07a9369494ea2c547d12c01ffa1d7b8b6bbeabc
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1552795
> Commit-Queue: Maciej Goszczycki <goszczycki@google.com>
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Reviewed-by: Dan Elphick <delphick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#60819}
Bug: v8:7464
Change-Id: I49ae070955b77956962334a84f762ab29052d5ff
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1566513
Reviewed-by: Dan Elphick <delphick@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Maciej Goszczycki <goszczycki@google.com>
Cr-Commit-Position: refs/heads/master@{#61185}
101 lines
2.7 KiB
C++
101 lines
2.7 KiB
C++
// Copyright 2019 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "include/v8.h"
|
|
#include "src/api-inl.h"
|
|
#include "src/heap/combined-heap.h"
|
|
#include "src/heap/heap.h"
|
|
#include "src/heap/read-only-heap.h"
|
|
#include "src/isolate.h"
|
|
#include "src/objects.h"
|
|
#include "src/objects/heap-object.h"
|
|
#include "src/roots-inl.h"
|
|
#include "test/cctest/cctest.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace heap {
|
|
|
|
TEST(HeapIteratorNullPastEnd) {
|
|
HeapIterator iterator(CcTest::heap());
|
|
while (!iterator.next().is_null()) {
|
|
}
|
|
for (int i = 0; i < 20; i++) {
|
|
CHECK(iterator.next().is_null());
|
|
}
|
|
}
|
|
|
|
TEST(ReadOnlyHeapIteratorNullPastEnd) {
|
|
ReadOnlyHeapIterator iterator(CcTest::heap()->read_only_heap());
|
|
while (!iterator.next().is_null()) {
|
|
}
|
|
for (int i = 0; i < 20; i++) {
|
|
CHECK(iterator.next().is_null());
|
|
}
|
|
}
|
|
|
|
TEST(CombinedHeapIteratorNullPastEnd) {
|
|
CombinedHeapIterator iterator(CcTest::heap());
|
|
while (!iterator.next().is_null()) {
|
|
}
|
|
for (int i = 0; i < 20; i++) {
|
|
CHECK(iterator.next().is_null());
|
|
}
|
|
}
|
|
|
|
namespace {
|
|
// An arbitrary object guaranteed to live on the non-read-only heap.
|
|
Object CreateWritableObject() {
|
|
return *v8::Utils::OpenHandle(*v8::Object::New(CcTest::isolate()));
|
|
}
|
|
} // namespace
|
|
|
|
// TODO(v8:7464): Add more CHECKs once Contains doesn't include read-only space.
|
|
TEST(ReadOnlyHeapIterator) {
|
|
CcTest::InitializeVM();
|
|
HandleScope handle_scope(CcTest::i_isolate());
|
|
const Object sample_object = CreateWritableObject();
|
|
ReadOnlyHeapIterator iterator(CcTest::read_only_heap());
|
|
|
|
for (HeapObject obj = iterator.next(); !obj.is_null();
|
|
obj = iterator.next()) {
|
|
CHECK(ReadOnlyHeap::Contains(obj));
|
|
CHECK_NE(sample_object, obj);
|
|
}
|
|
}
|
|
|
|
TEST(HeapIterator) {
|
|
CcTest::InitializeVM();
|
|
HandleScope handle_scope(CcTest::i_isolate());
|
|
const Object sample_object = CreateWritableObject();
|
|
HeapIterator iterator(CcTest::heap());
|
|
bool seen_sample_object = false;
|
|
|
|
for (HeapObject obj = iterator.next(); !obj.is_null();
|
|
obj = iterator.next()) {
|
|
CHECK(!ReadOnlyHeap::Contains(obj));
|
|
if (sample_object == obj) seen_sample_object = true;
|
|
}
|
|
CHECK(seen_sample_object);
|
|
}
|
|
|
|
TEST(CombinedHeapIterator) {
|
|
CcTest::InitializeVM();
|
|
HandleScope handle_scope(CcTest::i_isolate());
|
|
const Object sample_object = CreateWritableObject();
|
|
CombinedHeapIterator iterator(CcTest::heap());
|
|
bool seen_sample_object = false;
|
|
|
|
for (HeapObject obj = iterator.next(); !obj.is_null();
|
|
obj = iterator.next()) {
|
|
CHECK(CcTest::heap()->Contains(obj));
|
|
if (sample_object == obj) seen_sample_object = true;
|
|
}
|
|
CHECK(seen_sample_object);
|
|
}
|
|
|
|
} // namespace heap
|
|
} // namespace internal
|
|
} // namespace v8
|