73f4ac62ed
Add a test that does the same thing the devtools-frontend does when evaluating console inputs. 1) Declare a const variable with throwOnSideEffect=true. This should throw. 2) Declare the same const variable with throwOnSideEffect=false. This should successfully declare the variable. Previously it could be the case that even though we threw in 1), the variable would fail to be initialized in 2) with a re-declaration error. Bug: chromium:1043151 Change-Id: I1a6126b518f7bb3788c39b9f8e3adb8850aa962a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2016587 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#65991}
97 lines
2.3 KiB
Plaintext
97 lines
2.3 KiB
Plaintext
Tests that Runtime.evaluate with REPL mode correctly detects side-effects.
|
|
Test "let" declaration is side-effecting
|
|
{
|
|
id : <messageId>
|
|
result : {
|
|
exceptionDetails : {
|
|
columnNumber : -1
|
|
exception : {
|
|
className : EvalError
|
|
description : EvalError: Possible side-effect in debug-evaluate
|
|
objectId : <objectId>
|
|
subtype : error
|
|
type : object
|
|
}
|
|
exceptionId : <exceptionId>
|
|
lineNumber : -1
|
|
scriptId : <scriptId>
|
|
text : Uncaught
|
|
}
|
|
result : {
|
|
className : EvalError
|
|
description : EvalError: Possible side-effect in debug-evaluate
|
|
objectId : <objectId>
|
|
subtype : error
|
|
type : object
|
|
}
|
|
}
|
|
}
|
|
Test "const" declaration is side-effecting
|
|
{
|
|
id : <messageId>
|
|
result : {
|
|
exceptionDetails : {
|
|
columnNumber : -1
|
|
exception : {
|
|
className : EvalError
|
|
description : EvalError: Possible side-effect in debug-evaluate
|
|
objectId : <objectId>
|
|
subtype : error
|
|
type : object
|
|
}
|
|
exceptionId : <exceptionId>
|
|
lineNumber : -1
|
|
scriptId : <scriptId>
|
|
text : Uncaught
|
|
}
|
|
result : {
|
|
className : EvalError
|
|
description : EvalError: Possible side-effect in debug-evaluate
|
|
objectId : <objectId>
|
|
subtype : error
|
|
type : object
|
|
}
|
|
}
|
|
}
|
|
Test "const" with side-effects works afterwards
|
|
{
|
|
id : <messageId>
|
|
result : {
|
|
result : {
|
|
type : undefined
|
|
}
|
|
}
|
|
}
|
|
Test side-effect free expressions can be eagerly evaluated
|
|
{
|
|
id : <messageId>
|
|
result : {
|
|
result : {
|
|
description : 3
|
|
type : number
|
|
value : 3
|
|
}
|
|
}
|
|
}
|
|
{
|
|
id : <messageId>
|
|
result : {
|
|
result : {
|
|
type : string
|
|
value : hello REPL
|
|
}
|
|
}
|
|
}
|
|
{
|
|
id : <messageId>
|
|
result : {
|
|
result : {
|
|
className : Promise
|
|
description : Promise
|
|
objectId : <objectId>
|
|
subtype : promise
|
|
type : object
|
|
}
|
|
}
|
|
}
|