73f4ac62ed
Add a test that does the same thing the devtools-frontend does when evaluating console inputs. 1) Declare a const variable with throwOnSideEffect=true. This should throw. 2) Declare the same const variable with throwOnSideEffect=false. This should successfully declare the variable. Previously it could be the case that even though we threw in 1), the variable would fail to be initialized in 2) with a re-declaration error. Bug: chromium:1043151 Change-Id: I1a6126b518f7bb3788c39b9f8e3adb8850aa962a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2016587 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#65991}
43 lines
1.3 KiB
JavaScript
43 lines
1.3 KiB
JavaScript
// Copyright 2019 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
let {Protocol} = InspectorTest.start(
|
|
'Tests that Runtime.evaluate with REPL mode correctly detects side-effects.');
|
|
|
|
Protocol.Runtime.enable();
|
|
(async function() {
|
|
InspectorTest.log('Test "let" declaration is side-effecting');
|
|
await evaluateRepl('let x = 21;');
|
|
|
|
InspectorTest.log('Test "const" declaration is side-effecting');
|
|
await evaluateRepl('const y = 42;');
|
|
|
|
InspectorTest.log('Test "const" with side-effects works afterwards');
|
|
await evaluateReplWithSideEffects('const y = 42;');
|
|
|
|
InspectorTest.log('Test side-effect free expressions can be eagerly evaluated');
|
|
await evaluateRepl('1 + 2');
|
|
await evaluateRepl('"hello " + "REPL"');
|
|
|
|
await evaluateRepl('(async function foo() { return 42; })();');
|
|
|
|
InspectorTest.completeTest();
|
|
})();
|
|
|
|
async function evaluateRepl(expression) {
|
|
InspectorTest.logMessage(await Protocol.Runtime.evaluate({
|
|
expression: expression,
|
|
replMode: true,
|
|
throwOnSideEffect: true
|
|
}));
|
|
}
|
|
|
|
async function evaluateReplWithSideEffects(expression) {
|
|
InspectorTest.logMessage(await Protocol.Runtime.evaluate({
|
|
expression: expression,
|
|
replMode: true,
|
|
throwOnSideEffect: false
|
|
}));
|
|
}
|