37a4937baf
Since this produces a few false positives, also implemented a whitelist mechanism to not report them. Also, add a couple of tests and implemented automated testing against test-expectations file. Bug: v8:9321 Change-Id: I2915a29fe1891e8bbc51118bbd95ae072c8de023 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1773243 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#63456}
135 lines
3.7 KiB
C++
135 lines
3.7 KiB
C++
// Copyright 2019 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/execution/isolate.h"
|
|
#include "src/handles/handles-inl.h"
|
|
#include "src/handles/handles.h"
|
|
#include "src/objects/foreign-inl.h"
|
|
#include "src/objects/managed.h"
|
|
#include "src/objects/maybe-object.h"
|
|
#include "src/objects/object-macros.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
// ------- Test simple argument evaluation order problems ---------
|
|
|
|
Handle<Object> CauseGC(Handle<Object> obj, Isolate* isolate) {
|
|
isolate->heap()->CollectGarbage(OLD_SPACE, GarbageCollectionReason::kTesting);
|
|
|
|
return obj;
|
|
}
|
|
|
|
Object CauseGCRaw(Object obj, Isolate* isolate) {
|
|
isolate->heap()->CollectGarbage(OLD_SPACE, GarbageCollectionReason::kTesting);
|
|
|
|
return obj;
|
|
}
|
|
|
|
Managed<Smi> CauseGCManaged(int i, Isolate* isolate) {
|
|
isolate->heap()->CollectGarbage(OLD_SPACE, GarbageCollectionReason::kTesting);
|
|
|
|
return Managed<Smi>::cast(Smi::FromInt(i));
|
|
}
|
|
|
|
void TwoArgumentsFunction(Object a, Object b) {
|
|
a.Print();
|
|
b.Print();
|
|
}
|
|
|
|
void TestTwoArguments(Isolate* isolate) {
|
|
Handle<JSObject> obj1 = isolate->factory()->NewJSObjectWithNullProto();
|
|
Handle<JSObject> obj2 = isolate->factory()->NewJSObjectWithNullProto();
|
|
// Should cause warning.
|
|
TwoArgumentsFunction(*CauseGC(obj1, isolate), *CauseGC(obj2, isolate));
|
|
}
|
|
|
|
void TwoSizeTArgumentsFunction(size_t a, size_t b) {
|
|
USE(a);
|
|
USE(b);
|
|
}
|
|
|
|
void TestTwoSizeTArguments(Isolate* isolate) {
|
|
Handle<JSObject> obj1 = isolate->factory()->NewJSObjectWithNullProto();
|
|
Handle<JSObject> obj2 = isolate->factory()->NewJSObjectWithNullProto();
|
|
// Should cause warning.
|
|
TwoSizeTArgumentsFunction(sizeof(*CauseGC(obj1, isolate)),
|
|
sizeof(*CauseGC(obj2, isolate)));
|
|
}
|
|
|
|
// --------- Test problems with method arguments ----------
|
|
|
|
class SomeObject : public Object {
|
|
public:
|
|
void Method(Object a) { a.Print(); }
|
|
|
|
SomeObject& operator=(const Object& b) {
|
|
this->Print();
|
|
return *this;
|
|
}
|
|
|
|
DECL_CAST(SomeObject)
|
|
|
|
OBJECT_CONSTRUCTORS(SomeObject, Object);
|
|
};
|
|
|
|
void TestMethodCall(Isolate* isolate) {
|
|
SomeObject obj;
|
|
Handle<SomeObject> so = handle(obj, isolate);
|
|
Handle<JSObject> obj1 = isolate->factory()->NewJSObjectWithNullProto();
|
|
// Should cause warning.
|
|
so->Method(*CauseGC(obj1, isolate));
|
|
// Should cause warning.
|
|
so->Method(CauseGCRaw(*obj1, isolate));
|
|
}
|
|
|
|
void TestOperatorCall(Isolate* isolate) {
|
|
SomeObject obj;
|
|
Handle<JSObject> obj1 = isolate->factory()->NewJSObjectWithNullProto();
|
|
// Should not cause warning.
|
|
obj = *CauseGC(obj1, isolate);
|
|
}
|
|
|
|
// --------- Test for templated sub-classes of Object ----------
|
|
|
|
void TestFollowingTemplates(Isolate* isolate) {
|
|
// Should cause warning.
|
|
CauseGCManaged(42, isolate);
|
|
}
|
|
|
|
// --------- Test for correctly resolving virtual methods ----------
|
|
|
|
class BaseObject {
|
|
public:
|
|
virtual Handle<Object> VirtualCauseGC(Handle<Object> obj, Isolate* isolate) {
|
|
return obj;
|
|
}
|
|
};
|
|
|
|
class DerivedObject : public BaseObject {
|
|
public:
|
|
Handle<Object> VirtualCauseGC(Handle<Object> obj, Isolate* isolate) override {
|
|
isolate->heap()->CollectGarbage(OLD_SPACE,
|
|
GarbageCollectionReason::kTesting);
|
|
|
|
return obj;
|
|
}
|
|
};
|
|
|
|
void TestFollowingVirtualFunctions(Isolate* isolate) {
|
|
DerivedObject derived;
|
|
BaseObject* base = &derived;
|
|
Handle<JSObject> obj1 = isolate->factory()->NewJSObjectWithNullProto();
|
|
|
|
SomeObject so;
|
|
Handle<SomeObject> so_handle = handle(so, isolate);
|
|
// Should cause warning.
|
|
so_handle->Method(*derived.VirtualCauseGC(obj1, isolate));
|
|
// Should cause warning.
|
|
so_handle->Method(*base->VirtualCauseGC(obj1, isolate));
|
|
}
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|