0ea5b5248d
When looking for private members in an object for the inspector, we check if that object is a class constructor with the a bit has_static_private_methods set on its SFI. If it is, we look for any variables in the context locals with a VariableMode associated with private methods or accessors and a IsStaticFlag being kStatic. This patch also filters out static private methods when inspecting instances. Design doc: https://docs.google.com/document/d/1N91LObhQexnB0eE7EvGe57HsvNMFX16CaWu-XCTnnmY/edit See also: https://docs.google.com/document/d/14maU596YbHcWR7XR-_iXM_ANhAAmiuRlJZysM61lqaE/edit Bug: v8:9839, v8:8330 Change-Id: Idad15349c983898de2ce632c38b0174da10e639d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955664 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/master@{#66636}
42 lines
1.4 KiB
JavaScript
42 lines
1.4 KiB
JavaScript
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
//
|
|
// Flags: --harmony-private-methods
|
|
|
|
let {session, contextGroup, Protocol} = InspectorTest.start("Check static private methods in object preview.");
|
|
|
|
Protocol.Debugger.enable();
|
|
Protocol.Runtime.enable();
|
|
Protocol.Runtime.onConsoleAPICalled(dumpInternalProperties);
|
|
|
|
contextGroup.setupInjectedScriptEnvironment();
|
|
|
|
InspectorTest.runAsyncTestSuite([
|
|
async function testPrivateMethods() {
|
|
const expressions = [
|
|
"class { static get #readOnly() { return 1; } }",
|
|
"class { static set #writeOnly(val) { } }",
|
|
"class { static #method() { return 1; } static get #accessor() { } static set #accessor(val) { } }",
|
|
"class extends class { } { static #method() { return 1; } }",
|
|
"class extends class { static #method() { return 1; } } { get #accessor() { } set #accessor(val) { } }",
|
|
];
|
|
for (const expression of expressions) {
|
|
InspectorTest.log(`expression: ${expression}`);
|
|
// Currently the previews are strings of the source code of the classes
|
|
await Protocol.Runtime.evaluate({
|
|
expression: `console.table(${expression})`,
|
|
generatePreview: true
|
|
});
|
|
}
|
|
}
|
|
]);
|
|
|
|
function dumpInternalProperties(message) {
|
|
try {
|
|
InspectorTest.logMessage(message.params.args[0]);
|
|
} catch {
|
|
InspectorTest.logMessage(message);
|
|
}
|
|
}
|