9349fb784f
This fixes a few issues: 1) It avoids using the {DeserializeOrCompile} API method, which is not used in chrome any more and will be deprecated soon. 2) It switches to the {DeserializeNativeModule} internal method, which really checks deserialization in isolation and does not fall back to compiling the wire bytes if the serialized bytes are incorrect. 3) It disables a test which tried to invalidate the number of functions, but the respective bytes were already zero, so nothing was invalidated. This still needs to be fixed in a follow-up CL. 4) It serializes the modules in a separate isolate, which then gets disposed to free references to the NativeModule and remove it from the modules cache. Otherwise we will just never deserialize, but use the cached module instead. R=thibaudm@chromium.org Bug: v8:6847, v8:10146 Change-Id: I37ef524a9c96c32fec2e7466488d67395fa5ccea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2010786 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#65888} |
||
---|---|---|
.. | ||
OWNERS | ||
test-c-wasm-entry.cc | ||
test-compilation-cache.cc | ||
test-grow-memory.cc | ||
test-jump-table-assembler.cc | ||
test-liftoff-inspection.cc | ||
test-run-wasm-64.cc | ||
test-run-wasm-asmjs.cc | ||
test-run-wasm-atomics64.cc | ||
test-run-wasm-atomics.cc | ||
test-run-wasm-bulk-memory.cc | ||
test-run-wasm-exceptions.cc | ||
test-run-wasm-interpreter.cc | ||
test-run-wasm-js.cc | ||
test-run-wasm-module.cc | ||
test-run-wasm-sign-extension.cc | ||
test-run-wasm-simd-liftoff.cc | ||
test-run-wasm-simd.cc | ||
test-run-wasm.cc | ||
test-streaming-compilation.cc | ||
test-wasm-breakpoints.cc | ||
test-wasm-codegen.cc | ||
test-wasm-import-wrapper-cache.cc | ||
test-wasm-interpreter-entry.cc | ||
test-wasm-serialization.cc | ||
test-wasm-shared-engine.cc | ||
test-wasm-stack.cc | ||
test-wasm-trap-position.cc | ||
wasm-atomics-utils.h | ||
wasm-run-utils.cc | ||
wasm-run-utils.h |