969cb0c7a5
This is a reland of 3cda21de77
Original change's description:
> V8 x64 backend doesn't emit ABI compliant stack frames
>
> On 64 bit Windows, the OS stack walking does not work because the V8 x64
> backend doesn't emit unwinding info and also because it doesn't emit ABI
> compliant stack frames. See
> https://docs.google.com/document/d/1-wf50jFlii0c_Pr52lm2ZU-49m220nhYMrHDi3vXnh0/edit
> for more details.
>
> This problem can be fixed by observing that V8 frames usually all have the same
> prolog and epilog:
>
> push rbp,
> mov rbp, rsp
> ...
> pop rbp
> ret N
>
> and that it is possible to define XDATA (UNWIND_CODEs) that specify how Windows
> should walk through V8 frames. Furthermore, since V8 Code objects are all
> allocated in the same code-range for an Isolate, it is possible to register a
> single PDATA/XDATA entry to cover stack walking for all the code generated
> inside that code-range.
>
> This PR contains changes required to enable stack walking on Win64:
>
> EmbeddedFileWriter now adds assembler directives to the builtins
> snapshot source file (embedded.cc) to emit additional entries in the .pdata and
> in the .xdata section of the V8 executable. This takes care of stack walking
> for embedded builtins. (The case of non-embedded builtins is not supported).
> The x64 Assembler has been modified to collect the information required to emit
> this unwind info for builtins.
>
> Stack walking for jitted code is handled is Isolate.cpp, by registering
> dynamically PDATA/XDATA for the whole code-range address space every time a new
> Isolate is initialized, and by unregistering them when the Isolate is
> destroyed.
>
> Stack walking for WASM jitted code is handled is the same way in
> wasm::NativeModule (wasm/wasm-code-manager.cpp).
>
> It is important to note that Crashpad and Breakpad are already registering
> PDATA/XDATA to manage and report unhandled exceptions (but not for embedded
> builtins). Since it is not possible to register multiple PDATA entries for the
> same address range, a new function is added to the V8 API:
> SetUnhandledExceptionCallback() can be used by an embedder to register its own
> unhandled exception handler for exceptions that arise in v8-generated code.
> V8 embedders should be modified accordingly (code for this is in a separate PR
> in the Chromium repository:
> https://chromium-review.googlesource.com/c/chromium/src/+/1474703).
>
> All these changes are experimental, behind:
>
> the 'v8_win64_unwinding_info' build flag, and
> the '--win64-unwinding-info' runtime flag.
>
> Bug: v8:3598
> Change-Id: Iea455ab6d0e2bf1c556aa1cf870841d44ab6e4b1
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1469329
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Commit-Queue: Paolo Severini <paolosev@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#60330}
Bug: v8:3598
Change-Id: If988baf7d3e4af165b919d6e54c1ad985f8e25e3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1534618
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Paolo Severini <paolosev@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#60581}
108 lines
3.7 KiB
C++
108 lines
3.7 KiB
C++
// Copyright 2019 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/base/win32-headers.h"
|
|
#include "src/v8.h"
|
|
#include "test/cctest/cctest.h"
|
|
|
|
class UnwindingWinX64Callbacks {
|
|
public:
|
|
UnwindingWinX64Callbacks() = default;
|
|
|
|
static void Getter(v8::Local<v8::String> name,
|
|
const v8::PropertyCallbackInfo<v8::Value>& info) {
|
|
// Expects to find at least 15 stack frames in the call stack.
|
|
// The stack walking should fail on stack frames for builtin functions if
|
|
// stack unwinding data has not been correctly registered.
|
|
int stack_frames = CountCallStackFrames(15);
|
|
CHECK_GE(stack_frames, 15);
|
|
}
|
|
static void Setter(v8::Local<v8::String> name, v8::Local<v8::Value> value,
|
|
const v8::PropertyCallbackInfo<void>& info) {}
|
|
|
|
private:
|
|
// Windows-specific code to walk the stack starting from the current
|
|
// instruction pointer.
|
|
static int CountCallStackFrames(int max_frames) {
|
|
CONTEXT context_record;
|
|
::RtlCaptureContext(&context_record);
|
|
|
|
int iframe = 0;
|
|
while (++iframe < max_frames) {
|
|
uint64_t image_base;
|
|
PRUNTIME_FUNCTION function_entry =
|
|
::RtlLookupFunctionEntry(context_record.Rip, &image_base, nullptr);
|
|
if (!function_entry) break;
|
|
|
|
void* handler_data;
|
|
uint64_t establisher_frame;
|
|
::RtlVirtualUnwind(UNW_FLAG_NHANDLER, image_base, context_record.Rip,
|
|
function_entry, &context_record, &handler_data,
|
|
&establisher_frame, NULL);
|
|
}
|
|
return iframe;
|
|
}
|
|
};
|
|
|
|
// Verifies that stack unwinding data has been correctly registered on Win/x64.
|
|
UNINITIALIZED_TEST(StackUnwindingWinX64) {
|
|
#ifdef V8_WIN64_UNWINDING_INFO
|
|
|
|
static const char* unwinding_win_x64_test_source =
|
|
"function start(count) {\n"
|
|
" for (var i = 0; i < count; i++) {\n"
|
|
" var o = instance.foo;\n"
|
|
" instance.foo = o + 1;\n"
|
|
" }\n"
|
|
"}\n";
|
|
|
|
// This test may fail on Windows 7
|
|
if (!::IsWindows8OrGreater()) {
|
|
return;
|
|
}
|
|
|
|
i::FLAG_allow_natives_syntax = true;
|
|
i::FLAG_win64_unwinding_info = true;
|
|
|
|
v8::Isolate::CreateParams create_params;
|
|
create_params.array_buffer_allocator = CcTest::array_buffer_allocator();
|
|
v8::Isolate* isolate = v8::Isolate::New(create_params);
|
|
isolate->Enter();
|
|
{
|
|
v8::HandleScope scope(isolate);
|
|
LocalContext env(isolate);
|
|
|
|
v8::Local<v8::FunctionTemplate> func_template =
|
|
v8::FunctionTemplate::New(isolate);
|
|
v8::Local<v8::ObjectTemplate> instance_template =
|
|
func_template->InstanceTemplate();
|
|
|
|
UnwindingWinX64Callbacks accessors;
|
|
v8::Local<v8::External> data = v8::External::New(isolate, &accessors);
|
|
instance_template->SetAccessor(v8_str("foo"),
|
|
&UnwindingWinX64Callbacks::Getter,
|
|
&UnwindingWinX64Callbacks::Setter, data);
|
|
v8::Local<v8::Function> func =
|
|
func_template->GetFunction(env.local()).ToLocalChecked();
|
|
v8::Local<v8::Object> instance =
|
|
func->NewInstance(env.local()).ToLocalChecked();
|
|
env->Global()->Set(env.local(), v8_str("instance"), instance).FromJust();
|
|
|
|
CompileRun(unwinding_win_x64_test_source);
|
|
v8::Local<v8::Function> function = v8::Local<v8::Function>::Cast(
|
|
env->Global()->Get(env.local(), v8_str("start")).ToLocalChecked());
|
|
|
|
CompileRun("%OptimizeFunctionOnNextCall(start);");
|
|
|
|
int32_t repeat_count = 100;
|
|
v8::Local<v8::Value> args[] = {v8::Integer::New(isolate, repeat_count)};
|
|
function->Call(env.local(), env.local()->Global(), arraysize(args), args)
|
|
.ToLocalChecked();
|
|
}
|
|
isolate->Exit();
|
|
isolate->Dispose();
|
|
|
|
#endif // V8_WIN64_UNWINDING_INFO
|
|
}
|