07011cc4f0
This replaces Runtime_RunMicrotasks with Runtime_PerformMicrotaskCheckpoint.
RunMicrotasks forcibly runs Microtasks even when the microtasks are suppressed,
and may causes nested Microtasks in a problematic way. E.g. that confuses
v8::MicrotasksScope::IsRunningMicrotasks() and GetEnteredOrMicrotaskContext().
OTOH, PerformMicrotaskCheckpoint() doesn't run cause the failure as it
respects the microtask suppressions.
As all existing tests don't call RunMicrotasks() in the suppressed situation
(like Promise.resolve().then(()=>{%RunMicrotasks();})), this change should
not affect to these tests.
Change-Id: Ib043a0cc8e482e022d375084d65ea98a6f54ef3d
Reviewed-on: https://chromium-review.googlesource.com/c/1360095
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58068}
62 lines
1.5 KiB
JavaScript
62 lines
1.5 KiB
JavaScript
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
|
|
load('../base.js');
|
|
|
|
new BenchmarkSuite('BasicExport', [100], [
|
|
new Benchmark('BasicExport', false, false, 0, BasicExport)
|
|
]);
|
|
|
|
new BenchmarkSuite('BasicImport', [100], [
|
|
new Benchmark('BasicImport', false, false, 0, BasicImport)
|
|
]);
|
|
|
|
new BenchmarkSuite('BasicNamespace', [100], [
|
|
new Benchmark('BasicNamespace', false, false, 0, BasicNamespace)
|
|
]);
|
|
|
|
const iterations = 10000;
|
|
|
|
|
|
function BasicExport() {
|
|
let success = false;
|
|
import("basic-export.js").then(m => { m.bench(); success = true; });
|
|
%PerformMicrotaskCheckpoint();
|
|
if (!success) throw new Error(666);
|
|
}
|
|
|
|
function BasicImport() {
|
|
let success = false;
|
|
import("basic-import.js").then(m => { m.bench(); success = true; });
|
|
%PerformMicrotaskCheckpoint();
|
|
if (!success) throw new Error(666);
|
|
}
|
|
|
|
function BasicNamespace() {
|
|
let success = false;
|
|
import("basic-namespace.js").then(m => { m.bench(); success = true; });
|
|
%PerformMicrotaskCheckpoint();
|
|
if (!success) throw new Error(666);
|
|
}
|
|
|
|
|
|
var success = true;
|
|
|
|
function PrintResult(name, result) {
|
|
print(name + '-Modules(Score): ' + result);
|
|
}
|
|
|
|
function PrintError(name, error) {
|
|
PrintResult(name, error);
|
|
success = false;
|
|
}
|
|
|
|
|
|
BenchmarkSuite.config.doWarmup = undefined;
|
|
BenchmarkSuite.config.doDeterministic = undefined;
|
|
|
|
BenchmarkSuite.RunSuites({ NotifyResult: PrintResult,
|
|
NotifyError: PrintError });
|