e861dbbcf1
This CL updates DetachableVector to store the data at a known place instead of in an std::vector<>, so that builtins can update it directly. Bug: v8:8124 Change-Id: Iba5fb2e9d4e0ddc689d0f7eeaea40bc3218edf3a Reviewed-on: https://chromium-review.googlesource.com/c/1297783 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#57452}
128 lines
3.3 KiB
C++
128 lines
3.3 KiB
C++
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/detachable-vector.h"
|
|
|
|
#include "testing/gtest/include/gtest/gtest.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
TEST(DetachableVector, ConstructIsEmpty) {
|
|
DetachableVector<int> v;
|
|
|
|
size_t empty_size = 0;
|
|
EXPECT_EQ(empty_size, v.size());
|
|
EXPECT_TRUE(v.empty());
|
|
}
|
|
|
|
TEST(DetachableVector, PushAddsElement) {
|
|
DetachableVector<int> v;
|
|
|
|
v.push_back(1);
|
|
|
|
EXPECT_EQ(1, v.front());
|
|
EXPECT_EQ(1, v.back());
|
|
EXPECT_EQ(1, v.at(0));
|
|
size_t one_size = 1;
|
|
EXPECT_EQ(one_size, v.size());
|
|
EXPECT_FALSE(v.empty());
|
|
}
|
|
|
|
TEST(DetachableVector, AfterFreeIsEmpty) {
|
|
DetachableVector<int> v;
|
|
|
|
v.push_back(1);
|
|
v.free();
|
|
|
|
size_t empty_size = 0;
|
|
EXPECT_EQ(empty_size, v.size());
|
|
EXPECT_TRUE(v.empty());
|
|
}
|
|
|
|
// This test relies on ASAN to detect leaks and double-frees.
|
|
TEST(DetachableVector, DetachLeaksBackingStore) {
|
|
DetachableVector<int> v;
|
|
DetachableVector<int> v2;
|
|
|
|
size_t one_size = 1;
|
|
EXPECT_TRUE(v2.empty());
|
|
|
|
// Force allocation of the backing store.
|
|
v.push_back(1);
|
|
// Bit-copy the data structure.
|
|
memcpy(&v2, &v, sizeof(DetachableVector<int>));
|
|
// The backing store should be leaked here - free was not called.
|
|
v.detach();
|
|
|
|
// We have transferred the backing store to the second vector.
|
|
EXPECT_EQ(one_size, v2.size());
|
|
EXPECT_TRUE(v.empty());
|
|
|
|
// The destructor of v2 will release the backing store.
|
|
}
|
|
|
|
TEST(DetachableVector, PushAndPopWithReallocation) {
|
|
DetachableVector<size_t> v;
|
|
const size_t kMinimumCapacity = DetachableVector<size_t>::kMinimumCapacity;
|
|
|
|
EXPECT_EQ(0u, v.capacity());
|
|
EXPECT_EQ(0u, v.size());
|
|
v.push_back(0);
|
|
EXPECT_EQ(kMinimumCapacity, v.capacity());
|
|
EXPECT_EQ(1u, v.size());
|
|
|
|
// Push values until the reallocation happens.
|
|
for (size_t i = 1; i <= kMinimumCapacity; ++i) {
|
|
v.push_back(i);
|
|
}
|
|
EXPECT_EQ(2 * kMinimumCapacity, v.capacity());
|
|
EXPECT_EQ(kMinimumCapacity + 1, v.size());
|
|
|
|
EXPECT_EQ(kMinimumCapacity, v.back());
|
|
v.pop_back();
|
|
|
|
v.push_back(100);
|
|
EXPECT_EQ(100u, v.back());
|
|
v.pop_back();
|
|
EXPECT_EQ(kMinimumCapacity - 1, v.back());
|
|
}
|
|
|
|
TEST(DetachableVector, ShrinkToFit) {
|
|
DetachableVector<size_t> v;
|
|
const size_t kMinimumCapacity = DetachableVector<size_t>::kMinimumCapacity;
|
|
|
|
// shrink_to_fit doesn't affect the empty capacity DetachableVector.
|
|
EXPECT_EQ(0u, v.capacity());
|
|
v.shrink_to_fit();
|
|
EXPECT_EQ(0u, v.capacity());
|
|
|
|
// Do not shrink the buffer if it's smaller than kMinimumCapacity.
|
|
v.push_back(0);
|
|
EXPECT_EQ(kMinimumCapacity, v.capacity());
|
|
v.shrink_to_fit();
|
|
EXPECT_EQ(kMinimumCapacity, v.capacity());
|
|
|
|
// Fill items to |v| until the buffer grows twice.
|
|
for (size_t i = 0; i < 2 * kMinimumCapacity; ++i) {
|
|
v.push_back(i);
|
|
}
|
|
EXPECT_EQ(2 * kMinimumCapacity + 1, v.size());
|
|
EXPECT_EQ(4 * kMinimumCapacity, v.capacity());
|
|
|
|
// Do not shrink the buffer if the number of unused slots is not large enough.
|
|
v.shrink_to_fit();
|
|
EXPECT_EQ(2 * kMinimumCapacity + 1, v.size());
|
|
EXPECT_EQ(4 * kMinimumCapacity, v.capacity());
|
|
|
|
v.pop_back();
|
|
v.pop_back();
|
|
v.shrink_to_fit();
|
|
EXPECT_EQ(2 * kMinimumCapacity - 1, v.size());
|
|
EXPECT_EQ(2 * kMinimumCapacity - 1, v.capacity());
|
|
}
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|