fe3d51e1b2
Currently, debugger pauses on async call schedule and then waits for Debugger.pauseOnAsyncCall with parentStackTraceId to actually schedule the pause. This CL combines these two steps: - For local async tasks, it just stores m_taskWithScheduledBreak at the time of schedule, to be able to pause once this task is run. - For external async tasks, it plumbs "should_pause" boolean in V8StackTraceId from the point of schedule to the point of execution, and schedules a pause once externalAsyncTaskStarted is called with "should_pause" set to true. This approach greatly simplifies the implementation, and reduced frontend to a single "breakOnAsyncCall: true" parameter in Debugger.stepInto. Drive-by: introduce hasScheduledBreakOnNextFunctionCall() to make SetBreakOnNextFunctionCall management more robust. Note: artificial pauses at async call schedule time are gone from test expectations - we now only pause when user actually wants to pause, which makes protocol much simpler. See also design doc linked in the bug. BUG=chromium:1000475 Change-Id: I2d16f79c599fe196b2aaeca8223c63437a2954a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1783724 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#63737}
205 lines
6.2 KiB
JavaScript
205 lines
6.2 KiB
JavaScript
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
let {session, contextGroup, Protocol} = InspectorTest.start('Checks Debugger.scheduleStepIntoAsync.');
|
|
|
|
contextGroup.addScript(`
|
|
function testNoScheduledTask() {
|
|
debugger;
|
|
return 42;
|
|
}
|
|
|
|
function testSimple() {
|
|
debugger;
|
|
Promise.resolve().then(v => v * 2);
|
|
}
|
|
|
|
function testNotResolvedPromise() {
|
|
var resolveCallback;
|
|
var p = new Promise(resolve => resolveCallback = resolve);
|
|
debugger;
|
|
p.then(v => v * 2);
|
|
resolveCallback();
|
|
}
|
|
|
|
function testTwoAsyncTasks() {
|
|
debugger;
|
|
Promise.resolve().then(v => v * 2);
|
|
Promise.resolve().then(v => v * 4);
|
|
}
|
|
|
|
function testTwoAsyncTasksWithBreak() {
|
|
debugger;
|
|
Promise.resolve().then(v => v * 2);
|
|
debugger;
|
|
Promise.resolve().then(v => v * 4);
|
|
}
|
|
|
|
function testPromiseAll() {
|
|
debugger;
|
|
Promise.all([ Promise.resolve(), Promise.resolve() ]).then(v => v * 2);
|
|
}
|
|
|
|
function testBlackboxedCreatePromise() {
|
|
debugger;
|
|
createPromise().then(v => v * 2);
|
|
}
|
|
|
|
async function testAsyncFunction() {
|
|
debugger;
|
|
foo();
|
|
await foo();
|
|
foo().then(boo);
|
|
|
|
async function foo() {
|
|
return 42;
|
|
}
|
|
|
|
function boo() {
|
|
}
|
|
}
|
|
//# sourceURL=test.js`);
|
|
|
|
contextGroup.addScript(`
|
|
|
|
function createPromise() {
|
|
return Promise.resolve().then(v => v * 3).then(v => v * 4);
|
|
}
|
|
|
|
//# sourceURL=framework.js`)
|
|
|
|
session.setupScriptMap();
|
|
|
|
Protocol.Debugger.enable();
|
|
Protocol.Debugger.setAsyncCallStackDepth({maxDepth: 128});
|
|
InspectorTest.runAsyncTestSuite([
|
|
async function testScheduleErrors() {
|
|
Protocol.Runtime.evaluate({ expression: 'testNoScheduledTask()' });
|
|
await waitPauseAndDumpLocation();
|
|
Protocol.Debugger.stepInto({breakOnAsyncCall: true});
|
|
await waitPauseAndDumpLocation();
|
|
Protocol.Debugger.stepInto({breakOnAsyncCall: true});
|
|
await waitPauseAndDumpLocation();
|
|
await Protocol.Debugger.resume();
|
|
},
|
|
|
|
async function testSimple() {
|
|
Protocol.Runtime.evaluate({ expression: 'testSimple()' });
|
|
await waitPauseAndDumpLocation();
|
|
Protocol.Debugger.stepOver();
|
|
await waitPauseAndDumpLocation();
|
|
Protocol.Debugger.stepInto({breakOnAsyncCall: true});
|
|
await waitPauseAndDumpLocation();
|
|
await Protocol.Debugger.resume();
|
|
},
|
|
|
|
async function testNotResolvedPromise() {
|
|
Protocol.Runtime.evaluate({ expression: 'testNotResolvedPromise()' });
|
|
await waitPauseAndDumpLocation();
|
|
Protocol.Debugger.stepOver();
|
|
await waitPauseAndDumpLocation();
|
|
Protocol.Debugger.stepInto({breakOnAsyncCall: true});
|
|
await waitPauseAndDumpLocation();
|
|
await Protocol.Debugger.resume();
|
|
},
|
|
|
|
async function testTwoAsyncTasks() {
|
|
Protocol.Runtime.evaluate({ expression: 'testTwoAsyncTasks()' });
|
|
await waitPauseAndDumpLocation();
|
|
Protocol.Debugger.stepInto();
|
|
await waitPauseAndDumpLocation();
|
|
Protocol.Debugger.stepInto({breakOnAsyncCall: true});
|
|
await waitPauseAndDumpLocation();
|
|
await Protocol.Debugger.resume();
|
|
},
|
|
|
|
async function testTwoTasksAndGoToSecond() {
|
|
Protocol.Runtime.evaluate({ expression: 'testTwoAsyncTasks()' });
|
|
await waitPauseAndDumpLocation();
|
|
Protocol.Debugger.stepOver();
|
|
await waitPauseAndDumpLocation();
|
|
Protocol.Debugger.stepOver();
|
|
await waitPauseAndDumpLocation();
|
|
Protocol.Debugger.stepInto({breakOnAsyncCall: true});
|
|
await waitPauseAndDumpLocation();
|
|
await Protocol.Debugger.resume();
|
|
},
|
|
|
|
async function testTwoAsyncTasksWithBreak() {
|
|
Protocol.Runtime.evaluate({ expression: 'testTwoAsyncTasksWithBreak()' });
|
|
await waitPauseAndDumpLocation();
|
|
Protocol.Debugger.stepOver();
|
|
await waitPauseAndDumpLocation();
|
|
Protocol.Debugger.stepInto({breakOnAsyncCall: true});
|
|
await waitPauseAndDumpLocation();
|
|
Protocol.Debugger.stepOver();
|
|
await waitPauseAndDumpLocation();
|
|
Protocol.Debugger.stepInto({breakOnAsyncCall: true});
|
|
await waitPauseAndDumpLocation();
|
|
await Protocol.Debugger.resume();
|
|
},
|
|
|
|
async function testPromiseAll() {
|
|
Protocol.Runtime.evaluate({ expression: 'testPromiseAll()' });
|
|
await waitPauseAndDumpLocation();
|
|
Protocol.Debugger.stepOver();
|
|
await waitPauseAndDumpLocation();
|
|
Protocol.Debugger.stepInto({breakOnAsyncCall: true});
|
|
await waitPauseAndDumpLocation();
|
|
await Protocol.Debugger.resume();
|
|
},
|
|
|
|
async function testWithBlackboxedCode() {
|
|
Protocol.Runtime.evaluate({ expression: 'testBlackboxedCreatePromise()' });
|
|
await waitPauseAndDumpLocation();
|
|
Protocol.Debugger.stepOver();
|
|
await waitPauseAndDumpLocation();
|
|
await Protocol.Debugger.setBlackboxPatterns({patterns: ['framework\.js'] });
|
|
Protocol.Debugger.stepInto({breakOnAsyncCall: true});
|
|
await waitPauseAndDumpLocation();
|
|
await Protocol.Debugger.resume();
|
|
},
|
|
|
|
async function testWithBlackboxedCode() {
|
|
Protocol.Runtime.evaluate({expression: 'testBlackboxedCreatePromise()'});
|
|
await waitPauseAndDumpLocation();
|
|
Protocol.Debugger.stepOver();
|
|
await waitPauseAndDumpLocation();
|
|
await Protocol.Debugger.setBlackboxPatterns({patterns: ['framework\.js']});
|
|
Protocol.Debugger.stepInto({breakOnAsyncCall: true});
|
|
await waitPauseAndDumpLocation();
|
|
await Protocol.Debugger.resume();
|
|
},
|
|
|
|
async function testAsyncFunction() {
|
|
Protocol.Runtime.evaluate({expression: 'testAsyncFunction()'});
|
|
await waitPauseAndDumpLocation();
|
|
Protocol.Debugger.stepOver();
|
|
await waitPauseAndDumpLocation();
|
|
Protocol.Debugger.stepInto({breakOnAsyncCall: true});
|
|
await waitPauseAndDumpLocation();
|
|
Protocol.Debugger.stepOut();
|
|
await waitPauseAndDumpLocation();
|
|
Protocol.Debugger.stepInto({breakOnAsyncCall: true});
|
|
await waitPauseAndDumpLocation();
|
|
Protocol.Debugger.stepOut();
|
|
await waitPauseAndDumpLocation();
|
|
Protocol.Debugger.stepInto({breakOnAsyncCall: true});
|
|
await waitPauseAndDumpLocation();
|
|
Protocol.Debugger.stepOut();
|
|
await waitPauseAndDumpLocation();
|
|
Protocol.Debugger.stepInto({breakOnAsyncCall: true});
|
|
await waitPauseAndDumpLocation();
|
|
|
|
await Protocol.Debugger.resume();
|
|
}
|
|
]);
|
|
|
|
async function waitPauseAndDumpLocation() {
|
|
var {params: {callFrames}} =
|
|
await Protocol.Debugger.oncePaused();
|
|
InspectorTest.log('paused at:');
|
|
await session.logSourceLocation(callFrames[0].location);
|
|
}
|