ed9b2072a6
Old instrumentation was designed to collect promise creation stack and promise scheduled stack together. In DevTools for last 6 months we show only creation stack for promises. We got strong support from users for new model. Now we can drop support for scheduled stacks and simplify implementation. New promise instrumentation is straightforward: - we send kDebugPromiseThen when promise is created by .then call, - we send kDebugPromiseCatch when promise is created by .catch call, - we send kDebugWillHandle before chained callback and kDebugDidHandle after chained callback, - and we send separate kDebugAsyncFunctionPromiseCreated for internal promise inside async await function. Advantages: - we reduce amount of captured stacks (we do not capture stack for promise that constructed not by .then or .catch), - we can consider async task related to .then and .catch as one shot since chained callback is executed once, - on V8 side we can implement required instrumentation using only promise hooks, Disadvantage: - see await-promise test, sometimes scheduled stack was useful since we add catch handler in native code, Implementation details: - on kInit promise hook we need to figure out why promise was created. We analyze builtin functions until first user defined function on current stack. If there is kAsyncFunctionPromiseCreate function then we send kDebugAsyncFunctionPromiseCreated event. If there is kPromiseThen or kPromiseCatch then only if this function is bottom builtin function we send corresponded event to inspector. We need it because Promise.all internally calls .then and in this case we have Promise.all and Promise.then on stack at the same time and we do not need to report this internally created promise to inspector. Bug: chromium:778796 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I53f47ce8c5c4a9897655c3396c249ea59529ae47 Reviewed-on: https://chromium-review.googlesource.com/765208 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#49553}
134 lines
2.9 KiB
Plaintext
134 lines
2.9 KiB
Plaintext
Checks that async chains for promises are correct.
|
|
|
|
Running test: testPromise
|
|
foo1 (test.js:9:2)
|
|
-- Promise.then --
|
|
promise (test.js:19:14)
|
|
(anonymous) (testPromise.js:0:0)
|
|
|
|
|
|
Running test: testPromiseResolvedBySetTimeout
|
|
foo1 (test.js:9:2)
|
|
-- Promise.then --
|
|
promiseResolvedBySetTimeout (test.js:27:14)
|
|
(anonymous) (testPromiseResolvedBySetTimeout.js:0:0)
|
|
|
|
|
|
Running test: testPromiseAll
|
|
foo1 (test.js:9:2)
|
|
-- Promise.then --
|
|
promiseAll (test.js:37:35)
|
|
(anonymous) (testPromiseAll.js:0:0)
|
|
|
|
|
|
Running test: testPromiseAllReverseOrder
|
|
foo1 (test.js:9:2)
|
|
-- Promise.then --
|
|
promiseAllReverseOrder (test.js:48:35)
|
|
(anonymous) (testPromiseAllReverseOrder.js:0:0)
|
|
|
|
|
|
Running test: testPromiseRace
|
|
foo1 (test.js:9:2)
|
|
-- Promise.then --
|
|
promiseRace (test.js:59:36)
|
|
(anonymous) (testPromiseRace.js:0:0)
|
|
|
|
|
|
Running test: testTwoChainedCallbacks
|
|
foo1 (test.js:9:2)
|
|
-- Promise.then --
|
|
twoChainedCallbacks (test.js:68:14)
|
|
(anonymous) (testTwoChainedCallbacks.js:0:0)
|
|
|
|
foo2 (test.js:13:2)
|
|
-- Promise.then --
|
|
twoChainedCallbacks (test.js:68:25)
|
|
(anonymous) (testTwoChainedCallbacks.js:0:0)
|
|
|
|
|
|
Running test: testPromiseResolve
|
|
foo1 (test.js:9:2)
|
|
-- Promise.then --
|
|
promiseResolve (test.js:74:27)
|
|
(anonymous) (testPromiseResolve.js:0:0)
|
|
|
|
foo2 (test.js:13:2)
|
|
-- Promise.then --
|
|
promiseResolve (test.js:74:38)
|
|
(anonymous) (testPromiseResolve.js:0:0)
|
|
|
|
|
|
Running test: testThenableJobResolvedInSetTimeout
|
|
foo1 (test.js:9:2)
|
|
-- Promise.then --
|
|
thenableJobResolvedInSetTimeout (test.js:86:40)
|
|
(anonymous) (testThenableJobResolvedInSetTimeout.js:0:0)
|
|
|
|
|
|
Running test: testThenableJobResolvedInSetTimeoutWithStack
|
|
foo1 (test.js:9:2)
|
|
-- Promise.then --
|
|
thenableJobResolvedInSetTimeoutWithStack (test.js:104:40)
|
|
(anonymous) (testThenableJobResolvedInSetTimeoutWithStack.js:0:0)
|
|
|
|
|
|
Running test: testThenableJobResolvedByPromise
|
|
foo1 (test.js:9:2)
|
|
-- Promise.then --
|
|
thenableJobResolvedByPromise (test.js:118:40)
|
|
(anonymous) (testThenableJobResolvedByPromise.js:0:0)
|
|
|
|
|
|
Running test: testThenableJobResolvedByPromiseWithStack
|
|
foo1 (test.js:9:2)
|
|
-- Promise.then --
|
|
thenableJobResolvedByPromiseWithStack (test.js:136:40)
|
|
(anonymous) (testThenableJobResolvedByPromiseWithStack.js:0:0)
|
|
|
|
|
|
Running test: testLateThenCallback
|
|
foo1 (test.js:9:2)
|
|
-- Promise.then --
|
|
lateThenCallback (test.js:145:12)
|
|
(anonymous) (testLateThenCallback.js:0:0)
|
|
|
|
|
|
Running test: testComplex
|
|
inner1 (test.js:154:6)
|
|
foo1 (test.js:156:4)
|
|
-- Promise.then --
|
|
complex (test.js:202:5)
|
|
(anonymous) (testComplex.js:0:0)
|
|
|
|
p.then (test.js:207:8)
|
|
-- Promise.then --
|
|
p.then (test.js:206:8)
|
|
-- Promise.then --
|
|
setTimeout (test.js:205:6)
|
|
-- setTimeout --
|
|
complex (test.js:204:2)
|
|
(anonymous) (testComplex.js:0:0)
|
|
|
|
|
|
Running test: testReject
|
|
foo1 (test.js:9:2)
|
|
-- Promise.catch --
|
|
reject (test.js:217:31)
|
|
(anonymous) (testReject.js:0:0)
|
|
|
|
|
|
Running test: testFinally1
|
|
foo1 (test.js:9:2)
|
|
-- Promise.finally --
|
|
finally1 (test.js:221:33)
|
|
(anonymous) (testFinally1.js:0:0)
|
|
|
|
|
|
Running test: testFinally2
|
|
foo1 (test.js:9:2)
|
|
-- Promise.finally --
|
|
finally2 (test.js:225:34)
|
|
(anonymous) (testFinally2.js:0:0)
|
|
|