2cb8a6e349
Bytecode flushing can make tests using assertOptimized flaky if the bytecode is flushed between marking and optimization. It can also be flaky if the feedback vector is collected before optimization. To prevent this, a new %PrepareForOptimization runtime-test function is added that hold onto the bytecode strongly until it is optimized after being explicitly marked for optimization by %OptimizeFunctionOnNextCall. BUG=v8:8801,v8:8395 Change-Id: Idbd962a3a2044b915903f9c5e92d1789942b5b41 Reviewed-on: https://chromium-review.googlesource.com/c/1463525 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#59914}
38 lines
1.2 KiB
JavaScript
38 lines
1.2 KiB
JavaScript
// Copyright 2018 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax --opt --noalways-opt
|
|
|
|
// Test that String.fromCodePoint() properly identifies zeros.
|
|
(function() {
|
|
function foo(x) {
|
|
return String.fromCodePoint(x);
|
|
}
|
|
|
|
%PrepareFunctionForOptimization(foo);
|
|
assertEquals("\u0000", foo(0));
|
|
assertEquals("\u0000", foo(-0));
|
|
%OptimizeFunctionOnNextCall(foo);
|
|
assertEquals("\u0000", foo(0));
|
|
assertEquals("\u0000", foo(-0));
|
|
assertOptimized(foo);
|
|
|
|
// Prepare foo to be re-optimized, ensuring it's bytecode / feedback vector
|
|
// doesn't get flushed after deoptimization.
|
|
%PrepareFunctionForOptimization(foo);
|
|
|
|
// Now passing anything outside the valid code point
|
|
// range should invalidate the optimized code.
|
|
assertThrows(_ => foo(-1));
|
|
assertUnoptimized(foo);
|
|
|
|
// And TurboFan should not inline the builtin anymore
|
|
// from now on (aka no deoptimization loop).
|
|
%OptimizeFunctionOnNextCall(foo);
|
|
assertEquals("\u0000", foo(0));
|
|
assertEquals("\u0000", foo(-0));
|
|
assertThrows(_ => foo(-1));
|
|
assertOptimized(foo);
|
|
})();
|