388a80bab7
This CL adds a new snapshot to hold objects that are in the shared heap or may need to be in the shared heap depending on runtime flags. Currently this is to support --shared-string-table, which puts all in-place-internalizable strings, internalized strings, and the string table into the shared heap. The shared heap snapshot is never deserialized into client Isolates. This means when V8 is started without a shared Isolate, the shared heap snapshot is deserialized into all Isolates. Bug: v8:12007 Change-Id: I7eeab73080cda2e8250a5a49747f25b2440a349d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3173905 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#77309}
208 lines
6.6 KiB
C++
208 lines
6.6 KiB
C++
// Copyright 2021 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "include/v8-array-buffer.h"
|
|
#include "include/v8-initialization.h"
|
|
#include "include/v8-isolate.h"
|
|
#include "src/common/globals.h"
|
|
#include "src/handles/handles-inl.h"
|
|
#include "src/heap/heap.h"
|
|
#include "src/heap/read-only-spaces.h"
|
|
#include "src/objects/fixed-array-inl.h"
|
|
#include "src/objects/fixed-array.h"
|
|
#include "src/objects/heap-object.h"
|
|
#include "test/cctest/cctest.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
namespace {
|
|
const int kNumIterations = 2000;
|
|
|
|
template <typename Callback>
|
|
void SetupClientIsolateAndRunCallback(Isolate* shared_isolate,
|
|
Callback callback) {
|
|
std::unique_ptr<v8::ArrayBuffer::Allocator> allocator(
|
|
v8::ArrayBuffer::Allocator::NewDefaultAllocator());
|
|
|
|
v8::Isolate::CreateParams create_params;
|
|
create_params.array_buffer_allocator = allocator.get();
|
|
create_params.experimental_attach_to_shared_isolate =
|
|
reinterpret_cast<v8::Isolate*>(shared_isolate);
|
|
v8::Isolate* client_isolate = v8::Isolate::New(create_params);
|
|
Isolate* i_client_isolate = reinterpret_cast<Isolate*>(client_isolate);
|
|
|
|
callback(client_isolate, i_client_isolate);
|
|
|
|
client_isolate->Dispose();
|
|
}
|
|
|
|
class SharedOldSpaceAllocationThread final : public v8::base::Thread {
|
|
public:
|
|
explicit SharedOldSpaceAllocationThread(Isolate* shared)
|
|
: v8::base::Thread(
|
|
base::Thread::Options("SharedOldSpaceAllocationThread")),
|
|
shared_(shared) {}
|
|
|
|
void Run() override {
|
|
SetupClientIsolateAndRunCallback(shared_, [](v8::Isolate* client_isolate,
|
|
Isolate* i_client_isolate) {
|
|
HandleScope scope(i_client_isolate);
|
|
|
|
for (int i = 0; i < kNumIterations; i++) {
|
|
i_client_isolate->factory()->NewFixedArray(10,
|
|
AllocationType::kSharedOld);
|
|
}
|
|
|
|
CcTest::CollectGarbage(OLD_SPACE, i_client_isolate);
|
|
|
|
v8::platform::PumpMessageLoop(i::V8::GetCurrentPlatform(),
|
|
client_isolate);
|
|
});
|
|
}
|
|
|
|
Isolate* shared_;
|
|
};
|
|
} // namespace
|
|
|
|
UNINITIALIZED_TEST(ConcurrentAllocationInSharedOldSpace) {
|
|
if (!ReadOnlyHeap::IsReadOnlySpaceShared()) return;
|
|
std::unique_ptr<v8::ArrayBuffer::Allocator> allocator(
|
|
v8::ArrayBuffer::Allocator::NewDefaultAllocator());
|
|
|
|
v8::Isolate::CreateParams create_params;
|
|
create_params.array_buffer_allocator = allocator.get();
|
|
Isolate* shared_isolate = Isolate::NewShared(create_params);
|
|
|
|
std::vector<std::unique_ptr<SharedOldSpaceAllocationThread>> threads;
|
|
const int kThreads = 4;
|
|
|
|
for (int i = 0; i < kThreads; i++) {
|
|
auto thread =
|
|
std::make_unique<SharedOldSpaceAllocationThread>(shared_isolate);
|
|
CHECK(thread->Start());
|
|
threads.push_back(std::move(thread));
|
|
}
|
|
|
|
for (auto& thread : threads) {
|
|
thread->Join();
|
|
}
|
|
|
|
Isolate::Delete(shared_isolate);
|
|
}
|
|
|
|
namespace {
|
|
class SharedMapSpaceAllocationThread final : public v8::base::Thread {
|
|
public:
|
|
explicit SharedMapSpaceAllocationThread(Isolate* shared)
|
|
: v8::base::Thread(
|
|
base::Thread::Options("SharedMapSpaceAllocationThread")),
|
|
shared_(shared) {}
|
|
|
|
void Run() override {
|
|
SetupClientIsolateAndRunCallback(
|
|
shared_, [](v8::Isolate* client_isolate, Isolate* i_client_isolate) {
|
|
HandleScope scope(i_client_isolate);
|
|
|
|
for (int i = 0; i < kNumIterations; i++) {
|
|
i_client_isolate->factory()->NewMap(
|
|
NATIVE_CONTEXT_TYPE, kVariableSizeSentinel,
|
|
TERMINAL_FAST_ELEMENTS_KIND, 0, AllocationType::kSharedMap);
|
|
}
|
|
|
|
CcTest::CollectGarbage(OLD_SPACE, i_client_isolate);
|
|
|
|
v8::platform::PumpMessageLoop(i::V8::GetCurrentPlatform(),
|
|
client_isolate);
|
|
});
|
|
}
|
|
|
|
Isolate* shared_;
|
|
};
|
|
} // namespace
|
|
|
|
UNINITIALIZED_TEST(ConcurrentAllocationInSharedMapSpace) {
|
|
if (!ReadOnlyHeap::IsReadOnlySpaceShared()) return;
|
|
std::unique_ptr<v8::ArrayBuffer::Allocator> allocator(
|
|
v8::ArrayBuffer::Allocator::NewDefaultAllocator());
|
|
|
|
v8::Isolate::CreateParams create_params;
|
|
create_params.array_buffer_allocator = allocator.get();
|
|
Isolate* shared_isolate = Isolate::NewShared(create_params);
|
|
|
|
std::vector<std::unique_ptr<SharedMapSpaceAllocationThread>> threads;
|
|
const int kThreads = 4;
|
|
|
|
for (int i = 0; i < kThreads; i++) {
|
|
auto thread =
|
|
std::make_unique<SharedMapSpaceAllocationThread>(shared_isolate);
|
|
CHECK(thread->Start());
|
|
threads.push_back(std::move(thread));
|
|
}
|
|
|
|
for (auto& thread : threads) {
|
|
thread->Join();
|
|
}
|
|
|
|
Isolate::Delete(shared_isolate);
|
|
}
|
|
|
|
UNINITIALIZED_TEST(SharedCollectionWithoutClients) {
|
|
if (!ReadOnlyHeap::IsReadOnlySpaceShared()) return;
|
|
std::unique_ptr<v8::ArrayBuffer::Allocator> allocator(
|
|
v8::ArrayBuffer::Allocator::NewDefaultAllocator());
|
|
|
|
v8::Isolate::CreateParams create_params;
|
|
create_params.array_buffer_allocator = allocator.get();
|
|
Isolate* shared_isolate = Isolate::NewShared(create_params);
|
|
|
|
DCHECK_NULL(shared_isolate->heap()->new_space());
|
|
DCHECK_NULL(shared_isolate->heap()->new_lo_space());
|
|
|
|
CcTest::CollectGarbage(OLD_SPACE, shared_isolate);
|
|
Isolate::Delete(shared_isolate);
|
|
}
|
|
|
|
void AllocateInSharedHeap(Isolate* shared_isolate) {
|
|
SetupClientIsolateAndRunCallback(
|
|
shared_isolate,
|
|
[](v8::Isolate* client_isolate, Isolate* i_client_isolate) {
|
|
HandleScope scope(i_client_isolate);
|
|
std::vector<Handle<FixedArray>> arrays;
|
|
const int kKeptAliveArrays = 1000;
|
|
|
|
for (int i = 0; i < kNumIterations * 100; i++) {
|
|
HandleScope scope(i_client_isolate);
|
|
Handle<FixedArray> array = i_client_isolate->factory()->NewFixedArray(
|
|
100, AllocationType::kSharedOld);
|
|
if (i < kKeptAliveArrays) {
|
|
// Keep some of those arrays alive across GCs.
|
|
arrays.push_back(scope.CloseAndEscape(array));
|
|
}
|
|
}
|
|
|
|
for (Handle<FixedArray> array : arrays) {
|
|
CHECK_EQ(array->length(), 100);
|
|
}
|
|
});
|
|
}
|
|
|
|
UNINITIALIZED_TEST(SharedCollectionWithOneClient) {
|
|
FLAG_max_old_space_size = 8;
|
|
if (!ReadOnlyHeap::IsReadOnlySpaceShared()) return;
|
|
std::unique_ptr<v8::ArrayBuffer::Allocator> allocator(
|
|
v8::ArrayBuffer::Allocator::NewDefaultAllocator());
|
|
|
|
v8::Isolate::CreateParams create_params;
|
|
create_params.array_buffer_allocator = allocator.get();
|
|
Isolate* shared_isolate = Isolate::NewShared(create_params);
|
|
|
|
AllocateInSharedHeap(shared_isolate);
|
|
|
|
Isolate::Delete(shared_isolate);
|
|
}
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|