fb6a094db5
This CL improves break locations for expressions like 'var a = <expr>'. Without CL we use <expr> position as break location for initialization statement, with this CL we use position of first character after '=' as position.
Benefits (see test for details):
- only one break in expressions which includes mix of property lookup and calls, e.g. var p = Promise.resolve().then(x => x * 2),
- removed redundant break location for expressions like: let { x, y } = { x: 1, y: 2}.
TBR=dgozman@chromium.org,rmcilroy@chromium.org,machenbach@chromium.org,marja@chromium.org,kozyatinskiy@chromium.org,devtools-reviews@chromium.org,v8-reviews@googlegroups.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: v8:5909
Change-Id: Ie84fa79afeed09e28cf8478ba610a0cfbfdfc294
Reviewed-on: https://chromium-review.googlesource.com/518116
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#45598}
178 lines
3.7 KiB
Plaintext
178 lines
3.7 KiB
Plaintext
Checks Debugger.getPossibleBreakpoints with ignoreNestedFunctions
|
|
|
|
Running test: testWholeFunction
|
|
|
|
function test() {
|
|
|_|Array.|C|from([1,2]).|C|map(() => |_|1|R|).|C|filter(() => |_|true|R|);
|
|
function nested1() {
|
|
|_|Array.|C|from([1,2]).|C|map(() => |_|1|R|).|C|filter(() => |_|true|R|);
|
|
|R|}
|
|
function nested2() {
|
|
|_|Array.|C|from([1,2]).|C|map(() => |_|1|R|).|C|filter(() => |_|true|R|);
|
|
|R|}
|
|
|C|nested1();
|
|
|C|nested2();
|
|
|R|}
|
|
|
|
|
|
Running test: testWholeFunctionWithoutNested
|
|
|
|
function test() {
|
|
|_|Array.|C|from([1,2]).|C|map(() => |_|1|R|).|C|filter(() => |_|true|R|);
|
|
function nested1() {
|
|
|_|Array.|C|from([1,2]).|C|map(() => |_|1|R|).|C|filter(() => |_|true|R|);
|
|
|R|}
|
|
function nested2() {
|
|
|_|Array.|C|from([1,2]).|C|map(() => |_|1|R|).|C|filter(() => |_|true|R|);
|
|
|R|}
|
|
|C|nested1();
|
|
|C|nested2();
|
|
|R|}
|
|
|
|
|
|
Running test: testPartOfFunctionWithoutNested
|
|
|
|
function test() {
|
|
|_|Array.|C|from([1,2]).map(() => 1).filter(() => true);
|
|
function nested1() {
|
|
Array.from([1,2]).map(() => 1).filter(() => true);
|
|
}
|
|
function nested2() {
|
|
Array.from([1,2]).map(() => 1).filter(() => true);
|
|
}
|
|
nested1();
|
|
nested2();
|
|
}
|
|
|
|
|
|
Running test: testNestedFunction
|
|
|
|
function test() {
|
|
Array.from([1,2]).map(() => 1).filter(() => true);
|
|
function nested1() {
|
|
|_|Array.|C|from([1,2]).|C|map(() => |_|1|R|).|C|filter(() => |_|true|R|);
|
|
|R|}
|
|
function nested2() {
|
|
|_|Array.|C|from([1,2]).|C|map(() => |_|1|R|).|C|filter(() => |_|true|R|);
|
|
|R|}
|
|
|C|nested1();
|
|
|C|nested2();
|
|
|R|}
|
|
|
|
Run test() to check breakpoints..
|
|
}
|
|
#nested1();
|
|
nested2();
|
|
|
|
function nested1() {
|
|
#Array.from([1,2]).map(() => 1).filter(() => true);
|
|
}
|
|
|
|
function nested1() {
|
|
Array.#from([1,2]).map(() => 1).filter(() => true);
|
|
}
|
|
|
|
function nested1() {
|
|
Array.from([1,2]).#map(() => 1).filter(() => true);
|
|
}
|
|
|
|
function nested1() {
|
|
Array.from([1,2]).map(() => #1).filter(() => true);
|
|
}
|
|
|
|
function nested1() {
|
|
Array.from([1,2]).map(() => 1#).filter(() => true);
|
|
}
|
|
|
|
function nested1() {
|
|
Array.from([1,2]).map(() => #1).filter(() => true);
|
|
}
|
|
|
|
function nested1() {
|
|
Array.from([1,2]).map(() => 1#).filter(() => true);
|
|
}
|
|
|
|
function nested1() {
|
|
Array.from([1,2]).map(() => 1).#filter(() => true);
|
|
}
|
|
|
|
function nested1() {
|
|
Array.from([1,2]).map(() => 1).filter(() => #true);
|
|
}
|
|
|
|
function nested1() {
|
|
Array.from([1,2]).map(() => 1).filter(() => true#);
|
|
}
|
|
|
|
function nested1() {
|
|
Array.from([1,2]).map(() => 1).filter(() => #true);
|
|
}
|
|
|
|
function nested1() {
|
|
Array.from([1,2]).map(() => 1).filter(() => true#);
|
|
}
|
|
|
|
Array.from([1,2]).map(() => 1).filter(() => true);
|
|
#}
|
|
function nested2() {
|
|
|
|
nested1();
|
|
#nested2();
|
|
}
|
|
|
|
function nested2() {
|
|
#Array.from([1,2]).map(() => 1).filter(() => true);
|
|
}
|
|
|
|
function nested2() {
|
|
Array.#from([1,2]).map(() => 1).filter(() => true);
|
|
}
|
|
|
|
function nested2() {
|
|
Array.from([1,2]).#map(() => 1).filter(() => true);
|
|
}
|
|
|
|
function nested2() {
|
|
Array.from([1,2]).map(() => #1).filter(() => true);
|
|
}
|
|
|
|
function nested2() {
|
|
Array.from([1,2]).map(() => 1#).filter(() => true);
|
|
}
|
|
|
|
function nested2() {
|
|
Array.from([1,2]).map(() => #1).filter(() => true);
|
|
}
|
|
|
|
function nested2() {
|
|
Array.from([1,2]).map(() => 1#).filter(() => true);
|
|
}
|
|
|
|
function nested2() {
|
|
Array.from([1,2]).map(() => 1).#filter(() => true);
|
|
}
|
|
|
|
function nested2() {
|
|
Array.from([1,2]).map(() => 1).filter(() => #true);
|
|
}
|
|
|
|
function nested2() {
|
|
Array.from([1,2]).map(() => 1).filter(() => true#);
|
|
}
|
|
|
|
function nested2() {
|
|
Array.from([1,2]).map(() => 1).filter(() => #true);
|
|
}
|
|
|
|
function nested2() {
|
|
Array.from([1,2]).map(() => 1).filter(() => true#);
|
|
}
|
|
|
|
Array.from([1,2]).map(() => 1).filter(() => true);
|
|
#}
|
|
nested1();
|
|
|
|
nested2();
|
|
#}
|
|
|