a7c8a3ea9b
This changes the behavior of SetBreakpointForScript to find more accurate break positions. Previously, setting a breakpoint would only consider the shared function info that contained the requested position for setting a breakpoint. More intuitively, a breakpoint should not necessarily be set in a function that contains the position, but in the closest breakable location that comes after the position we requested. To achieve this we: 1. find the shared function info of the inner most function that contains the requested_position. This function's end position is used to find other shared function infos in step 2. 2. search for all shared function infos that intersect with the range [requested_position, inner_most_function.break_position[. 3. From the shared function infos extracted in 2, find the one that has the closest breakable location to requested_position. Also-By: bmeurer@chromium.org Fixed: chromium:1137141 Change-Id: I4f4c6c3aac1ebea50cbcad9543b539ab1ded2b05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2742198 Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#73392}
76 lines
2.2 KiB
JavaScript
76 lines
2.2 KiB
JavaScript
// Copyright 2021 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
let {session, contextGroup, Protocol} = InspectorTest.start(
|
|
'Checks if we can set a breakpoint on a one-line inline functions.');
|
|
|
|
session.setupScriptMap();
|
|
|
|
const testClassInitializer = `
|
|
function foo() {}
|
|
var bar = "bar";
|
|
|
|
class X {
|
|
constructor() {
|
|
this.x = 1;
|
|
}
|
|
[bar] = 2;
|
|
baz = foo();
|
|
}
|
|
new X();
|
|
//# sourceURL=testInitializer.js`
|
|
|
|
Protocol.Debugger.enable().then(onDebuggerEnabled);
|
|
|
|
function onDebuggerEnabled() {
|
|
Protocol.Runtime.enable();
|
|
Protocol.Runtime.onExecutionContextCreated(onExecutionContextCreated);
|
|
}
|
|
|
|
async function onExecutionContextCreated(messageObject) {
|
|
const executionContextId = messageObject.params.context.id;
|
|
await runTest(executionContextId, testClassInitializer, 'testInitializer.js');
|
|
InspectorTest.completeTest();
|
|
}
|
|
|
|
async function runTest(executionContextId, func, url) {
|
|
const obj = await Protocol.Runtime.compileScript({
|
|
expression: func,
|
|
sourceURL: url,
|
|
persistScript: true,
|
|
executionContextId: executionContextId
|
|
});
|
|
const scriptId = obj.result.scriptId;
|
|
|
|
InspectorTest.log('Setting breakpoint on `class X`');
|
|
await setBreakpoint(4, 'testInitializer.js');
|
|
|
|
InspectorTest.log(
|
|
'Setting breakpoint on constructor, should resolve to same location');
|
|
await setBreakpoint(5, 'testInitializer.js');
|
|
|
|
InspectorTest.log('Setting breakpoint on computed properties in class');
|
|
await setBreakpoint(8, 'testInitializer.js');
|
|
|
|
InspectorTest.log('Setting breakpoint on initializer function');
|
|
await setBreakpoint(9, 'testInitializer.js');
|
|
|
|
Protocol.Runtime.runScript({scriptId});
|
|
const numBreaks = 3;
|
|
for (var i = 0; i < numBreaks; ++i) {
|
|
const {params: {callFrames}} = await Protocol.Debugger.oncePaused();
|
|
InspectorTest.log('Paused on location:');
|
|
session.logCallFrames(callFrames);
|
|
Protocol.Debugger.resume();
|
|
}
|
|
|
|
InspectorTest.completeTest();
|
|
};
|
|
|
|
async function setBreakpoint(lineNumber, url) {
|
|
const {result: {locations}} =
|
|
await Protocol.Debugger.setBreakpointByUrl({lineNumber, url});
|
|
await session.logBreakLocations(locations);
|
|
}
|