v8/test/mjsunit/es8/async-function-try-finally.js
caitp 39642fa2be [async-await] (simpler) fix for Return in try/finally in async functions
Alternative approach to https://codereview.chromium.org/2667983004/, which
does not depend on implicit control flow changes from
https://codereview.chromium.org/2664083002

- Remove handling for `async function` from Parser::RewriteReturn(). This functionality
is moved to BytecodeGenerator::BuildAsyncReturn(). This ensures that promise resolution
is deferred until all finally blocks are evaluated fully.

- Add a new deferred command (CMD_ASYNC_RETURN), which instructs ControlScope to
generate return code using BuildAsyncReturn rather than BuildReturn.

- Parser has a new `NewReturnStatement()` helper which determines what type of return
statement to generate based on the type of function.

BUG=v8:5896, v8:4483
R=littledan@chromium.org, neis@chromium.org, rmcilroy@chromium.org, adamk@chromium.org, gsathya@chromium.org

Review-Url: https://codereview.chromium.org/2685683002
Cr-Commit-Position: refs/heads/master@{#43104}
2017-02-10 14:38:58 +00:00

202 lines
5.0 KiB
JavaScript

// Copyright 2017 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --allow-natives-syntax
function assertThrowsAsync(run, errorType, message) {
var actual;
var hadValue = false;
var hadError = false;
var promise = run();
if (typeof promise !== "object" || typeof promise.then !== "function") {
throw new MjsUnitAssertionError(
"Expected " + run.toString() +
" to return a Promise, but it returned " + PrettyPrint(promise));
}
promise.then(function(value) { hadValue = true; actual = value; },
function(error) { hadError = true; actual = error; });
assertFalse(hadValue || hadError);
%RunMicrotasks();
if (!hadError) {
throw new MjsUnitAssertionError(
"Expected " + run + "() to throw " + errorType.name +
", but did not throw.");
}
if (!(actual instanceof errorType))
throw new MjsUnitAssertionError(
"Expected " + run + "() to throw " + errorType.name +
", but threw '" + actual + "'");
if (message !== void 0 && actual.message !== message)
throw new MjsUnitAssertionError(
"Expected " + run + "() to throw '" + message + "', but threw '" +
actual.message + "'");
};
function assertEqualsAsync(expected, run, msg) {
var actual;
var hadValue = false;
var hadError = false;
var promise = run();
if (typeof promise !== "object" || typeof promise.then !== "function") {
throw new MjsUnitAssertionError(
"Expected " + run.toString() +
" to return a Promise, but it returned " + PrettyPrint(promise));
}
promise.then(function(value) { hadValue = true; actual = value; },
function(error) { hadError = true; actual = error; });
assertFalse(hadValue || hadError);
%RunMicrotasks();
if (hadError) throw actual;
assertTrue(
hadValue, "Expected '" + run.toString() + "' to produce a value");
assertEquals(expected, actual, msg);
};
function resolveLater(value) {
return new Promise(function(resolve) {
resolve(value);
});
}
function rejectLater(reason) {
return new Promise(function(resolve, reject) {
reject(reason);
});
}
class MyError extends Error {};
var AsyncFunction = async function() {}.constructor;
assertEqualsAsync("finally-return (func-expr)", async function() {
try {
return "early-return (func-expr)";
} finally {
return "finally-return (func-expr)";
}
});
assertEqualsAsync("finally-return (arrow)", async() => {
try {
return "early-return (arrow)";
} finally {
return "finally-return (arrow)";
}
});
assertEqualsAsync("finally-return (eval)", AsyncFunction(`
try {
return "early-return (eval)";
} finally {
return "finally-return (eval)";
}
`));
assertEqualsAsync("promise-finally-return (func-expr)", async function() {
try {
return new Promise(function() {});
} finally {
return "promise-finally-return (func-expr)";
}
});
assertEqualsAsync("promise-finally-return (arrow)", async() => {
try {
return new Promise(function() {});
} finally {
return "promise-finally-return (arrow)";
}
});
assertEqualsAsync("promise-finally-return (eval)", AsyncFunction(`
try {
return new Promise(function() {});
} finally {
return "promise-finally-return (eval)";
}
`));
assertEqualsAsync("await-finally-return (func-expr)", async function() {
try {
return "early-return (func-expr)";
} finally {
return await resolveLater("await-finally-return (func-expr)");
}
});
assertEqualsAsync("await-finally-return (arrow)", async() => {
try {
return "early-return (arrow)";
} finally {
return await resolveLater("await-finally-return (arrow)");
}
});
assertEqualsAsync("await-finally-return (eval)", AsyncFunction(`
try {
return "early-return (eval)";
} finally {
return await resolveLater("await-finally-return (eval)");
}
`));
assertThrowsAsync(async function() {
try {
return "early-return (func-expr)";
} finally {
throw new MyError("finally-throw (func-expr)");
}
}, MyError, "finally-throw (func-expr)");
assertThrowsAsync(async() => {
try {
return "early-return (arrow)";
} finally {
throw new MyError("finally-throw (arrow)");
}
}, MyError, "finally-throw (arrow)");
assertThrowsAsync(AsyncFunction(`
try {
return "early-return (eval)";
} finally {
throw new MyError("finally-throw (eval)");
}
`), MyError, "finally-throw (eval)");
assertThrowsAsync(async function() {
try {
return "early-return (func-expr)";
} finally {
await rejectLater(new MyError("await-finally-throw (func-expr)"));
}
}, MyError, "await-finally-throw (func-expr)");
assertThrowsAsync(async() => {
try {
return "early-return (arrow)";
} finally {
await rejectLater(new MyError("await-finally-throw (arrow)"));
}
}, MyError, "await-finally-throw (arrow)");
assertThrowsAsync(AsyncFunction(`
try {
return "early-return (eval)";
} finally {
await rejectLater(new MyError("await-finally-throw (eval)"));
}
`), MyError, "await-finally-throw (eval)");