dc2e3069e7
Reason for revert: Cannot reproduce gc-stress failures locally. Original issue's description: > Revert of Replace all remaining Oddball checks with new function (patchset #10 id:180001 of https://codereview.chromium.org/2043183003/ ) > > Reason for revert: > failing tests > > Original issue's description: > > Replace all remaining Oddball checks with new function > > > > This CL removes the IsUndefined() and Co. methods from Object and HeapObject. > > The new method all take the isolate as parameter. > > > > BUG= > > > > Committed: https://crrev.com/ccefb3ae5fe967288d568013fb04e8761eafebc5 > > Cr-Commit-Position: refs/heads/master@{#36921} > > TBR=mstarzinger@chromium.org,verwaest@chromium.org,yangguo@chromium.org,ahaas@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/33b8bc24a12fb062100c0be84456faeb0b9fa5d1 > Cr-Commit-Position: refs/heads/master@{#36923} TBR=mstarzinger@chromium.org,verwaest@chromium.org,yangguo@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/2059173002 Cr-Commit-Position: refs/heads/master@{#36957}
40 lines
1.4 KiB
C++
40 lines
1.4 KiB
C++
// Copyright 2015 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/v8.h"
|
|
|
|
#include "src/isolate.h"
|
|
#include "src/vm-state.h"
|
|
#include "test/cctest/cctest.h"
|
|
|
|
template <typename T>
|
|
static void CheckReturnValue(const T& t, i::Address callback) {
|
|
v8::ReturnValue<v8::Value> rv = t.GetReturnValue();
|
|
i::Object** o = *reinterpret_cast<i::Object***>(&rv);
|
|
CHECK_EQ(CcTest::isolate(), t.GetIsolate());
|
|
i::Isolate* isolate = reinterpret_cast<i::Isolate*>(t.GetIsolate());
|
|
CHECK_EQ(t.GetIsolate(), rv.GetIsolate());
|
|
CHECK((*o)->IsTheHole(isolate) || (*o)->IsUndefined(isolate));
|
|
// Verify reset
|
|
bool is_runtime = (*o)->IsTheHole(isolate);
|
|
if (is_runtime) {
|
|
CHECK(rv.Get()->IsUndefined());
|
|
} else {
|
|
i::Handle<i::Object> v = v8::Utils::OpenHandle(*rv.Get());
|
|
CHECK_EQ(*v, *o);
|
|
}
|
|
rv.Set(true);
|
|
CHECK(!(*o)->IsTheHole(isolate) && !(*o)->IsUndefined(isolate));
|
|
rv.Set(v8::Local<v8::Object>());
|
|
CHECK((*o)->IsTheHole(isolate) || (*o)->IsUndefined(isolate));
|
|
CHECK_EQ(is_runtime, (*o)->IsTheHole(isolate));
|
|
// If CPU profiler is active check that when API callback is invoked
|
|
// VMState is set to EXTERNAL.
|
|
if (isolate->is_profiling()) {
|
|
CHECK_EQ(v8::EXTERNAL, isolate->current_vm_state());
|
|
CHECK(isolate->external_callback_scope());
|
|
CHECK_EQ(callback, isolate->external_callback_scope()->callback());
|
|
}
|
|
}
|