1d3c4975be
If we can read an object's Map pointer but not any data from the Map itself, we may still be able to accurately describe the object's type if the Map pointer matches one of the known Maps from the snapshot. GetObjectProperties uses that data in one of two ways: - If it is sure that the Map pointer matches a known Map, then it uses the type from that Map and continues as if it read the type normally. - If the Map pointer is at the right offset within a heap page to match a known Map, but the caller didn't provide the addresses of the first pages in Map space or read-only space, then the type of that Map is just a guess and gets returned in a separate array. This gives the caller the opportunity to present guessed types to the user, and perhaps call again using the guessed type as the type hint. Bug: v8:9376 Change-Id: I187f67b77e76699863a14534a9d635b79f654124 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1787986 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#63908}
108 lines
2.4 KiB
Plaintext
108 lines
2.4 KiB
Plaintext
# Copyright 2019 the V8 project authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
|
|
import("../../gni/snapshot_toolchain.gni")
|
|
import("../../gni/v8.gni")
|
|
|
|
config("internal_config") {
|
|
visibility = [ ":*" ] # Only targets in this file can depend on this.
|
|
|
|
if (is_component_build) {
|
|
defines = [ "BUILDING_V8_DEBUG_HELPER" ]
|
|
}
|
|
|
|
include_dirs = [
|
|
".",
|
|
"../..",
|
|
"$target_gen_dir",
|
|
"$target_gen_dir/../..",
|
|
]
|
|
}
|
|
|
|
# This config should be applied to code using v8_debug_helper.
|
|
config("external_config") {
|
|
if (is_component_build) {
|
|
defines = [ "USING_V8_DEBUG_HELPER" ]
|
|
}
|
|
include_dirs = [ "." ]
|
|
}
|
|
|
|
action("run_mkgrokdump") {
|
|
testonly = true
|
|
visibility = [ ":*" ]
|
|
|
|
deps = [
|
|
"../../test/mkgrokdump:mkgrokdump($v8_generator_toolchain)",
|
|
]
|
|
|
|
script = "../run.py"
|
|
|
|
outputs = [
|
|
"$target_gen_dir/v8heapconst.py",
|
|
]
|
|
|
|
args = [
|
|
"./" + rebase_path(
|
|
get_label_info(
|
|
"../../test/mkgrokdump:mkgrokdump($v8_generator_toolchain)",
|
|
"root_out_dir") + "/mkgrokdump",
|
|
root_build_dir),
|
|
"--outfile",
|
|
rebase_path("$target_gen_dir/v8heapconst.py", root_build_dir),
|
|
]
|
|
}
|
|
|
|
action("gen_heap_constants") {
|
|
testonly = true
|
|
visibility = [ ":*" ]
|
|
deps = [
|
|
":run_mkgrokdump",
|
|
]
|
|
script = "gen-heap-constants.py"
|
|
outputs = [
|
|
"$target_gen_dir/heap-constants-gen.cc",
|
|
]
|
|
args = [
|
|
rebase_path(target_gen_dir, root_build_dir),
|
|
rebase_path("$target_gen_dir/heap-constants-gen.cc", root_build_dir),
|
|
]
|
|
}
|
|
|
|
v8_component("v8_debug_helper") {
|
|
testonly = true
|
|
|
|
public = [
|
|
"debug-helper.h",
|
|
]
|
|
|
|
sources = [
|
|
"$target_gen_dir/../../torque-generated/class-debug-readers-tq.cc",
|
|
"$target_gen_dir/../../torque-generated/class-debug-readers-tq.h",
|
|
"$target_gen_dir/heap-constants-gen.cc",
|
|
"debug-helper-internal.cc",
|
|
"debug-helper-internal.h",
|
|
"debug-helper.h",
|
|
"get-object-properties.cc",
|
|
"heap-constants.cc",
|
|
"heap-constants.h",
|
|
]
|
|
|
|
deps = [
|
|
":gen_heap_constants",
|
|
"../..:run_torque",
|
|
"../..:v8_headers",
|
|
"../..:v8_libbase",
|
|
]
|
|
|
|
configs = [ ":internal_config" ]
|
|
if (v8_enable_i18n_support) {
|
|
configs += [ "//third_party/icu:icu_config" ]
|
|
}
|
|
|
|
remove_configs = [ "//build/config/compiler:no_rtti" ]
|
|
configs += [ "//build/config/compiler:rtti" ]
|
|
|
|
public_configs = [ ":external_config" ]
|
|
}
|