fd5cc8837a
In BinaryOpAssembler::Generate_BinaryOperationWithFeedback, the feedback is stored only after the respective builtin/runtime call. If this call throws an exception, the feedback is lost, leading to a deopt loop in some cases. This CL fixes that issue by writing the gathered feedback before passing control to the builtin. Bug: chromium:1077197, v8:9441 Change-Id: I20e4b14815520224e2c6f8af1af6a89f754ccddf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2202904 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Mythri Alle <mythria@chromium.org> Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#68038}
24 lines
675 B
JavaScript
24 lines
675 B
JavaScript
// Copyright 2020 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax --opt --no-always-opt
|
|
|
|
function foo(a, b) {
|
|
return a - b;
|
|
}
|
|
|
|
%PrepareFunctionForOptimization(foo);
|
|
assertEquals(-1n, foo(1n, 2n));
|
|
%OptimizeFunctionOnNextCall(foo);
|
|
assertEquals(1n, foo(2n, 1n));
|
|
assertOptimized(foo);
|
|
assertThrows(() => foo(2n, undefined));
|
|
assertUnoptimized(foo);
|
|
%PrepareFunctionForOptimization(foo);
|
|
%OptimizeFunctionOnNextCall(foo);
|
|
assertEquals(-1n, foo(1n, 2n));
|
|
assertOptimized(foo);
|
|
assertThrows(() => foo(undefined, 2n));
|
|
assertOptimized(foo);
|