f47e59e045
Because of LocalHeap safepoints, our existing assert scopes don't necessarily maintain the same guarantees as desired. In particular, DisallowHeapAllocation no longer guarantees that objects don't move. This patch transitions DisallowHeapAllocation to DisallowGarbageCollection, to ensure that code using this scope is also protected against safepoints. Change-Id: I0411425884f6849982611205fb17bb072881c722 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2540547 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#71319}
48 lines
1.8 KiB
Plaintext
48 lines
1.8 KiB
Plaintext
|
|
tools/gcmole/gcmole-test.cc:30:10: warning: Possibly dead variable.
|
|
return obj;
|
|
^
|
|
tools/gcmole/gcmole-test.cc:48:3: warning: Possible problem with evaluation order.
|
|
TwoArgumentsFunction(*CauseGC(obj1, isolate), *CauseGC(obj2, isolate));
|
|
^
|
|
tools/gcmole/gcmole-test.cc:60:3: warning: Possible problem with evaluation order.
|
|
TwoSizeTArgumentsFunction(sizeof(*CauseGC(obj1, isolate)),
|
|
^
|
|
tools/gcmole/gcmole-test.cc:85:7: warning: Possible problem with evaluation order.
|
|
so->Method(*CauseGC(obj1, isolate));
|
|
^
|
|
tools/gcmole/gcmole-test.cc:87:7: warning: Possible problem with evaluation order.
|
|
so->Method(CauseGCRaw(*obj1, isolate));
|
|
^
|
|
tools/gcmole/gcmole-test.cc:131:14: warning: Possible problem with evaluation order.
|
|
so_handle->Method(*derived.VirtualCauseGC(obj1, isolate));
|
|
^
|
|
tools/gcmole/gcmole-test.cc:133:14: warning: Possible problem with evaluation order.
|
|
so_handle->Method(*base->VirtualCauseGC(obj1, isolate));
|
|
^
|
|
tools/gcmole/gcmole-test.cc:154:14: warning: Possible problem with evaluation order.
|
|
so_handle->Method(*SomeClass::StaticCauseGC(obj1, isolate));
|
|
^
|
|
tools/gcmole/gcmole-test.cc:164:3: warning: Possibly dead variable.
|
|
raw_obj.Print();
|
|
^
|
|
tools/gcmole/gcmole-test.cc:172:3: warning: Possibly dead variable.
|
|
raw_obj.Print();
|
|
^
|
|
tools/gcmole/gcmole-test.cc:210:3: warning: Possibly dead variable.
|
|
raw_obj.Print();
|
|
^
|
|
tools/gcmole/gcmole-test.cc:217:3: warning: Possibly dead variable.
|
|
raw_obj.Print();
|
|
^
|
|
tools/gcmole/gcmole-test.cc:227:3: warning: Possibly dead variable.
|
|
raw_obj.Print();
|
|
^
|
|
tools/gcmole/gcmole-test.cc:240:3: warning: Possibly dead variable.
|
|
raw_obj.Print();
|
|
^
|
|
tools/gcmole/gcmole-test.cc:253:3: warning: Possibly dead variable.
|
|
raw_obj.Print();
|
|
^
|
|
15 warnings generated.
|