7be64db45f
This is a reland of cf93071c91
Original change's description:
> [interpreter] Short Star bytecode
>
> Design doc:
> https://docs.google.com/document/d/1g_NExMT78II_KnIYNa9MvyPYIj23qAiFUEsyemY5KRk/edit
>
> This change adds 16 new interpreter opcodes, kStar0 through kStar15, so
> that we can use a single byte to represent the common operation of
> storing to a low-numbered register. This generally reduces the quantity
> of bytecode generated on web sites by 8-9%.
>
> In order to not degrade speed, a couple of other changes are required:
>
> The existing lookahead logic to check for Star after certain other
> bytecode handlers is updated to check for these new short Star codes
> instead. Furthermore, that lookahead logic is updated to contain its own
> copy of the dispatch jump rather than merging control flow with the
> lookahead-failed case, to improve branch prediction.
>
> A bunch of constants use bytecode size in bytes as a proxy for the size
> or complexity of a function, and are adjusted downward proportionally to
> the decrease in generated bytecode size.
>
> Other small drive-by fix: update generate-bytecode-expectations to emit
> \n instead of \r\n on Windows.
>
> Change-Id: I6307c2b0f5794a3a1088bb0fb94f6e1615441ed5
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2641180
> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#72773}
Change-Id: I1afb670c25694498b3989de615858f984a8c7f6f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2698057
Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72821}
161 lines
3.7 KiB
Plaintext
161 lines
3.7 KiB
Plaintext
#
|
|
# Autogenerated by generate-bytecode-expectations.
|
|
#
|
|
|
|
---
|
|
wrap: no
|
|
test function name: test
|
|
|
|
---
|
|
snippet: "
|
|
var test;
|
|
(function() {
|
|
class A {
|
|
method() { return 2; }
|
|
}
|
|
class B extends A {
|
|
method() { return super.method() + 1; }
|
|
}
|
|
test = new B().method;
|
|
test();
|
|
})();
|
|
"
|
|
frame size: 1
|
|
parameter count: 1
|
|
bytecode array length: 16
|
|
bytecodes: [
|
|
/* 104 S> */ B(LdaImmutableCurrentContextSlot), U8(2),
|
|
/* 117 E> */ B(LdaNamedPropertyFromSuper), R(this), U8(0), U8(1),
|
|
B(Star0),
|
|
/* 117 E> */ B(CallAnyReceiver), R(0), R(this), U8(1), U8(3),
|
|
/* 126 E> */ B(AddSmi), I8(1), U8(0),
|
|
/* 130 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["method"],
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
var test;
|
|
(function() {
|
|
class A {
|
|
get x() { return 1; }
|
|
set x(val) { return; }
|
|
}
|
|
class B extends A {
|
|
method() { super.x = 2; return super.x; }
|
|
}
|
|
test = new B().method;
|
|
test();
|
|
})();
|
|
"
|
|
frame size: 4
|
|
parameter count: 1
|
|
bytecode array length: 24
|
|
bytecodes: [
|
|
/* 130 S> */ B(LdaImmutableCurrentContextSlot), U8(2),
|
|
B(Star1),
|
|
B(LdaConstant), U8(0),
|
|
B(Star2),
|
|
B(LdaSmi), I8(2),
|
|
B(Star3),
|
|
B(Mov), R(this), R(0),
|
|
/* 138 E> */ B(CallRuntime), U16(Runtime::kStoreToSuper), R(0), U8(4),
|
|
/* 143 S> */ B(LdaImmutableCurrentContextSlot), U8(2),
|
|
/* 156 E> */ B(LdaNamedPropertyFromSuper), R(this), U8(0), U8(0),
|
|
/* 158 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["x"],
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
var test;
|
|
(function() {
|
|
class A {
|
|
constructor(x) { this.x_ = x; }
|
|
}
|
|
class B extends A {
|
|
constructor() { super(1); this.y_ = 2; }
|
|
}
|
|
test = new B().constructor;
|
|
})();
|
|
"
|
|
frame size: 6
|
|
parameter count: 1
|
|
bytecode array length: 39
|
|
bytecodes: [
|
|
B(Mov), R(closure), R(1),
|
|
/* 118 S> */ B(Ldar), R(1),
|
|
B(GetSuperConstructor), R(3),
|
|
B(LdaSmi), I8(1),
|
|
B(ThrowIfNotSuperConstructor), R(3),
|
|
B(Star4),
|
|
B(Ldar), R(0),
|
|
/* 118 E> */ B(Construct), R(3), R(4), U8(1), U8(0),
|
|
B(Star5),
|
|
B(Ldar), R(this),
|
|
B(ThrowSuperAlreadyCalledIfNotHole),
|
|
B(Mov), R(5), R(this),
|
|
/* 128 S> */ B(Ldar), R(this),
|
|
B(ThrowSuperNotCalledIfHole),
|
|
B(LdaSmi), I8(2),
|
|
/* 136 E> */ B(StaNamedProperty), R(this), U8(0), U8(2),
|
|
B(Ldar), R(this),
|
|
B(ThrowSuperNotCalledIfHole),
|
|
/* 141 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["y_"],
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
var test;
|
|
(function() {
|
|
class A {
|
|
constructor() { this.x_ = 1; }
|
|
}
|
|
class B extends A {
|
|
constructor() { super(); this.y_ = 2; }
|
|
}
|
|
test = new B().constructor;
|
|
})();
|
|
"
|
|
frame size: 5
|
|
parameter count: 1
|
|
bytecode array length: 36
|
|
bytecodes: [
|
|
B(Mov), R(closure), R(1),
|
|
/* 117 S> */ B(Ldar), R(1),
|
|
B(GetSuperConstructor), R(3),
|
|
B(ThrowIfNotSuperConstructor), R(3),
|
|
B(Ldar), R(0),
|
|
/* 117 E> */ B(Construct), R(3), R(0), U8(0), U8(0),
|
|
B(Star4),
|
|
B(Ldar), R(this),
|
|
B(ThrowSuperAlreadyCalledIfNotHole),
|
|
B(Mov), R(4), R(this),
|
|
/* 126 S> */ B(Ldar), R(this),
|
|
B(ThrowSuperNotCalledIfHole),
|
|
B(LdaSmi), I8(2),
|
|
/* 134 E> */ B(StaNamedProperty), R(this), U8(0), U8(2),
|
|
B(Ldar), R(this),
|
|
B(ThrowSuperNotCalledIfHole),
|
|
/* 139 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["y_"],
|
|
]
|
|
handlers: [
|
|
]
|
|
|