7be64db45f
This is a reland of cf93071c91
Original change's description:
> [interpreter] Short Star bytecode
>
> Design doc:
> https://docs.google.com/document/d/1g_NExMT78II_KnIYNa9MvyPYIj23qAiFUEsyemY5KRk/edit
>
> This change adds 16 new interpreter opcodes, kStar0 through kStar15, so
> that we can use a single byte to represent the common operation of
> storing to a low-numbered register. This generally reduces the quantity
> of bytecode generated on web sites by 8-9%.
>
> In order to not degrade speed, a couple of other changes are required:
>
> The existing lookahead logic to check for Star after certain other
> bytecode handlers is updated to check for these new short Star codes
> instead. Furthermore, that lookahead logic is updated to contain its own
> copy of the dispatch jump rather than merging control flow with the
> lookahead-failed case, to improve branch prediction.
>
> A bunch of constants use bytecode size in bytes as a proxy for the size
> or complexity of a function, and are adjusted downward proportionally to
> the decrease in generated bytecode size.
>
> Other small drive-by fix: update generate-bytecode-expectations to emit
> \n instead of \r\n on Windows.
>
> Change-Id: I6307c2b0f5794a3a1088bb0fb94f6e1615441ed5
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2641180
> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#72773}
Change-Id: I1afb670c25694498b3989de615858f984a8c7f6f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2698057
Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72821}
105 lines
2.2 KiB
Plaintext
105 lines
2.2 KiB
Plaintext
#
|
|
# Autogenerated by generate-bytecode-expectations.
|
|
#
|
|
|
|
---
|
|
wrap: no
|
|
test function name: f
|
|
|
|
---
|
|
snippet: "
|
|
function f(arg1) { return function() { arg1 = 2; }; }
|
|
f();
|
|
"
|
|
frame size: 1
|
|
parameter count: 2
|
|
bytecode array length: 14
|
|
bytecodes: [
|
|
/* 10 E> */ B(CreateFunctionContext), U8(0), U8(1),
|
|
B(PushContext), R(0),
|
|
B(Ldar), R(arg0),
|
|
B(StaCurrentContextSlot), U8(2),
|
|
/* 19 S> */ B(CreateClosure), U8(1), U8(0), U8(2),
|
|
/* 51 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SCOPE_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
function f(arg1) { var a = function() { arg1 = 2; }; return arg1; }
|
|
f();
|
|
"
|
|
frame size: 2
|
|
parameter count: 2
|
|
bytecode array length: 17
|
|
bytecodes: [
|
|
/* 10 E> */ B(CreateFunctionContext), U8(0), U8(1),
|
|
B(PushContext), R(1),
|
|
B(Ldar), R(arg0),
|
|
B(StaCurrentContextSlot), U8(2),
|
|
/* 27 S> */ B(CreateClosure), U8(1), U8(0), U8(2),
|
|
B(Star0),
|
|
/* 53 S> */ B(LdaCurrentContextSlot), U8(2),
|
|
/* 65 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SCOPE_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
function f(a1, a2, a3, a4) { return function() { a1 = a3; }; }
|
|
f();
|
|
"
|
|
frame size: 1
|
|
parameter count: 5
|
|
bytecode array length: 18
|
|
bytecodes: [
|
|
/* 10 E> */ B(CreateFunctionContext), U8(0), U8(2),
|
|
B(PushContext), R(0),
|
|
B(Ldar), R(arg0),
|
|
B(StaCurrentContextSlot), U8(3),
|
|
B(Ldar), R(arg2),
|
|
B(StaCurrentContextSlot), U8(2),
|
|
/* 29 S> */ B(CreateClosure), U8(1), U8(0), U8(2),
|
|
/* 60 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SCOPE_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
function f() { var self = this; return function() { self = 2; }; }
|
|
f();
|
|
"
|
|
frame size: 1
|
|
parameter count: 1
|
|
bytecode array length: 14
|
|
bytecodes: [
|
|
/* 10 E> */ B(CreateFunctionContext), U8(0), U8(1),
|
|
B(PushContext), R(0),
|
|
/* 26 S> */ B(Ldar), R(this),
|
|
/* 26 E> */ B(StaCurrentContextSlot), U8(2),
|
|
/* 32 S> */ B(CreateClosure), U8(1), U8(0), U8(2),
|
|
/* 64 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SCOPE_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|