7be64db45f
This is a reland of cf93071c91
Original change's description:
> [interpreter] Short Star bytecode
>
> Design doc:
> https://docs.google.com/document/d/1g_NExMT78II_KnIYNa9MvyPYIj23qAiFUEsyemY5KRk/edit
>
> This change adds 16 new interpreter opcodes, kStar0 through kStar15, so
> that we can use a single byte to represent the common operation of
> storing to a low-numbered register. This generally reduces the quantity
> of bytecode generated on web sites by 8-9%.
>
> In order to not degrade speed, a couple of other changes are required:
>
> The existing lookahead logic to check for Star after certain other
> bytecode handlers is updated to check for these new short Star codes
> instead. Furthermore, that lookahead logic is updated to contain its own
> copy of the dispatch jump rather than merging control flow with the
> lookahead-failed case, to improve branch prediction.
>
> A bunch of constants use bytecode size in bytes as a proxy for the size
> or complexity of a function, and are adjusted downward proportionally to
> the decrease in generated bytecode size.
>
> Other small drive-by fix: update generate-bytecode-expectations to emit
> \n instead of \r\n on Windows.
>
> Change-Id: I6307c2b0f5794a3a1088bb0fb94f6e1615441ed5
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2641180
> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#72773}
Change-Id: I1afb670c25694498b3989de615858f984a8c7f6f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2698057
Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72821}
192 lines
4.9 KiB
Plaintext
192 lines
4.9 KiB
Plaintext
#
|
|
# Autogenerated by generate-bytecode-expectations.
|
|
#
|
|
|
|
---
|
|
wrap: no
|
|
test function name: test
|
|
|
|
---
|
|
snippet: "
|
|
class A {
|
|
get #a() { return 1; }
|
|
set #a(val) { }
|
|
|
|
constructor() {
|
|
this.#a++;
|
|
this.#a = 1;
|
|
return this.#a;
|
|
}
|
|
}
|
|
var test = A;
|
|
new test;
|
|
"
|
|
frame size: 7
|
|
parameter count: 1
|
|
bytecode array length: 87
|
|
bytecodes: [
|
|
B(LdaImmutableCurrentContextSlot), U8(3),
|
|
B(Star1),
|
|
B(Mov), R(this), R(0),
|
|
B(Mov), R(context), R(2),
|
|
/* 67 E> */ B(CallRuntime), U16(Runtime::kAddPrivateBrand), R(0), U8(3),
|
|
/* 76 S> */ B(LdaImmutableCurrentContextSlot), U8(2),
|
|
B(Star4),
|
|
B(LdaImmutableCurrentContextSlot), U8(3),
|
|
/* 81 E> */ B(LdaKeyedProperty), R(this), U8(0),
|
|
B(CallRuntime), U16(Runtime::kLoadPrivateGetter), R(4), U8(1),
|
|
B(Star5),
|
|
B(CallProperty0), R(5), R(this), U8(2),
|
|
B(Inc), U8(4),
|
|
B(Star5),
|
|
/* 83 E> */ B(CallRuntime), U16(Runtime::kLoadPrivateSetter), R(4), U8(1),
|
|
B(Star6),
|
|
B(CallProperty1), R(6), R(this), R(5), U8(5),
|
|
/* 91 S> */ B(LdaSmi), I8(1),
|
|
B(Star3),
|
|
B(LdaImmutableCurrentContextSlot), U8(2),
|
|
B(Star5),
|
|
B(LdaImmutableCurrentContextSlot), U8(3),
|
|
/* 96 E> */ B(LdaKeyedProperty), R(this), U8(7),
|
|
B(CallRuntime), U16(Runtime::kLoadPrivateSetter), R(5), U8(1),
|
|
B(Star6),
|
|
B(CallProperty1), R(6), R(this), R(3), U8(9),
|
|
/* 108 S> */ B(LdaImmutableCurrentContextSlot), U8(2),
|
|
B(Star4),
|
|
B(LdaImmutableCurrentContextSlot), U8(3),
|
|
/* 120 E> */ B(LdaKeyedProperty), R(this), U8(11),
|
|
B(CallRuntime), U16(Runtime::kLoadPrivateGetter), R(4), U8(1),
|
|
B(Star5),
|
|
B(CallProperty0), R(5), R(this), U8(13),
|
|
/* 123 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
class B {
|
|
get #b() { return 1; }
|
|
constructor() { this.#b++; }
|
|
}
|
|
var test = B;
|
|
new test;
|
|
"
|
|
frame size: 5
|
|
parameter count: 1
|
|
bytecode array length: 28
|
|
bytecodes: [
|
|
B(LdaImmutableCurrentContextSlot), U8(3),
|
|
B(Star1),
|
|
B(Mov), R(this), R(0),
|
|
B(Mov), R(context), R(2),
|
|
/* 48 E> */ B(CallRuntime), U16(Runtime::kAddPrivateBrand), R(0), U8(3),
|
|
/* 53 S> */ B(Wide), B(LdaSmi), I16(276),
|
|
B(Star3),
|
|
B(LdaConstant), U8(0),
|
|
B(Star4),
|
|
B(CallRuntime), U16(Runtime::kNewTypeError), R(3), U8(2),
|
|
B(Throw),
|
|
]
|
|
constant pool: [
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["#b"],
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
class C {
|
|
set #c(val) { }
|
|
constructor() { this.#c++; }
|
|
}
|
|
var test = C;
|
|
new test;
|
|
"
|
|
frame size: 5
|
|
parameter count: 1
|
|
bytecode array length: 28
|
|
bytecodes: [
|
|
B(LdaImmutableCurrentContextSlot), U8(3),
|
|
B(Star1),
|
|
B(Mov), R(this), R(0),
|
|
B(Mov), R(context), R(2),
|
|
/* 41 E> */ B(CallRuntime), U16(Runtime::kAddPrivateBrand), R(0), U8(3),
|
|
/* 46 S> */ B(Wide), B(LdaSmi), I16(275),
|
|
B(Star3),
|
|
B(LdaConstant), U8(0),
|
|
B(Star4),
|
|
B(CallRuntime), U16(Runtime::kNewTypeError), R(3), U8(2),
|
|
B(Throw),
|
|
]
|
|
constant pool: [
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["#c"],
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
class D {
|
|
get #d() { return 1; }
|
|
constructor() { this.#d = 1; }
|
|
}
|
|
var test = D;
|
|
new test;
|
|
"
|
|
frame size: 5
|
|
parameter count: 1
|
|
bytecode array length: 28
|
|
bytecodes: [
|
|
B(LdaImmutableCurrentContextSlot), U8(3),
|
|
B(Star1),
|
|
B(Mov), R(this), R(0),
|
|
B(Mov), R(context), R(2),
|
|
/* 48 E> */ B(CallRuntime), U16(Runtime::kAddPrivateBrand), R(0), U8(3),
|
|
/* 53 S> */ B(Wide), B(LdaSmi), I16(276),
|
|
B(Star3),
|
|
B(LdaConstant), U8(0),
|
|
B(Star4),
|
|
/* 61 E> */ B(CallRuntime), U16(Runtime::kNewTypeError), R(3), U8(2),
|
|
B(Throw),
|
|
]
|
|
constant pool: [
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["#d"],
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
class E {
|
|
set #e(val) { }
|
|
constructor() { this.#e; }
|
|
}
|
|
var test = E;
|
|
new test;
|
|
"
|
|
frame size: 6
|
|
parameter count: 1
|
|
bytecode array length: 28
|
|
bytecodes: [
|
|
B(LdaImmutableCurrentContextSlot), U8(3),
|
|
B(Star1),
|
|
B(Mov), R(this), R(0),
|
|
B(Mov), R(context), R(2),
|
|
/* 41 E> */ B(CallRuntime), U16(Runtime::kAddPrivateBrand), R(0), U8(3),
|
|
/* 46 S> */ B(Wide), B(LdaSmi), I16(275),
|
|
B(Star4),
|
|
B(LdaConstant), U8(0),
|
|
B(Star5),
|
|
B(CallRuntime), U16(Runtime::kNewTypeError), R(4), U8(2),
|
|
B(Throw),
|
|
]
|
|
constant pool: [
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["#e"],
|
|
]
|
|
handlers: [
|
|
]
|
|
|