7be64db45f
This is a reland of cf93071c91
Original change's description:
> [interpreter] Short Star bytecode
>
> Design doc:
> https://docs.google.com/document/d/1g_NExMT78II_KnIYNa9MvyPYIj23qAiFUEsyemY5KRk/edit
>
> This change adds 16 new interpreter opcodes, kStar0 through kStar15, so
> that we can use a single byte to represent the common operation of
> storing to a low-numbered register. This generally reduces the quantity
> of bytecode generated on web sites by 8-9%.
>
> In order to not degrade speed, a couple of other changes are required:
>
> The existing lookahead logic to check for Star after certain other
> bytecode handlers is updated to check for these new short Star codes
> instead. Furthermore, that lookahead logic is updated to contain its own
> copy of the dispatch jump rather than merging control flow with the
> lookahead-failed case, to improve branch prediction.
>
> A bunch of constants use bytecode size in bytes as a proxy for the size
> or complexity of a function, and are adjusted downward proportionally to
> the decrease in generated bytecode size.
>
> Other small drive-by fix: update generate-bytecode-expectations to emit
> \n instead of \r\n on Windows.
>
> Change-Id: I6307c2b0f5794a3a1088bb0fb94f6e1615441ed5
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2641180
> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#72773}
Change-Id: I1afb670c25694498b3989de615858f984a8c7f6f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2698057
Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72821}
260 lines
7.7 KiB
Plaintext
260 lines
7.7 KiB
Plaintext
#
|
|
# Autogenerated by generate-bytecode-expectations.
|
|
#
|
|
|
|
---
|
|
wrap: yes
|
|
|
|
---
|
|
snippet: "
|
|
{
|
|
class A {
|
|
#a;
|
|
constructor() {
|
|
this.#a = 1;
|
|
}
|
|
}
|
|
|
|
class B {
|
|
#a = 1;
|
|
}
|
|
new A;
|
|
new B;
|
|
}
|
|
"
|
|
frame size: 7
|
|
parameter count: 1
|
|
bytecode array length: 116
|
|
bytecodes: [
|
|
/* 30 E> */ B(CreateBlockContext), U8(0),
|
|
B(PushContext), R(2),
|
|
B(LdaConstant), U8(2),
|
|
B(Star4),
|
|
B(LdaConstant), U8(2),
|
|
B(Star4),
|
|
B(CallRuntime), U16(Runtime::kCreatePrivateNameSymbol), R(4), U8(1),
|
|
B(StaCurrentContextSlot), U8(2),
|
|
B(LdaTheHole),
|
|
B(Star6),
|
|
B(CreateClosure), U8(3), U8(0), U8(2),
|
|
B(Star3),
|
|
B(LdaConstant), U8(1),
|
|
B(Star4),
|
|
B(Mov), R(3), R(5),
|
|
B(CallRuntime), U16(Runtime::kDefineClass), R(4), U8(3),
|
|
B(Star4),
|
|
B(CreateClosure), U8(4), U8(1), U8(2),
|
|
B(Star5),
|
|
B(StaNamedProperty), R(3), U8(5), U8(0),
|
|
B(PopContext), R(2),
|
|
B(Mov), R(3), R(0),
|
|
/* 38 E> */ B(CreateBlockContext), U8(6),
|
|
B(PushContext), R(2),
|
|
B(LdaConstant), U8(2),
|
|
B(Star4),
|
|
B(LdaConstant), U8(2),
|
|
B(Star4),
|
|
B(CallRuntime), U16(Runtime::kCreatePrivateNameSymbol), R(4), U8(1),
|
|
B(StaCurrentContextSlot), U8(2),
|
|
B(LdaTheHole),
|
|
B(Star6),
|
|
B(CreateClosure), U8(8), U8(2), U8(2),
|
|
B(Star3),
|
|
B(LdaConstant), U8(7),
|
|
B(Star4),
|
|
B(Mov), R(3), R(5),
|
|
B(CallRuntime), U16(Runtime::kDefineClass), R(4), U8(3),
|
|
B(Star4),
|
|
B(CreateClosure), U8(9), U8(3), U8(2),
|
|
B(Star5),
|
|
B(StaNamedProperty), R(3), U8(5), U8(2),
|
|
B(PopContext), R(2),
|
|
B(Mov), R(3), R(1),
|
|
/* 136 S> */ B(Ldar), R(0),
|
|
/* 136 E> */ B(Construct), R(0), R(0), U8(0), U8(4),
|
|
/* 145 S> */ B(Ldar), R(1),
|
|
/* 145 E> */ B(Construct), R(1), R(0), U8(0), U8(6),
|
|
B(LdaUndefined),
|
|
/* 154 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SCOPE_INFO_TYPE,
|
|
FIXED_ARRAY_TYPE,
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["#a"],
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SYMBOL_TYPE,
|
|
SCOPE_INFO_TYPE,
|
|
FIXED_ARRAY_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
{
|
|
class A extends class {} {
|
|
#a;
|
|
constructor() {
|
|
super();
|
|
this.#a = 1;
|
|
}
|
|
}
|
|
|
|
class B extends class {} {
|
|
#a = 1;
|
|
#b = this.#a;
|
|
foo() { return this.#a; }
|
|
bar(v) { this.#b = v; }
|
|
constructor() {
|
|
super();
|
|
this.foo();
|
|
this.bar(3);
|
|
}
|
|
}
|
|
|
|
class C extends B {
|
|
#a = 2;
|
|
constructor() {
|
|
(() => super())();
|
|
}
|
|
}
|
|
|
|
new A;
|
|
new B;
|
|
new C;
|
|
};
|
|
"
|
|
frame size: 12
|
|
parameter count: 1
|
|
bytecode array length: 237
|
|
bytecodes: [
|
|
/* 30 E> */ B(CreateBlockContext), U8(0),
|
|
B(PushContext), R(3),
|
|
B(LdaConstant), U8(2),
|
|
B(Star5),
|
|
B(LdaConstant), U8(2),
|
|
B(Star5),
|
|
B(CallRuntime), U16(Runtime::kCreatePrivateNameSymbol), R(5), U8(1),
|
|
B(StaCurrentContextSlot), U8(2),
|
|
B(LdaTheHole),
|
|
B(Star11),
|
|
B(CreateClosure), U8(4), U8(0), U8(2),
|
|
B(Star8),
|
|
B(LdaConstant), U8(3),
|
|
B(Star9),
|
|
B(Mov), R(8), R(10),
|
|
B(CallRuntime), U16(Runtime::kDefineClass), R(9), U8(3),
|
|
B(Star9),
|
|
B(CreateClosure), U8(5), U8(1), U8(2),
|
|
B(Star4),
|
|
B(LdaConstant), U8(1),
|
|
B(Star5),
|
|
B(Mov), R(4), R(6),
|
|
B(Mov), R(10), R(7),
|
|
B(CallRuntime), U16(Runtime::kDefineClass), R(5), U8(3),
|
|
B(Star5),
|
|
B(CreateClosure), U8(6), U8(2), U8(2),
|
|
B(Star6),
|
|
B(StaNamedProperty), R(4), U8(7), U8(0),
|
|
B(PopContext), R(3),
|
|
B(Mov), R(4), R(0),
|
|
/* 38 E> */ B(CreateBlockContext), U8(8),
|
|
B(PushContext), R(3),
|
|
B(LdaConstant), U8(2),
|
|
B(Star5),
|
|
B(LdaConstant), U8(2),
|
|
B(Star5),
|
|
B(CallRuntime), U16(Runtime::kCreatePrivateNameSymbol), R(5), U8(1),
|
|
B(StaCurrentContextSlot), U8(2),
|
|
B(LdaConstant), U8(10),
|
|
B(Star5),
|
|
B(LdaConstant), U8(10),
|
|
B(Star5),
|
|
B(CallRuntime), U16(Runtime::kCreatePrivateNameSymbol), R(5), U8(1),
|
|
B(StaCurrentContextSlot), U8(3),
|
|
B(LdaTheHole),
|
|
B(Star11),
|
|
B(CreateClosure), U8(12), U8(3), U8(2),
|
|
B(Star8),
|
|
B(LdaConstant), U8(11),
|
|
B(Star9),
|
|
B(Mov), R(8), R(10),
|
|
B(CallRuntime), U16(Runtime::kDefineClass), R(9), U8(3),
|
|
B(Star9),
|
|
B(CreateClosure), U8(13), U8(4), U8(2),
|
|
B(Star4),
|
|
B(LdaConstant), U8(9),
|
|
B(Star5),
|
|
B(CreateClosure), U8(14), U8(5), U8(2),
|
|
B(Star8),
|
|
B(CreateClosure), U8(15), U8(6), U8(2),
|
|
B(Star9),
|
|
B(Mov), R(4), R(6),
|
|
B(Mov), R(10), R(7),
|
|
B(CallRuntime), U16(Runtime::kDefineClass), R(5), U8(5),
|
|
B(Star5),
|
|
B(CreateClosure), U8(16), U8(7), U8(2),
|
|
B(Star6),
|
|
B(StaNamedProperty), R(4), U8(7), U8(2),
|
|
B(PopContext), R(3),
|
|
B(Mov), R(4), R(1),
|
|
/* 140 E> */ B(CreateBlockContext), U8(17),
|
|
B(PushContext), R(3),
|
|
B(LdaConstant), U8(2),
|
|
B(Star5),
|
|
B(LdaConstant), U8(2),
|
|
B(Star5),
|
|
B(CallRuntime), U16(Runtime::kCreatePrivateNameSymbol), R(5), U8(1),
|
|
B(StaCurrentContextSlot), U8(2),
|
|
/* 356 E> */ B(CreateClosure), U8(19), U8(8), U8(2),
|
|
B(Star4),
|
|
B(LdaConstant), U8(18),
|
|
B(Star5),
|
|
B(Mov), R(4), R(6),
|
|
B(Mov), R(1), R(7),
|
|
B(CallRuntime), U16(Runtime::kDefineClass), R(5), U8(3),
|
|
B(Star5),
|
|
B(CreateClosure), U8(20), U8(9), U8(2),
|
|
B(Star6),
|
|
B(StaNamedProperty), R(4), U8(7), U8(4),
|
|
B(PopContext), R(3),
|
|
B(Mov), R(4), R(2),
|
|
/* 430 S> */ B(Ldar), R(0),
|
|
/* 430 E> */ B(Construct), R(0), R(0), U8(0), U8(6),
|
|
/* 439 S> */ B(Ldar), R(1),
|
|
/* 439 E> */ B(Construct), R(1), R(0), U8(0), U8(8),
|
|
/* 448 S> */ B(Ldar), R(2),
|
|
/* 448 E> */ B(Construct), R(2), R(0), U8(0), U8(10),
|
|
B(LdaUndefined),
|
|
/* 458 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SCOPE_INFO_TYPE,
|
|
FIXED_ARRAY_TYPE,
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["#a"],
|
|
FIXED_ARRAY_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SYMBOL_TYPE,
|
|
SCOPE_INFO_TYPE,
|
|
FIXED_ARRAY_TYPE,
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["#b"],
|
|
FIXED_ARRAY_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SCOPE_INFO_TYPE,
|
|
FIXED_ARRAY_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|