26c00f4a4c
The `FAST_` prefix doesn’t make much sense — they’re all just different cases with their own optimizations. Packedness being implicit (e.g. `FAST_ELEMENTS` vs. `FAST_HOLEY_ELEMENTS`) is not ideal, either. This patch renames the FAST elements kinds as follows: - e.g. FAST_ELEMENTS => PACKED_ELEMENTS - e.g. FAST_HOLEY_ELEMENTS => HOLEY_ELEMENTS The following exceptions are left intact, for lack of a better name: - FAST_SLOPPY_ARGUMENTS_ELEMENTS - SLOW_SLOPPY_ARGUMENTS_ELEMENTS - FAST_STRING_WRAPPER_ELEMENTS - SLOW_STRING_WRAPPER_ELEMENTS This makes it easier to reason about elements kinds, and less confusing to explain how they’re used. R=jkummerow@chromium.org, cbruni@chromium.org BUG=v8:6548 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ie7c6bee85583c3d84b730f7aebbd70c1efa38af9 Reviewed-on: https://chromium-review.googlesource.com/556032 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#46361}
47 lines
861 B
JavaScript
47 lines
861 B
JavaScript
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
|
|
// Make sure printing different element kinds doesn't crash.
|
|
|
|
var array;
|
|
var obj = {};
|
|
|
|
array = [];
|
|
%DebugPrint(array);
|
|
|
|
// PACKED_SMI_ELEMENTS
|
|
array = [1, 2, 3];
|
|
%DebugPrint(array);
|
|
|
|
// HOLEY_SMI_ELEMENTS
|
|
array[10] = 100;
|
|
array[11] = 100;
|
|
%DebugPrint(array);
|
|
|
|
// PACKED_ELEMENTS
|
|
array = [1, obj, obj];
|
|
%DebugPrint(array);
|
|
|
|
// HOLEY_ELEMENTS
|
|
array[100] = obj;
|
|
array[101] = obj;
|
|
%DebugPrint(array);
|
|
|
|
// PACKED_DOUBLE_ELEMENTS
|
|
array = [1.1, 2.2, 3.3, 3.3, 3.3, NaN];
|
|
%DebugPrint(array);
|
|
array.push(NaN);
|
|
array.push(NaN);
|
|
%DebugPrint(array);
|
|
|
|
// HOLEY_DOUBLE_ELEMENTS
|
|
array[100] = 1.2;
|
|
array[101] = 1.2;
|
|
%DebugPrint(array);
|
|
|
|
// DICTIONARY_ELEMENTS
|
|
%NormalizeElements(array);
|
|
%DebugPrint(array);
|