a27871d527
Portd324382e1cand Portbd3f0a684bOriginal Commit Message: This is a reland ofa462a7854aOriginal change's description: > [turboassembler] Introduce hard-abort mode > > For checks and assertions (mostly for debug code, like stack alignment > or zero extension), we had two modes: Emit a call to the {Abort} > runtime function (the default), and emit a debug break (used for > testing, enabled via --trap-on-abort). > In wasm, where we cannot just call a runtime function because code must > be isolate independent, we always used the trap-on-abort behaviour. > This causes problems for our fuzzers, which do not catch SIGTRAP, and > hence do not detect debug code failures. > > This CL introduces a third mode ("hard abort"), which calls a C > function via {ExternalReference}. The C function still outputs the > abort reason, but does not print the stack trace. It then aborts via > "OS::Abort", just like the runtime function. > This will allow fuzzers to detect the crash and even find a nice error > message. > > Even though this looks like a lot of code churn, it is actually not. > Most added lines are new tests, and other changes are minimal. > > R=mstarzinger@chromium.org > > Bug: chromium:863799 > Change-Id: I77c58ff72db552d49014614436259ccfb49ba87b > Reviewed-on: https://chromium-review.googlesource.com/1142163 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54592} R=clemensh@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I60023470fa07576fd313f628ade06e279d5f4927 Reviewed-on: https://chromium-review.googlesource.com/1165822 Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54980}
69 lines
2.1 KiB
C++
69 lines
2.1 KiB
C++
// Copyright 2018 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/macro-assembler.h"
|
|
#include "src/s390/assembler-s390-inl.h"
|
|
#include "src/simulator.h"
|
|
#include "test/common/assembler-tester.h"
|
|
#include "test/unittests/test-utils.h"
|
|
#include "testing/gtest-support.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
#define __ tasm.
|
|
|
|
// Test the s390 assembler by compiling some simple functions into
|
|
// a buffer and executing them. These tests do not initialize the
|
|
// V8 library, create a context, or use any V8 objects.
|
|
|
|
class TurboAssemblerTest : public TestWithIsolate {};
|
|
|
|
TEST_F(TurboAssemblerTest, TestHardAbort) {
|
|
size_t allocated;
|
|
byte* buffer = AllocateAssemblerBuffer(&allocated);
|
|
TurboAssembler tasm(nullptr, AssemblerOptions{}, buffer,
|
|
static_cast<int>(allocated), CodeObjectRequired::kNo);
|
|
__ set_abort_hard(true);
|
|
|
|
__ Abort(AbortReason::kNoReason);
|
|
|
|
CodeDesc desc;
|
|
tasm.GetCode(nullptr, &desc);
|
|
MakeAssemblerBufferExecutable(buffer, allocated);
|
|
// We need an isolate here to execute in the simulator.
|
|
auto f = GeneratedCode<void>::FromBuffer(isolate(), buffer);
|
|
|
|
ASSERT_DEATH_IF_SUPPORTED({ f.Call(); }, "abort: no reason");
|
|
}
|
|
|
|
TEST_F(TurboAssemblerTest, TestCheck) {
|
|
size_t allocated;
|
|
byte* buffer = AllocateAssemblerBuffer(&allocated);
|
|
TurboAssembler tasm(nullptr, AssemblerOptions{}, buffer,
|
|
static_cast<int>(allocated), CodeObjectRequired::kNo);
|
|
__ set_abort_hard(true);
|
|
|
|
// Fail if the first parameter is 17.
|
|
__ lgfi(r3, Operand(17));
|
|
__ CmpP(r2, r3); // 1st parameter is in {r2}.
|
|
__ Check(Condition::ne, AbortReason::kNoReason);
|
|
__ Ret();
|
|
|
|
CodeDesc desc;
|
|
tasm.GetCode(nullptr, &desc);
|
|
MakeAssemblerBufferExecutable(buffer, allocated);
|
|
// We need an isolate here to execute in the simulator.
|
|
auto f = GeneratedCode<void, int>::FromBuffer(isolate(), buffer);
|
|
|
|
f.Call(0);
|
|
f.Call(18);
|
|
ASSERT_DEATH_IF_SUPPORTED({ f.Call(17); }, "abort: no reason");
|
|
}
|
|
|
|
#undef __
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|