AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
a2a9b4a7ea
v8/test
History
adamk a2a9b4a7ea Revert of [wasm] Remove improper assembler check for grow memory. (patchset #2 id:20001 of https://codereview.chromium.org/2376153003/ ) 
Reason for revert:
grow-memory test now fails on Linux dbg, blocking the CQ:

https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug/builds/11217

Original issue's description:
> [wasm] Remove improper assembler check for grow memory.
>
> Note that the offset can still be out of bounds, even after grow memory. The calculation of the remaining size can overflow.
>
> R=gdeepti@chromium.org
> BUG=chromium:644670
>
> Committed: https://crrev.com/e6071a9c067e07304329250e040b652fb82e9b5e
> Cr-Commit-Position: refs/heads/master@{#39886}

TBR=gdeepti@chromium.org,titzer@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:644670

Review-Url: https://codereview.chromium.org/2378973003
Cr-Commit-Position: refs/heads/master@{#39889}
2016-09-29 21:54:57 +00:00
..
benchmarks [gn] Move build to gypfiles 2016-04-29 10:11:11 +00:00
cctest [wasm] Refactor handling of data segments in WasmModuleBuilder. 2016-09-29 18:13:39 +00:00
common Fix bounds check of a store instruction after a grow_memory instruction 2016-09-28 20:56:01 +00:00
fuzzer [wasm] Rename encoder.(cc,h) to wasm-module-builder.(cc,h) 2016-09-29 11:29:19 +00:00
inspector [inspector] added inspector test runner [part 2] 2016-09-29 21:40:48 +00:00
inspector_protocol_parser_test [inspector] Remove inspector_protocol_parser_test target. 2016-08-11 16:45:14 +00:00
intl [wasm] asm.js: Add asm_wasm variant to test asm.js->wasm pipeline. 2016-09-19 23:57:13 +00:00
js-perf-test [test] Reduce time spent on js-perf tests and fix timeouts. 2016-09-29 09:33:45 +00:00
memory [snapshot] support multiple contexts in the same snapshot. 2016-06-15 15:39:06 +00:00
message [es8] Remove syntactic tail calls support. 2016-09-28 08:25:45 +00:00
mjsunit Revert of [wasm] Remove improper assembler check for grow memory. (patchset #2 id:20001 of https://codereview.chromium.org/2376153003/ ) 2016-09-29 21:54:57 +00:00
mozilla [turbofan] Don't take into account source size for inlining heuristics. 2016-09-23 16:23:34 +00:00
preparser [gn] Move build to gypfiles 2016-04-29 10:11:11 +00:00
promises-aplus
simdjs [test] Deprecate test data download for most test suites 2016-08-08 12:39:48 +00:00
test262 [modules] Disallow return statement in module body. 2016-09-26 19:35:09 +00:00
unittests [wasm] Rename encoder.(cc,h) to wasm-module-builder.(cc,h) 2016-09-29 11:29:19 +00:00
webkit [wasm] asm.js: Add asm_wasm variant to test asm.js->wasm pipeline. 2016-09-19 23:57:13 +00:00
bot_default.gyp [inspector] Remove inspector_protocol_parser_test target. 2016-08-11 16:45:14 +00:00
bot_default.isolate [inspector] Remove inspector_protocol_parser_test target. 2016-08-11 16:45:14 +00:00
BUILD.gn [inspector] added inspector test runner [part 1] 2016-09-29 13:46:06 +00:00
default.gyp [inspector] Remove inspector_protocol_parser_test target. 2016-08-11 16:45:14 +00:00
default.isolate [inspector] Remove inspector_protocol_parser_test target. 2016-08-11 16:45:14 +00:00
optimize_for_size.gyp [gn] Move build to gypfiles 2016-04-29 10:11:11 +00:00
optimize_for_size.isolate
perf.gyp [gn] Move build to gypfiles 2016-04-29 10:11:11 +00:00
perf.isolate