c63236328e
Reason for revert: Will test better; there seems to be a bug related to this. Original issue's description: > Reland of Disable non-standard Promise functions in staging (patchset #1 id:1 of https://codereview.chromium.org/1473603002/ ) > > Reason for revert: > Breakage in Ignition seems unrelated; relanding. > > Original issue's description: > > Revert of Disable non-standard Promise functions in staging (patchset #5 id:80001 of https://codereview.chromium.org/1469543003/ ) > > > > Reason for revert: > > [Sheriff] This breaks ignition on arm sim debug: > > https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm%20-%20sim%20-%20debug/builds/5317 > > > > Seems to not be caught by the cq bot that builds release with dchecks. > > > > Original issue's description: > > > Disable non-standard Promise functions in staging > > > > > > This patch removes Promise functions and methods which are absent > > > from the ES2015 specification when the --es-staging flag is on. > > > > > > BUG=v8:3237 > > > R=rossberg > > > LOG=Y > > > > > > Committed: https://crrev.com/941251af7e04d50ac2243da2870249a42111221a > > > Cr-Commit-Position: refs/heads/master@{#32194} > > > > TBR=rossberg@chromium.org,littledan@chromium.org > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=v8:3237 > > > > Committed: https://crrev.com/86bd2b3c23b562213d5af158849dcd65f347a827 > > Cr-Commit-Position: refs/heads/master@{#32199} > > TBR=rossberg@chromium.org,rmcilroy@chromium.org,machenbach@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:3237 > > Committed: https://crrev.com/9278b7b05a45c2089007e8b61822af96b5d0c8df > Cr-Commit-Position: refs/heads/master@{#32235} TBR=rossberg@chromium.org,rmcilroy@chromium.org,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3237 Review URL: https://codereview.chromium.org/1493713004 Cr-Commit-Position: refs/heads/master@{#32530}
85 lines
2.3 KiB
JavaScript
85 lines
2.3 KiB
JavaScript
// Copyright 2014 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --expose-debug-as debug --allow-natives-syntax
|
|
|
|
// Test debug events when a Promise is rejected, which is caught by a
|
|
// custom promise, which throws a new exception in its reject handler.
|
|
// We expect two Exception debug events:
|
|
// 1) when promise q is rejected.
|
|
// 2) when the custom reject closure in MyPromise throws an exception.
|
|
|
|
Debug = debug.Debug;
|
|
|
|
var expected_events = 1;
|
|
var log = [];
|
|
|
|
var p = new Promise(function(resolve, reject) {
|
|
log.push("resolve");
|
|
resolve();
|
|
});
|
|
|
|
function MyPromise(resolver) {
|
|
var reject = function() {
|
|
log.push("throw in reject");
|
|
throw new Error("reject"); // event
|
|
};
|
|
var resolve = function() { };
|
|
log.push("construct");
|
|
resolver(resolve, reject);
|
|
};
|
|
|
|
MyPromise.prototype = new Promise(function() {});
|
|
p.constructor = MyPromise;
|
|
|
|
var q = p.chain(
|
|
function() {
|
|
log.push("reject caught");
|
|
return Promise.reject(new Error("caught"));
|
|
});
|
|
|
|
function listener(event, exec_state, event_data, data) {
|
|
try {
|
|
if (event == Debug.DebugEvent.Exception) {
|
|
expected_events--;
|
|
assertTrue(expected_events >= 0);
|
|
assertEquals("reject", event_data.exception().message);
|
|
// Assert that the debug event is triggered at the throw site.
|
|
assertTrue(
|
|
exec_state.frame(0).sourceLineText().indexOf("// event") > 0);
|
|
}
|
|
} catch (e) {
|
|
// Signal a failure with exit code 1. This is necessary since the
|
|
// debugger swallows exceptions and we expect the chained function
|
|
// and this listener to be executed after the main script is finished.
|
|
print("Unexpected exception: " + e + "\n" + e.stack);
|
|
quit(1);
|
|
}
|
|
}
|
|
|
|
Debug.setBreakOnUncaughtException();
|
|
Debug.setListener(listener);
|
|
|
|
log.push("end main");
|
|
|
|
function testDone(iteration) {
|
|
function checkResult() {
|
|
try {
|
|
assertTrue(iteration < 10);
|
|
if (expected_events === 0) {
|
|
assertEquals(["resolve", "construct", "end main",
|
|
"reject caught", "throw in reject"], log);
|
|
} else {
|
|
testDone(iteration + 1);
|
|
}
|
|
} catch (e) {
|
|
%AbortJS(e + "\n" + e.stack);
|
|
}
|
|
}
|
|
|
|
%EnqueueMicrotask(checkResult);
|
|
}
|
|
|
|
testDone(0);
|