a2f2e913f8
Reason for revert: [Sheriff] Layout test changes. Original issue's description: > [debugger] debug-evaluate should not not modify local values. > > Debug evaluate no longer writes back changes to the replicated > context chain to the original after execution. Changes to the > global object or script contexts still stick. Calling functions > that bind to the original context chain also have their expected > side effects. > > As far as I can tell, DevTools is not interested in modifying > local variable values. Modifying global variable values still > works as expected. However, I have not yet removed the old > implementation, but merely keep it behind a flag. > > R=mstarzinger@chromium.org, rossberg@chromium.org > > Committed: https://crrev.com/92caa9b85eefffbef51c67428397951bd2e2c330 > Cr-Commit-Position: refs/heads/master@{#32841} TBR=mstarzinger@chromium.org,rossberg@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1526553003 Cr-Commit-Position: refs/heads/master@{#32845}
47 lines
1.0 KiB
JavaScript
47 lines
1.0 KiB
JavaScript
// Copyright 2014 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --expose-debug-as debug
|
|
|
|
Debug = debug.Debug;
|
|
|
|
var step = 0;
|
|
var exception = null;
|
|
|
|
function listener(event, exec_state, event_data, data) {
|
|
if (event != Debug.DebugEvent.Break) return;
|
|
try {
|
|
if (step == 0) {
|
|
assertEquals("error", exec_state.frame(0).evaluate("e").value());
|
|
exec_state.frame(0).evaluate("e = 'foo'");
|
|
exec_state.frame(0).evaluate("x = 'modified'");
|
|
} else {
|
|
assertEquals("argument", exec_state.frame(0).evaluate("e").value());
|
|
exec_state.frame(0).evaluate("e = 'bar'");
|
|
}
|
|
step++;
|
|
} catch (e) {
|
|
print(e + e.stack);
|
|
exception = e;
|
|
}
|
|
}
|
|
|
|
Debug.setListener(listener);
|
|
|
|
function f(e, x) {
|
|
try {
|
|
throw "error";
|
|
} catch(e) {
|
|
debugger;
|
|
assertEquals("foo", e);
|
|
}
|
|
debugger;
|
|
assertEquals("bar", e);
|
|
assertEquals("modified", x);
|
|
}
|
|
|
|
f("argument")
|
|
assertNull(exception);
|
|
assertEquals(2, step);
|