f87014ebde
Currently we do not check for @@isConcatSpreadable properly. If the Symbol is set on the Array.prototype or Object.prototype the current fast paths fail. This CL adds a fix to globally invalidate a isConcatSpreadable_protector. Drive-by-fix: use named accessors for context variables LOG=N BUG=chromium:542504, v8:903 Review-Url: https://codereview.chromium.org/1409123003 Cr-Commit-Position: refs/heads/master@{#36201}
49 lines
1.9 KiB
JavaScript
49 lines
1.9 KiB
JavaScript
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Check that @@isConcatSpreadable is checked when set on Object.prototype
|
|
|
|
"use strict"
|
|
|
|
var array = [1, 2, 3];
|
|
var object = {length: 1, '0': 'a'};
|
|
|
|
function testConcatDefaults() {
|
|
assertEquals(array, [].concat(array));
|
|
assertEquals(array, array.concat([]));
|
|
assertEquals([1, 2, 3, 1, 2, 3], array.concat(array));
|
|
assertEquals([object], [].concat(object));
|
|
assertEquals([1, 2, 3, object], array.concat(object));
|
|
assertEquals([object], Array.prototype.concat.call(object,[]));
|
|
assertEquals([object, 1, 2, 3], Array.prototype.concat.call(object, array));
|
|
assertEquals([object, object], Array.prototype.concat.call(object, object));
|
|
}
|
|
|
|
testConcatDefaults();
|
|
|
|
Object.prototype[Symbol.isConcatSpreadable] = false;
|
|
|
|
assertEquals([[], array], [].concat(array));
|
|
assertEquals([array, []], array.concat([]));
|
|
assertEquals([array, array], array.concat(array));
|
|
assertEquals([[], object], [].concat(object));
|
|
assertEquals([array, object], array.concat(object));
|
|
assertEquals([object, []], Array.prototype.concat.call(object,[]));
|
|
assertEquals([object, array], Array.prototype.concat.call(object, array));
|
|
assertEquals([object, object], Array.prototype.concat.call(object, object));
|
|
|
|
Object.prototype[Symbol.isConcatSpreadable] = true;
|
|
|
|
assertEquals(array, [].concat(array));
|
|
assertEquals(array, array.concat([]));
|
|
assertEquals([1, 2, 3, 1, 2, 3], array.concat(array));
|
|
assertEquals(['a'], [].concat(object));
|
|
assertEquals([1, 2, 3, 'a'], array.concat(object));
|
|
assertEquals(['a'], Array.prototype.concat.call(object,[]));
|
|
assertEquals(['a', 1, 2, 3], Array.prototype.concat.call(object, array));
|
|
assertEquals(['a', 'a'], Array.prototype.concat.call(object, object));
|
|
|
|
delete Object.prototype[Symbol.isConcatSpreadable];
|
|
testConcatDefaults();
|