6da8e1f993
This reverts commit 34625fdb5a.
Reason for revert: Test caused timeout, investigating.
Original change's description:
> [Builtins] Array.prototype.forEach perf regression on dictionaries.
>
> An unnecessary call to ToString() on the array index caused trips to
> the runtime. The fix also includes performance micro-benchmarks so
> we'll have a harder time regressing this case in future.
>
> Bug: v8:8112
> Change-Id: Iada5bd2e3c6d2246fb1225e7094f3d9c66ddafbd
> Reviewed-on: https://chromium-review.googlesource.com/1206355
> Commit-Queue: Michael Stanton <mvstanton@chromium.org>
> Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55653}
TBR=mvstanton@chromium.org,tebbi@chromium.org
Change-Id: I21de9b9b33edf03f2173f579c4ba0fc3dfd8ff88
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:8112
Reviewed-on: https://chromium-review.googlesource.com/1209288
Reviewed-by: Michael Stanton <mvstanton@chromium.org>
Commit-Queue: Michael Stanton <mvstanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55681}
64 lines
1.9 KiB
JavaScript
64 lines
1.9 KiB
JavaScript
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
(() => {
|
|
|
|
function NaiveMap() {
|
|
let index = -1
|
|
const length = array == null ? 0 : array.length
|
|
const result = new Array(length)
|
|
|
|
while (++index < length) {
|
|
result[index] = func(array[index], index, array)
|
|
}
|
|
return result
|
|
}
|
|
|
|
function NaiveMapSetup() {
|
|
// Prime NaiveMap with polymorphic cases.
|
|
array = [1, 2, 3];
|
|
NaiveMap();
|
|
NaiveMap();
|
|
array = [3.4]; NaiveMap();
|
|
array = new Array(10); array[0] = 'hello'; NaiveMap();
|
|
SmiSetup();
|
|
delete array[1];
|
|
}
|
|
|
|
// Make sure we inline the callback, pick up all possible TurboFan
|
|
// optimizations.
|
|
function RunOptFastMap(multiple) {
|
|
// Use of variable multiple in the callback function forces
|
|
// context creation without escape analysis.
|
|
//
|
|
// Also, the arrow function requires inlining based on
|
|
// SharedFunctionInfo.
|
|
result = array.map((v, i, a) => v + ' ' + multiple);
|
|
}
|
|
|
|
// Don't optimize because I want to optimize RunOptFastMap with a parameter
|
|
// to be used in the callback.
|
|
%NeverOptimizeFunction(OptFastMap);
|
|
function OptFastMap() { RunOptFastMap(3); }
|
|
|
|
function side_effect(a) { return a; }
|
|
%NeverOptimizeFunction(side_effect);
|
|
function OptUnreliableMap() {
|
|
result = array.map(func, side_effect(array));
|
|
}
|
|
|
|
DefineHigherOrderTests([
|
|
// name, test function, setup function, user callback
|
|
['NaiveMapReplacement', NaiveMap, NaiveMapSetup, v => v],
|
|
['SmiMap', newClosure('map'), SmiSetup, v => v],
|
|
['DoubleMap', newClosure('map'), DoubleSetup, v => v],
|
|
['FastMap', newClosure('map'), FastSetup, v => v],
|
|
['SmallSmiToDoubleMap', newClosure('map'), SmiSetup, v => v + 0.5],
|
|
['SmallSmiToFastMap', newClosure('map'), SmiSetup, v => 'hi' + v],
|
|
['GenericMap', newClosure('map', true), ObjectSetup, v => v],
|
|
['OptFastMap', OptFastMap, FastSetup, undefined],
|
|
['OptUnreliableMap', OptUnreliableMap, FastSetup, v => v]
|
|
]);
|
|
|
|
})();
|