a3b6067525
This is mostly a simple copy & paste of the stub implementation from code-stubs-arch.cc to builtins-arch.cc. The conversion allows removal of a special case for the DoubleToIStub within the compiler & wasm pipelines, and also makes the following builtins isolate-independent (in conjunction with https://crrev.com/c/1006581): TFC BitwiseAnd TFC BitwiseOr TFC BitwiseXor TFC Exponentiate TFC ShiftLeft TFC ShiftRight TFC ShiftRightLogical TFJ AtomicsAdd TFJ AtomicsAnd TFJ AtomicsCompareExchange TFJ AtomicsExchange TFJ AtomicsLoad TFJ AtomicsOr TFJ AtomicsStore TFJ AtomicsSub TFJ AtomicsXor TFJ MathClz32 TFJ MathImul TFJ MathPow TFJ NumberParseInt TFJ StringFromCharCode TFJ TypedArrayFrom TFJ TypedArrayOf TFJ TypedArrayPrototypeMap Drive-by: dead code removal & TODOs in code-stubs.h. Bug: v8:6666 Change-Id: I763cba2242bcadc2d130b0aaa16a9787212b466a Reviewed-on: https://chromium-review.googlesource.com/1012024 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#52591}
181 lines
6.0 KiB
C++
181 lines
6.0 KiB
C++
// Copyright 2013 the V8 project authors. All rights reserved.
|
|
// Rrdistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Rrdistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Rrdistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following
|
|
// disclaimer in the documentation and/or other materials provided
|
|
// with the distribution.
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
// contributors may be used to endorse or promote products derived
|
|
// from this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
#include <stdlib.h>
|
|
|
|
#include "src/v8.h"
|
|
|
|
#include "src/arm64/macro-assembler-arm64-inl.h"
|
|
#include "src/base/platform/platform.h"
|
|
#include "src/code-stubs.h"
|
|
#include "src/heap/factory.h"
|
|
#include "src/macro-assembler.h"
|
|
#include "src/simulator.h"
|
|
#include "test/cctest/cctest.h"
|
|
#include "test/cctest/test-code-stubs.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
#define __ masm.
|
|
|
|
ConvertDToIFunc MakeConvertDToIFuncTrampoline(Isolate* isolate,
|
|
Register destination_reg) {
|
|
HandleScope handles(isolate);
|
|
|
|
size_t allocated;
|
|
byte* buffer =
|
|
AllocateAssemblerBuffer(&allocated, 4 * Assembler::kMinimalBufferSize);
|
|
MacroAssembler masm(isolate, buffer, static_cast<int>(allocated),
|
|
v8::internal::CodeObjectRequired::kYes);
|
|
|
|
Handle<Code> code = BUILTIN_CODE(isolate, DoubleToI);
|
|
byte* start = code->InstructionStart();
|
|
|
|
__ PushCalleeSavedRegisters();
|
|
|
|
MacroAssembler::PushPopQueue queue(&masm);
|
|
|
|
// Save registers make sure they don't get clobbered.
|
|
int source_reg_offset = kDoubleSize;
|
|
int reg_num = 0;
|
|
for (; reg_num < Register::kNumRegisters; ++reg_num) {
|
|
if (RegisterConfiguration::Default()->IsAllocatableGeneralCode(reg_num)) {
|
|
Register reg = Register::from_code(reg_num);
|
|
queue.Queue(reg);
|
|
source_reg_offset += kPointerSize;
|
|
}
|
|
}
|
|
// Push the double argument. We push a second copy to maintain sp alignment.
|
|
queue.Queue(d0);
|
|
queue.Queue(d0);
|
|
|
|
queue.PushQueued();
|
|
|
|
// Call through to the actual stub.
|
|
__ Call(start, RelocInfo::EXTERNAL_REFERENCE);
|
|
__ Peek(destination_reg, 0);
|
|
|
|
__ Drop(2, kDoubleSize);
|
|
|
|
// Make sure no registers have been unexpectedly clobbered.
|
|
{
|
|
const RegisterConfiguration* config(RegisterConfiguration::Default());
|
|
int allocatable_register_count =
|
|
config->num_allocatable_general_registers();
|
|
UseScratchRegisterScope temps(&masm);
|
|
Register temp0 = temps.AcquireX();
|
|
Register temp1 = temps.AcquireX();
|
|
for (int i = allocatable_register_count - 1; i > 0; i -= 2) {
|
|
int code0 = config->GetAllocatableGeneralCode(i);
|
|
int code1 = config->GetAllocatableGeneralCode(i - 1);
|
|
Register reg0 = Register::from_code(code0);
|
|
Register reg1 = Register::from_code(code1);
|
|
__ Pop(temp0, temp1);
|
|
if (!reg0.is(destination_reg)) {
|
|
__ Cmp(reg0, temp0);
|
|
__ Assert(eq, AbortReason::kRegisterWasClobbered);
|
|
}
|
|
if (!reg1.is(destination_reg)) {
|
|
__ Cmp(reg1, temp1);
|
|
__ Assert(eq, AbortReason::kRegisterWasClobbered);
|
|
}
|
|
}
|
|
|
|
if (allocatable_register_count % 2 != 0) {
|
|
int code = config->GetAllocatableGeneralCode(0);
|
|
Register reg = Register::from_code(code);
|
|
__ Pop(temp0, xzr);
|
|
if (!reg.is(destination_reg)) {
|
|
__ Cmp(reg, temp0);
|
|
__ Assert(eq, AbortReason::kRegisterWasClobbered);
|
|
}
|
|
}
|
|
}
|
|
|
|
if (!destination_reg.is(x0))
|
|
__ Mov(x0, destination_reg);
|
|
|
|
// Restore callee save registers.
|
|
__ PopCalleeSavedRegisters();
|
|
|
|
__ Ret();
|
|
|
|
CodeDesc desc;
|
|
masm.GetCode(isolate, &desc);
|
|
MakeAssemblerBufferExecutable(buffer, allocated);
|
|
Assembler::FlushICache(buffer, allocated);
|
|
return (reinterpret_cast<ConvertDToIFunc>(
|
|
reinterpret_cast<intptr_t>(buffer)));
|
|
}
|
|
|
|
#undef __
|
|
|
|
|
|
static Isolate* GetIsolateFrom(LocalContext* context) {
|
|
return reinterpret_cast<Isolate*>((*context)->GetIsolate());
|
|
}
|
|
|
|
|
|
int32_t RunGeneratedCodeCallWrapper(ConvertDToIFunc func,
|
|
double from) {
|
|
#ifdef USE_SIMULATOR
|
|
return Simulator::current(CcTest::i_isolate())
|
|
->Call<int32_t>(FUNCTION_ADDR(func), from);
|
|
#else
|
|
return (*func)(from);
|
|
#endif
|
|
}
|
|
|
|
|
|
TEST(ConvertDToI) {
|
|
CcTest::InitializeVM();
|
|
LocalContext context;
|
|
Isolate* isolate = GetIsolateFrom(&context);
|
|
HandleScope scope(isolate);
|
|
|
|
#if DEBUG
|
|
// Verify that the tests actually work with the C version. In the release
|
|
// code, the compiler optimizes it away because it's all constant, but does it
|
|
// wrong, triggering an assert on gcc.
|
|
RunAllTruncationTests(&ConvertDToICVersion);
|
|
#endif
|
|
|
|
Register dest_registers[] = {x0, x1, x2, x3, x4, x5, x6, x7, x8, x9, x10, x11,
|
|
x12, x13, x14, x15, x18, x19, x20, x21, x22, x23,
|
|
x24};
|
|
|
|
for (size_t d = 0; d < sizeof(dest_registers) / sizeof(Register); d++) {
|
|
RunAllTruncationTests(
|
|
RunGeneratedCodeCallWrapper,
|
|
MakeConvertDToIFuncTrampoline(isolate, dest_registers[d]));
|
|
}
|
|
}
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|