df8e617772
This is a reland of bc33f5aeba
Original change's description:
> [arraybuffer] Rearchitect backing store ownership
>
> This CL completely rearchitects the ownership of array buffer backing stores,
> consolidating ownership into a {BackingStore} C++ object that is tracked
> throughout V8 using unique_ptr and shared_ptr where appropriate.
>
> Overall, lifetime management is simpler and more explicit. The numerous
> ways that array buffers were initialized have been streamlined to one
> Attach() method on JSArrayBuffer. The array buffer tracker in the
> GC implementation now manages std::shared_ptr<BackingStore> pointers,
> and the construction and destruction of the BackingStore object itself
> handles the underlying page or embedder-allocated memory.
>
> The embedder API remains unchanged for now. We use the
> v8::ArrayBuffer::Contents struct to hide an additional shared_ptr to
> keep the backing store alive properly, even in the case of aliases
> from live heap objects. Thus the embedder has a lower chance of making
> a mistake. Long-term, we should move the embedder to a model where they
> manage backing stores using shared_ptr to an opaque backing store object.
R=mlippautz@chromium.org
BUG=v8:9380,v8:9221,chromium:986318
TBR=ulan@chromium.org
Change-Id: I6c49e2425029b5664ef1c68dab8b5146f4ed0ff2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1719191
Reviewed-by: Ben Titzer <titzer@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Ben Titzer <titzer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#63007}
37 lines
958 B
JavaScript
37 lines
958 B
JavaScript
// Copyright 2019 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --experimental-wasm-threads --expose-gc
|
|
|
|
const kNumMessages = 1000;
|
|
|
|
function AllocMemory(pages = 1, max = pages) {
|
|
return new WebAssembly.Memory({initial : pages, maximum : max, shared : true});
|
|
}
|
|
|
|
(function RunTest() {
|
|
let worker = new Worker(
|
|
`onmessage =
|
|
function(msg) {
|
|
if (msg.memory) postMessage({memory : msg.memory});
|
|
gc();
|
|
}`, {type : 'string'});
|
|
|
|
let time = performance.now();
|
|
|
|
for (let i = 0; i < kNumMessages; i++) {
|
|
let now = performance.now();
|
|
print(`iteration ${i}, Δ = ${(now - time).toFixed(3)} ms`);
|
|
time = now;
|
|
|
|
let memory = AllocMemory();
|
|
worker.postMessage({memory : memory});
|
|
let msg = worker.getMessage();
|
|
if (msg.memory) {
|
|
assertInstanceof(msg.memory, WebAssembly.Memory);
|
|
}
|
|
gc();
|
|
}
|
|
})();
|