b261213fcc
This reverts commit 24c626c1f7.
Reason for revert: Blocks V8 roll into Chromium (changed error messages cause tests to fail):
https://ci.chromium.org/p/chromium/builders/try/linux-rel/724109?
Original change's description:
> Improve error messages for property access on null/undefined
>
> Only print the property name when accessing null/undefined if we can
> convert it to a string without causing side effects.
> If we can't, omit the property name in the error message.
> This should avoid confusion when the key is an object with toString().
> E.g. undefined[{toString:()=>'a'}] doesn't print 'read property [object
> Object]' anymore, which was misleading since the property accessed would
> be 'a', but we can't evaluate the key without side effects.
>
> Bug: v8:11365
> Change-Id: If82d1adb42561d4851e2bd2ca297a1c71738aee8
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960211
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Commit-Queue: Patrick Thier <pthier@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#75250}
Bug: v8:11365
Change-Id: Ic63f34033254f55b3871041633d84ea48586a75d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2977374
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#75282}
49 lines
3.0 KiB
Plaintext
49 lines
3.0 KiB
Plaintext
# Copyright 2013 the V8 project authors. All rights reserved.
|
|
# Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
|
|
#
|
|
# Redistribution and use in source and binary forms, with or without
|
|
# modification, are permitted provided that the following conditions
|
|
# are met:
|
|
# 1. Redistributions of source code must retain the above copyright
|
|
# notice, this list of conditions and the following disclaimer.
|
|
# 2. Redistributions in binary form must reproduce the above copyright
|
|
# notice, this list of conditions and the following disclaimer in the
|
|
# documentation and/or other materials provided with the distribution.
|
|
#
|
|
# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
|
|
# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
|
|
# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
|
|
# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY
|
|
# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
|
|
# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
|
|
# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
|
|
# ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
|
|
# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
This test checks that deletion of properties works properly with getters and setters.
|
|
|
|
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
|
|
|
|
|
|
PASS b1.property threw exception TypeError: Cannot read property 'property' of undefined.
|
|
PASS a2.property threw exception TypeError: Cannot read property 'property' of undefined.
|
|
PASS b3.property threw exception TypeError: Cannot read property 'property' of undefined.
|
|
PASS a4.property threw exception TypeError: Cannot read property 'property' of undefined.
|
|
PASS b5.property threw exception TypeError: Cannot read property 'property' of undefined.
|
|
PASS a6.property threw exception TypeError: Cannot read property 'property' of undefined.
|
|
PASS b7.property threw exception TypeError: Cannot read property 'property' of undefined.
|
|
PASS a8.property threw exception TypeError: Cannot read property 'property' of undefined.
|
|
PASS o1.b.property threw exception TypeError: Cannot read property 'property' of undefined.
|
|
PASS o1.a.property threw exception TypeError: Cannot read property 'property' of undefined.
|
|
PASS o3.b.property threw exception TypeError: Cannot read property 'property' of undefined.
|
|
PASS o4.a.property threw exception TypeError: Cannot read property 'property' of undefined.
|
|
PASS o5.b.property threw exception TypeError: Cannot read property 'property' of undefined.
|
|
PASS o6.a.property threw exception TypeError: Cannot read property 'property' of undefined.
|
|
PASS o7.b.property threw exception TypeError: Cannot read property 'property' of undefined.
|
|
PASS o8.a.property threw exception TypeError: Cannot read property 'property' of undefined.
|
|
PASS successfullyParsed is true
|
|
|
|
TEST COMPLETE
|
|
|