c6414dacdd
This reverts commit 87f71769c5.
Reason for revert: Performance regressions https://chromeperf.appspot.com/group_report?rev=46185
Original change's description:
> [ignition] Merge bytecode array builder and writer
>
> Move bytecode array writing logic into the array builder, allowing us to
> remove the bytecode array writer and bytecode node, and convert runtime
> operand writing to compile-time bytecode operand writing using the
> information statically known at compile time.
>
> Bug: v8:6474
> Change-Id: I210cd9897fd41293745614e4a253c7c251dfffc9
> Reviewed-on: https://chromium-review.googlesource.com/533055
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#46183}
TBR=rmcilroy@chromium.org,leszeks@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: v8:6474
Bug: chromium:736646
Change-Id: I00287b2bbbb8efa5a3141bc9c2906f91a7d33e51
Reviewed-on: https://chromium-review.googlesource.com/549319
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46235}
102 lines
3.5 KiB
C++
102 lines
3.5 KiB
C++
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/v8.h"
|
|
|
|
#include "src/interpreter/bytecode-node.h"
|
|
#include "test/unittests/test-utils.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace interpreter {
|
|
|
|
using BytecodeNodeTest = TestWithIsolateAndZone;
|
|
|
|
TEST_F(BytecodeNodeTest, Constructor1) {
|
|
BytecodeNode node(Bytecode::kLdaZero);
|
|
CHECK_EQ(node.bytecode(), Bytecode::kLdaZero);
|
|
CHECK_EQ(node.operand_count(), 0);
|
|
CHECK(!node.source_info().is_valid());
|
|
}
|
|
|
|
TEST_F(BytecodeNodeTest, Constructor2) {
|
|
uint32_t operands[] = {0x11};
|
|
BytecodeNode node(Bytecode::kJumpIfTrue, operands[0]);
|
|
CHECK_EQ(node.bytecode(), Bytecode::kJumpIfTrue);
|
|
CHECK_EQ(node.operand_count(), 1);
|
|
CHECK_EQ(node.operand(0), operands[0]);
|
|
CHECK(!node.source_info().is_valid());
|
|
}
|
|
|
|
TEST_F(BytecodeNodeTest, Constructor3) {
|
|
uint32_t operands[] = {0x11, 0x22};
|
|
BytecodeNode node(Bytecode::kLdaGlobal, operands[0], operands[1]);
|
|
CHECK_EQ(node.bytecode(), Bytecode::kLdaGlobal);
|
|
CHECK_EQ(node.operand_count(), 2);
|
|
CHECK_EQ(node.operand(0), operands[0]);
|
|
CHECK_EQ(node.operand(1), operands[1]);
|
|
CHECK(!node.source_info().is_valid());
|
|
}
|
|
|
|
TEST_F(BytecodeNodeTest, Constructor4) {
|
|
uint32_t operands[] = {0x11, 0x22, 0x33};
|
|
BytecodeNode node(Bytecode::kLdaNamedProperty, operands[0], operands[1],
|
|
operands[2]);
|
|
CHECK_EQ(node.operand_count(), 3);
|
|
CHECK_EQ(node.bytecode(), Bytecode::kLdaNamedProperty);
|
|
CHECK_EQ(node.operand(0), operands[0]);
|
|
CHECK_EQ(node.operand(1), operands[1]);
|
|
CHECK_EQ(node.operand(2), operands[2]);
|
|
CHECK(!node.source_info().is_valid());
|
|
}
|
|
|
|
TEST_F(BytecodeNodeTest, Constructor5) {
|
|
uint32_t operands[] = {0x71, 0xa5, 0x5a, 0xfc};
|
|
BytecodeNode node(Bytecode::kForInNext, operands[0], operands[1], operands[2],
|
|
operands[3]);
|
|
CHECK_EQ(node.operand_count(), 4);
|
|
CHECK_EQ(node.bytecode(), Bytecode::kForInNext);
|
|
CHECK_EQ(node.operand(0), operands[0]);
|
|
CHECK_EQ(node.operand(1), operands[1]);
|
|
CHECK_EQ(node.operand(2), operands[2]);
|
|
CHECK_EQ(node.operand(3), operands[3]);
|
|
CHECK(!node.source_info().is_valid());
|
|
}
|
|
|
|
TEST_F(BytecodeNodeTest, Equality) {
|
|
uint32_t operands[] = {0x71, 0xa5, 0x5a, 0xfc};
|
|
BytecodeNode node(Bytecode::kForInNext, operands[0], operands[1], operands[2],
|
|
operands[3]);
|
|
CHECK_EQ(node, node);
|
|
BytecodeNode other(Bytecode::kForInNext, operands[0], operands[1],
|
|
operands[2], operands[3]);
|
|
CHECK_EQ(node, other);
|
|
}
|
|
|
|
TEST_F(BytecodeNodeTest, EqualityWithSourceInfo) {
|
|
uint32_t operands[] = {0x71, 0xa5, 0x5a, 0xfc};
|
|
BytecodeSourceInfo first_source_info(3, true);
|
|
BytecodeNode node(Bytecode::kForInNext, operands[0], operands[1], operands[2],
|
|
operands[3], first_source_info);
|
|
CHECK_EQ(node, node);
|
|
BytecodeSourceInfo second_source_info(3, true);
|
|
BytecodeNode other(Bytecode::kForInNext, operands[0], operands[1],
|
|
operands[2], operands[3], second_source_info);
|
|
CHECK_EQ(node, other);
|
|
}
|
|
|
|
TEST_F(BytecodeNodeTest, NoEqualityWithDifferentSourceInfo) {
|
|
uint32_t operands[] = {0x71, 0xa5, 0x5a, 0xfc};
|
|
BytecodeSourceInfo source_info(77, true);
|
|
BytecodeNode node(Bytecode::kForInNext, operands[0], operands[1], operands[2],
|
|
operands[3], source_info);
|
|
BytecodeNode other(Bytecode::kForInNext, operands[0], operands[1],
|
|
operands[2], operands[3]);
|
|
CHECK_NE(node, other);
|
|
}
|
|
|
|
} // namespace interpreter
|
|
} // namespace internal
|
|
} // namespace v8
|