4743426571
We used to check the size of tables at compile time, and threw a CompilationError if a given size exceeded the implementation-defined limit. However, the spec defines that an error should only be thrown when the implementation-defined limit is reached, which is either at instantiation time of during runtime at a table.grow. With this CL the V8 implementation becomes spec compliant in this regard. R=jkummerow@chromium.org Bug: v8:10556 Change-Id: I7d0e688b385a65e4060a569e5ab1dec68947ceea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2326331 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#69267}
73 lines
2.3 KiB
JavaScript
73 lines
2.3 KiB
JavaScript
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --expose-wasm
|
|
|
|
load("test/mjsunit/wasm/wasm-module-builder.js");
|
|
|
|
var kV8MaxWasmMemoryPages = 65536; // 4 GiB
|
|
var kSpecMaxWasmMemoryPages = 65536; // 4 GiB
|
|
|
|
(function testMemorySizeZero() {
|
|
print(arguments.callee.name);
|
|
var builder = new WasmModuleBuilder();
|
|
builder.addMemory(0, 0, false);
|
|
builder.addFunction("memory_size", kSig_i_v)
|
|
.addBody([kExprMemorySize, kMemoryZero])
|
|
.exportFunc();
|
|
var module = builder.instantiate();
|
|
assertEquals(0, module.exports.memory_size());
|
|
})();
|
|
|
|
(function testMemorySizeNonZero() {
|
|
print(arguments.callee.name);
|
|
var builder = new WasmModuleBuilder();
|
|
var size = 11;
|
|
builder.addMemory(size, size, false);
|
|
builder.addFunction("memory_size", kSig_i_v)
|
|
.addBody([kExprMemorySize, kMemoryZero])
|
|
.exportFunc();
|
|
var module = builder.instantiate();
|
|
assertEquals(size, module.exports.memory_size());
|
|
})();
|
|
|
|
(function testMemorySizeSpecMaxOk() {
|
|
print(arguments.callee.name);
|
|
var builder = new WasmModuleBuilder();
|
|
builder.addMemory(1, kSpecMaxWasmMemoryPages, true);
|
|
builder.addFunction("memory_size", kSig_i_v)
|
|
.addBody([kExprMemorySize, kMemoryZero])
|
|
.exportFunc();
|
|
var module = builder.instantiate();
|
|
assertEquals(1, module.exports.memory_size());
|
|
})();
|
|
|
|
(function testMemorySizeV8MaxPlus1Throws() {
|
|
print(arguments.callee.name);
|
|
var builder = new WasmModuleBuilder();
|
|
builder.addMemory(kV8MaxWasmMemoryPages + 1,
|
|
kV8MaxWasmMemoryPages + 1, false);
|
|
builder.addFunction("memory_size", kSig_i_v)
|
|
.addBody([kExprMemorySize, kMemoryZero])
|
|
.exportFunc();
|
|
assertThrows(() => builder.instantiate());
|
|
})();
|
|
|
|
(function testMemorySpecMaxOk() {
|
|
print(arguments.callee.name);
|
|
var builder = new WasmModuleBuilder();
|
|
builder.addMemory(1, kSpecMaxWasmMemoryPages, false);
|
|
builder.addFunction("memory_size", kSig_i_v)
|
|
.addBody([kExprMemorySize, kMemoryZero])
|
|
.exportFunc();
|
|
var module = builder.instantiate();
|
|
assertEquals(1, module.exports.memory_size());
|
|
})();
|
|
|
|
(function testMemoryInitialMaxPlus1Throws() {
|
|
print(arguments.callee.name);
|
|
assertThrows(() => new WebAssembly.Memory(
|
|
{initial: kV8WasmMaxMemoryPages + 1}));
|
|
})();
|