df8425622d
Add a requirement to String::GetChars that we either have a string access lock, or a string access lock is not needed. This prevents us from reading strings during internalization that may be in the middle of being made external. To avoid taking the lock too often when known to be unnecessary (e.g. for strings that were only just created), there's now a static SharedStringAccessGuardIfNeeded::NotNeeded(). This is hopefully ugly enough that it's used sparingly. One fix required for this is to enter the Isolate when tearing down IsolateData in inspector tests -- this is so that the V8Inspector instance being torn down will see the current Isolate and be able to verify its thread id against the current thread. Bug: chromium:1011762, chromium:1148680 Change-Id: Ic5d29c1b066ebae5a351c7b4bb116b9b1bf61889 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536465 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#71197}
170 lines
7.2 KiB
C++
170 lines
7.2 KiB
C++
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef V8_TEST_INSPECTOR_PROTOCOL_ISOLATE_DATA_H_
|
|
#define V8_TEST_INSPECTOR_PROTOCOL_ISOLATE_DATA_H_
|
|
|
|
#include <map>
|
|
#include <memory>
|
|
|
|
#include "include/v8-inspector.h"
|
|
#include "include/v8-platform.h"
|
|
#include "include/v8.h"
|
|
#include "src/base/macros.h"
|
|
#include "src/base/platform/platform.h"
|
|
#include "src/utils/vector.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
class TaskRunner;
|
|
|
|
enum WithInspector : bool { kWithInspector = true, kNoInspector = false };
|
|
|
|
class IsolateData : public v8_inspector::V8InspectorClient {
|
|
public:
|
|
class SetupGlobalTask {
|
|
public:
|
|
virtual ~SetupGlobalTask() = default;
|
|
virtual void Run(v8::Isolate* isolate,
|
|
v8::Local<v8::ObjectTemplate> global) = 0;
|
|
};
|
|
using SetupGlobalTasks = std::vector<std::unique_ptr<SetupGlobalTask>>;
|
|
|
|
IsolateData(const IsolateData&) = delete;
|
|
IsolateData& operator=(const IsolateData&) = delete;
|
|
IsolateData(TaskRunner* task_runner, SetupGlobalTasks setup_global_tasks,
|
|
v8::StartupData* startup_data, WithInspector with_inspector);
|
|
static IsolateData* FromContext(v8::Local<v8::Context> context);
|
|
|
|
~IsolateData() override {
|
|
// Enter the isolate before destructing this IsolateData, so that
|
|
// destructors that run before the Isolate's destructor still see it as
|
|
// entered.
|
|
isolate()->Enter();
|
|
}
|
|
|
|
v8::Isolate* isolate() const { return isolate_.get(); }
|
|
TaskRunner* task_runner() const { return task_runner_; }
|
|
|
|
// Setting things up.
|
|
int CreateContextGroup();
|
|
void CreateContext(int context_group_id, v8_inspector::StringView name);
|
|
void ResetContextGroup(int context_group_id);
|
|
v8::Local<v8::Context> GetDefaultContext(int context_group_id);
|
|
int GetContextGroupId(v8::Local<v8::Context> context);
|
|
void RegisterModule(v8::Local<v8::Context> context,
|
|
std::vector<uint16_t> name,
|
|
v8::ScriptCompiler::Source* source);
|
|
|
|
// Working with V8Inspector api.
|
|
int ConnectSession(int context_group_id,
|
|
const v8_inspector::StringView& state,
|
|
v8_inspector::V8Inspector::Channel* channel);
|
|
std::vector<uint8_t> DisconnectSession(int session_id);
|
|
void SendMessage(int session_id, const v8_inspector::StringView& message);
|
|
void BreakProgram(int context_group_id,
|
|
const v8_inspector::StringView& reason,
|
|
const v8_inspector::StringView& details);
|
|
void SchedulePauseOnNextStatement(int context_group_id,
|
|
const v8_inspector::StringView& reason,
|
|
const v8_inspector::StringView& details);
|
|
void CancelPauseOnNextStatement(int context_group_id);
|
|
void AsyncTaskScheduled(const v8_inspector::StringView& name, void* task,
|
|
bool recurring);
|
|
void AsyncTaskStarted(void* task);
|
|
void AsyncTaskFinished(void* task);
|
|
|
|
v8_inspector::V8StackTraceId StoreCurrentStackTrace(
|
|
const v8_inspector::StringView& description);
|
|
void ExternalAsyncTaskStarted(const v8_inspector::V8StackTraceId& parent);
|
|
void ExternalAsyncTaskFinished(const v8_inspector::V8StackTraceId& parent);
|
|
|
|
void AddInspectedObject(int session_id, v8::Local<v8::Value> object);
|
|
|
|
// Test utilities.
|
|
void SetCurrentTimeMS(double time);
|
|
void SetMemoryInfo(v8::Local<v8::Value> memory_info);
|
|
void SetLogConsoleApiMessageCalls(bool log);
|
|
void SetLogMaxAsyncCallStackDepthChanged(bool log);
|
|
void SetAdditionalConsoleApi(v8_inspector::StringView api_script);
|
|
void SetMaxAsyncTaskStacksForTest(int limit);
|
|
void DumpAsyncTaskStacksStateForTest();
|
|
void FireContextCreated(v8::Local<v8::Context> context, int context_group_id,
|
|
v8_inspector::StringView name);
|
|
void FireContextDestroyed(v8::Local<v8::Context> context);
|
|
void FreeContext(v8::Local<v8::Context> context);
|
|
void SetResourceNamePrefix(v8::Local<v8::String> prefix);
|
|
|
|
private:
|
|
static v8::MaybeLocal<v8::Module> ModuleResolveCallback(
|
|
v8::Local<v8::Context> context, v8::Local<v8::String> specifier,
|
|
v8::Local<v8::Module> referrer);
|
|
static void MessageHandler(v8::Local<v8::Message> message,
|
|
v8::Local<v8::Value> exception);
|
|
static void PromiseRejectHandler(v8::PromiseRejectMessage data);
|
|
static int HandleMessage(v8::Local<v8::Message> message,
|
|
v8::Local<v8::Value> exception);
|
|
std::vector<int> GetSessionIds(int context_group_id);
|
|
|
|
// V8InspectorClient implementation.
|
|
bool formatAccessorsAsProperties(v8::Local<v8::Value>) override;
|
|
v8::Local<v8::Context> ensureDefaultContextInGroup(
|
|
int context_group_id) override;
|
|
double currentTimeMS() override;
|
|
v8::MaybeLocal<v8::Value> memoryInfo(v8::Isolate* isolate,
|
|
v8::Local<v8::Context>) override;
|
|
void runMessageLoopOnPause(int context_group_id) override;
|
|
void quitMessageLoopOnPause() override;
|
|
void installAdditionalCommandLineAPI(v8::Local<v8::Context>,
|
|
v8::Local<v8::Object>) override;
|
|
void consoleAPIMessage(int contextGroupId,
|
|
v8::Isolate::MessageErrorLevel level,
|
|
const v8_inspector::StringView& message,
|
|
const v8_inspector::StringView& url,
|
|
unsigned lineNumber, unsigned columnNumber,
|
|
v8_inspector::V8StackTrace*) override;
|
|
bool isInspectableHeapObject(v8::Local<v8::Object>) override;
|
|
void maxAsyncCallStackDepthChanged(int depth) override;
|
|
std::unique_ptr<v8_inspector::StringBuffer> resourceNameToUrl(
|
|
const v8_inspector::StringView& resourceName) override;
|
|
|
|
// The isolate gets deleted by its {Dispose} method, not by the default
|
|
// deleter. Therefore we have to define a custom deleter for the unique_ptr to
|
|
// call {Dispose}. We have to use the unique_ptr so that the isolate get
|
|
// disposed in the right order, relative to other member variables.
|
|
struct IsolateDeleter {
|
|
void operator()(v8::Isolate* isolate) const {
|
|
// Exit the isolate after it was entered by ~IsolateData.
|
|
isolate->Exit();
|
|
isolate->Dispose();
|
|
}
|
|
};
|
|
|
|
TaskRunner* task_runner_;
|
|
SetupGlobalTasks setup_global_tasks_;
|
|
std::unique_ptr<v8::ArrayBuffer::Allocator> array_buffer_allocator_;
|
|
std::unique_ptr<v8::Isolate, IsolateDeleter> isolate_;
|
|
std::unique_ptr<v8_inspector::V8Inspector> inspector_;
|
|
int last_context_group_id_ = 0;
|
|
std::map<int, std::vector<v8::Global<v8::Context>>> contexts_;
|
|
std::map<std::vector<uint16_t>, v8::Global<v8::Module>> modules_;
|
|
int last_session_id_ = 0;
|
|
std::map<int, std::unique_ptr<v8_inspector::V8InspectorSession>> sessions_;
|
|
std::map<v8_inspector::V8InspectorSession*, int> context_group_by_session_;
|
|
v8::Global<v8::Value> memory_info_;
|
|
bool current_time_set_ = false;
|
|
double current_time_ = 0.0;
|
|
bool log_console_api_message_calls_ = false;
|
|
bool log_max_async_call_stack_depth_changed_ = false;
|
|
v8::Global<v8::Private> not_inspectable_private_;
|
|
v8::Global<v8::String> resource_name_prefix_;
|
|
v8::Global<v8::String> additional_console_api_;
|
|
};
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|
|
|
|
#endif // V8_TEST_INSPECTOR_PROTOCOL_ISOLATE_DATA_H_
|