d324382e1c
This is a reland of a462a7854a
Original change's description:
> [turboassembler] Introduce hard-abort mode
>
> For checks and assertions (mostly for debug code, like stack alignment
> or zero extension), we had two modes: Emit a call to the {Abort}
> runtime function (the default), and emit a debug break (used for
> testing, enabled via --trap-on-abort).
> In wasm, where we cannot just call a runtime function because code must
> be isolate independent, we always used the trap-on-abort behaviour.
> This causes problems for our fuzzers, which do not catch SIGTRAP, and
> hence do not detect debug code failures.
>
> This CL introduces a third mode ("hard abort"), which calls a C
> function via {ExternalReference}. The C function still outputs the
> abort reason, but does not print the stack trace. It then aborts via
> "OS::Abort", just like the runtime function.
> This will allow fuzzers to detect the crash and even find a nice error
> message.
>
> Even though this looks like a lot of code churn, it is actually not.
> Most added lines are new tests, and other changes are minimal.
>
> R=mstarzinger@chromium.org
>
> Bug: chromium:863799
> Change-Id: I77c58ff72db552d49014614436259ccfb49ba87b
> Reviewed-on: https://chromium-review.googlesource.com/1142163
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#54592}
Bug: chromium:863799
Change-Id: I7729a47b4823a982a8e201df36520aa2b6ef5326
Reviewed-on: https://chromium-review.googlesource.com/1146100
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54656}
41 lines
996 B
Plaintext
41 lines
996 B
Plaintext
# Copyright 2018 the V8 project authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
|
|
import("../../gni/v8.gni")
|
|
|
|
group("v8_run_gcmole") {
|
|
testonly = true
|
|
|
|
data = [
|
|
"gccause.lua",
|
|
"gcmole.lua",
|
|
"gcmole-tools/",
|
|
"parallel.py",
|
|
"run-gcmole.py",
|
|
|
|
# The following contains all relevant source and build files.
|
|
"../../BUILD.gn",
|
|
"../../base/",
|
|
"../../include/",
|
|
"../../src/",
|
|
"../../test/cctest/",
|
|
"../../test/common/",
|
|
"../../testing/gtest/include/gtest/gtest_prod.h",
|
|
"../../third_party/googletest/src/googletest/include/gtest/gtest_prod.h",
|
|
"../../third_party/icu/source/",
|
|
"$target_gen_dir/../../",
|
|
"$target_gen_dir/../../torque-generated/",
|
|
]
|
|
|
|
deps = [
|
|
"../../:run_torque",
|
|
]
|
|
|
|
if (v8_gcmole) {
|
|
# This assumes gcmole tools have been fetched by a hook
|
|
# into v8/tools/gcmole/gcmole_tools.
|
|
data += [ "gcmole-tools/" ]
|
|
}
|
|
}
|