1e4282db0d
This is a reland of f7a1932ef9
There was a wpt test in Chrome that expected the incorrect behavior.
I disable the test in https://crrev.com/c/2264418 so that we can land
the fix here.
Original change's description:
> [wasm] Re-exported globals preserve their identity
>
> V8 fails a recently added spec test that when an imported global get
> re-exported, it should preserve its identity. This CL fixes the behavior
> in V8.
>
> Drive-by change: fix the object printer of globals: a global which
> stores a reference type only has a tagged buffer, a global which stores
> a value type only has an untagged buffer.
>
> R=clemensb@chromium.org
>
> Bug: v8:10556
> Change-Id: I949d147fe4395610cfec6cf60082e1faecb23036
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235702
> Commit-Queue: Andreas Haas <ahaas@chromium.org>
> Reviewed-by: Clemens Backes <clemensb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#68513}
Bug: v8:10556
Change-Id: I8e1b08fc9f72dde166cba167e6e320e714796769
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2264097
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68552}
56 lines
2.0 KiB
Plaintext
56 lines
2.0 KiB
Plaintext
# Copyright 2018 the V8 project authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
|
|
[
|
|
|
|
[ALWAYS, {
|
|
# TODO(v8:10556): Remove sub-typing in the reference-types implementation
|
|
'constructor/instantiate': [FAIL],
|
|
'instance/constructor': [FAIL],
|
|
'proposals/js-types/constructor/instantiate': [FAIL],
|
|
'proposals/js-types/global/constructor': [FAIL],
|
|
'proposals/js-types/global/value-get-set': [FAIL],
|
|
'proposals/js-types/instance/constructor': [FAIL],
|
|
|
|
'prototypes': [FAIL],
|
|
|
|
# Outdated proposals, will work after rebasing.
|
|
'proposals/reference-types/global/value-get-set': [FAIL],
|
|
'proposals/reference-types/global/constructor': [FAIL],
|
|
'proposals/bulk-memory-operations/global/value-get-set': [FAIL],
|
|
'proposals/bulk-memory-operations/global/constructor': [FAIL],
|
|
|
|
# These are slow, and not useful to run for the proposals:
|
|
'proposals/reference-types/limits': [SKIP],
|
|
'proposals/bulk-memory-operations/limits': [SKIP],
|
|
'proposals/js-types/limits': [SKIP],
|
|
# TODO(wasm): Update memory limit.
|
|
'limits': [FAIL],
|
|
}], # ALWAYS
|
|
|
|
['arch == s390 or arch == s390x or system == aix', {
|
|
# https://bugs.chromium.org/p/v8/issues/detail?id=8402
|
|
'instance/constructor': [SKIP],
|
|
'constructor/instantiate': [SKIP],
|
|
}], # 'arch == s390 or arch == s390x or system == aix'
|
|
|
|
['mode == debug or simulator_run or variant != default or arch == arm', {
|
|
# Slow, and we always have the same limits anyway.
|
|
# ODroid bots don't have enough memory to run the test.
|
|
'limits': [SKIP],
|
|
}], # mode == debug or simulator_run or variant != default or arch == arm
|
|
|
|
##############################################################################
|
|
['lite_mode or variant == jitless', {
|
|
# TODO(v8:7777): Re-enable once wasm is supported in jitless mode.
|
|
'*': [SKIP],
|
|
}], # lite_mode or variant == jitless
|
|
|
|
################################################################################
|
|
['variant == stress_snapshot', {
|
|
'*': [SKIP], # only relevant for mjsunit tests.
|
|
}],
|
|
|
|
]
|