a7e8c320c6
With the recent switch from the tasks API to the jobs API for thread management within WebAssembly compilation we got the problem that TurboFan compilation of a previous compilation can block the Liftoff compilation of a new compilation. With synchronous compilation, this can cause significant delays for the user. With this CL we increase the priority of synchronous compilation so that at least synchronous compilation can only be blocked by other synchronous compilation. This fixes issues that we saw on autocad. Why is it okay to increase the priority of synchronous compilation? * On the main thread, synchronous compilation is only allowed for small modules which should not take long to compile. Also, the compilation blocks the main thread and should finish as fast as possible. * On worker threads, delaying other background work is not such a big issue. Downsides: * This does not only increase the priority of the initial compilation, but also for the TurboFan optimization. Similar to above, for small modules on the main thread this should not be a big deal because compilation is fast. Big modules can only be compiled on worker threads. Note that this is supposed to be a fix for the problems we see at the moment with autocad on stable and beta. Eventually compilation job management should be done by the wasm engine for all WebAssembly compilation, so that not each WebAssemly module has to do its own compilation job management. R=clemensb@chromium.org Bug: chromium:1142686, v8:11088 Change-Id: Iee4948b2fcad944f587918e9452e6888258857f9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2512911 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#70923} |
||
---|---|---|
build_overrides | ||
custom_deps | ||
docs | ||
gni | ||
include | ||
infra | ||
samples | ||
src | ||
test | ||
testing | ||
third_party | ||
tools | ||
.clang-format | ||
.clang-tidy | ||
.editorconfig | ||
.flake8 | ||
.git-blame-ignore-revs | ||
.gitattributes | ||
.gitignore | ||
.gn | ||
.vpython | ||
.ycm_extra_conf.py | ||
AUTHORS | ||
BUILD.gn | ||
CODE_OF_CONDUCT.md | ||
codereview.settings | ||
COMMON_OWNERS | ||
DEPS | ||
DIR_METADATA | ||
ENG_REVIEW_OWNERS | ||
INFRA_OWNERS | ||
INTL_OWNERS | ||
LICENSE | ||
LICENSE.fdlibm | ||
LICENSE.strongtalk | ||
LICENSE.v8 | ||
MIPS_OWNERS | ||
OWNERS | ||
PPC_OWNERS | ||
PRESUBMIT.py | ||
README.md | ||
S390_OWNERS | ||
WATCHLISTS |
V8 JavaScript Engine
V8 is Google's open source JavaScript engine.
V8 implements ECMAScript as specified in ECMA-262.
V8 is written in C++ and is used in Google Chrome, the open source browser from Google.
V8 can run standalone, or can be embedded into any C++ application.
V8 Project page: https://v8.dev/docs
Getting the Code
Checkout depot tools, and run
fetch v8
This will checkout V8 into the directory v8
and fetch all of its dependencies.
To stay up to date, run
git pull origin
gclient sync
For fetching all branches, add the following into your remote
configuration in .git/config
:
fetch = +refs/branch-heads/*:refs/remotes/branch-heads/*
fetch = +refs/tags/*:refs/tags/*
Contributing
Please follow the instructions mentioned at v8.dev/docs/contribute.