a81e8d16f4
Previously the `Debugger.CallFrame`s in `Debugger.paused` events would report locations relative to the surrounding document in case of inline scripts with `//@ sourceURL` annotations (while `Runtime.CallFrame` was already fixed previously as part of crrev.com/c/3069289). With this CL the locations in `Debugger.CallFrame` are also appropriately adjusted. Drive-by-fix: Several inspector tests were (incorrectly) relying on this wrong treatment, and were also unnecessarily using //# sourceURL annotations. So part of this CL also addresses that problem and makes the tests more robust, using addInlineScript() helper. Fixed: chromium:1283049 Bug: chromium:1183990, chromium:578269 Change-Id: I6e3b215d951c3453c0a9cfc9bccf3dc3d5e92fd6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3359619 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/main@{#78450}
71 lines
1.7 KiB
Plaintext
71 lines
1.7 KiB
Plaintext
Checks that breaks in framework code correctly processed.
|
|
|
|
Running test: testConsoleAssert
|
|
> all frames in framework:
|
|
> mixed, top frame in framework:
|
|
frameworkAssert (framework.js:10:10)
|
|
(anonymous) (user.js:0:0)
|
|
|
|
|
|
Running test: testCaughtException
|
|
> all frames in framework:
|
|
> mixed, top frame in framework:
|
|
|
|
Running test: testUncaughtException
|
|
> all frames in framework:
|
|
> mixed, top frame in framework:
|
|
throwUncaughtError (framework.js:21:2)
|
|
(anonymous) (user.js:0:0)
|
|
|
|
|
|
Running test: testUncaughtExceptionWithInlinedFrame
|
|
> mixed top frame in framework:
|
|
throwUserException (user.js:76:2)
|
|
inlinedWrapper (framework.js:56:4)
|
|
throwInlinedUncaughtError (framework.js:60:2)
|
|
(anonymous) (framework.js:0:0)
|
|
|
|
|
|
Running test: testBreakpoint
|
|
> all frames in framework:
|
|
breakpoint (framework.js:25:2)
|
|
(anonymous) (framework.js:0:0)
|
|
|
|
> mixed, top frame in framework:
|
|
breakpoint (framework.js:25:2)
|
|
(anonymous) (user.js:0:0)
|
|
|
|
|
|
Running test: testDebuggerStatement
|
|
> all frames in framework:
|
|
> mixed, top frame in framework:
|
|
|
|
Running test: testSyncDOMBreakpoint
|
|
> all frames in framework:
|
|
> mixed, top frame in framework:
|
|
syncDOMBreakpoint (framework.js:33:12)
|
|
(anonymous) (user.js:0:0)
|
|
|
|
|
|
Running test: testSyncDOMBreakpointWithInlinedUserFrame
|
|
> mixed, top frame in framework:
|
|
syncDOMBreakpoint (framework.js:33:12)
|
|
userFunction (user.js:80:2)
|
|
inlinedWrapper (framework.js:65:4)
|
|
syncDOMBreakpointWithInlinedUserFrame (framework.js:69:2)
|
|
(anonymous) (framework.js:0:0)
|
|
|
|
|
|
Running test: testAsyncDOMBreakpoint
|
|
> all frames in framework:
|
|
(anonymous) (user.js:0:0)
|
|
|
|
|
|
Running test: testCaughtSyntaxError
|
|
> all frames in framework:
|
|
> mixed, top frame in framework:
|
|
|
|
Running test: testCaughtJSONParseError
|
|
> all frames in framework:
|
|
> mixed, top frame in framework:
|