97681be4e5
This change fixes data race described in the bug by adding Acquire_Load to SamplingCircularQueue::StartDequeue and Acquire_Store to SamplingCircularQueue::Enqueue. Also the queue implementation imposed a constraint on the records it stored: the first AtomicWord in each record was a marker. For that purpose TickSampleEventRecord had filter field of type int. This approach is error prone, e.g. on x64 sizeof(AtomicWord) is 8 while sizeof(int) is 4. Moreover the queue needs such marker only at the beginning of chunk. I changed the queue so that it stores the marker explicitly as the first Cell in chunk and removed the filter field. BUG=251218 R=loislo@chromium.org, yangguo@chromium.org Review URL: https://codereview.chromium.org/19642002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15750 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
198 lines
7.1 KiB
C++
198 lines
7.1 KiB
C++
// Copyright 2010 the V8 project authors. All rights reserved.
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following
|
|
// disclaimer in the documentation and/or other materials provided
|
|
// with the distribution.
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
// contributors may be used to endorse or promote products derived
|
|
// from this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
//
|
|
// Tests of the circular queue.
|
|
|
|
#include "v8.h"
|
|
#include "circular-queue-inl.h"
|
|
#include "cctest.h"
|
|
|
|
using i::SamplingCircularQueue;
|
|
|
|
|
|
TEST(SamplingCircularQueue) {
|
|
typedef SamplingCircularQueue::Cell Record;
|
|
const int kRecordsPerChunk = 4;
|
|
SamplingCircularQueue scq(sizeof(Record),
|
|
kRecordsPerChunk * sizeof(Record),
|
|
3);
|
|
|
|
// Check that we are using non-reserved values.
|
|
// Fill up the first chunk.
|
|
CHECK_EQ(NULL, scq.StartDequeue());
|
|
for (Record i = 1; i < 1 + kRecordsPerChunk; ++i) {
|
|
Record* rec = reinterpret_cast<Record*>(scq.Enqueue());
|
|
CHECK_NE(NULL, rec);
|
|
*rec = i;
|
|
CHECK_EQ(NULL, scq.StartDequeue());
|
|
}
|
|
|
|
// Fill up the second chunk. Consumption must still be unavailable.
|
|
CHECK_EQ(NULL, scq.StartDequeue());
|
|
for (Record i = 10; i < 10 + kRecordsPerChunk; ++i) {
|
|
Record* rec = reinterpret_cast<Record*>(scq.Enqueue());
|
|
CHECK_NE(NULL, rec);
|
|
*rec = i;
|
|
CHECK_EQ(NULL, scq.StartDequeue());
|
|
}
|
|
|
|
Record* rec = reinterpret_cast<Record*>(scq.Enqueue());
|
|
CHECK_NE(NULL, rec);
|
|
*rec = 20;
|
|
// Now as we started filling up the third chunk, consumption
|
|
// must become possible.
|
|
CHECK_NE(NULL, scq.StartDequeue());
|
|
|
|
// Consume the first chunk.
|
|
for (Record i = 1; i < 1 + kRecordsPerChunk; ++i) {
|
|
Record* rec = reinterpret_cast<Record*>(scq.StartDequeue());
|
|
CHECK_NE(NULL, rec);
|
|
CHECK_EQ(static_cast<int64_t>(i), static_cast<int64_t>(*rec));
|
|
CHECK_EQ(rec, reinterpret_cast<Record*>(scq.StartDequeue()));
|
|
scq.FinishDequeue();
|
|
CHECK_NE(rec, reinterpret_cast<Record*>(scq.StartDequeue()));
|
|
}
|
|
// Now consumption must not be possible, as consumer now polls
|
|
// the first chunk for emptinness.
|
|
CHECK_EQ(NULL, scq.StartDequeue());
|
|
|
|
scq.FlushResidualRecords();
|
|
// From now, consumer no more polls ahead of the current chunk,
|
|
// so it's possible to consume the second chunk.
|
|
CHECK_NE(NULL, scq.StartDequeue());
|
|
// Consume the second chunk
|
|
for (Record i = 10; i < 10 + kRecordsPerChunk; ++i) {
|
|
Record* rec = reinterpret_cast<Record*>(scq.StartDequeue());
|
|
CHECK_NE(NULL, rec);
|
|
CHECK_EQ(static_cast<int64_t>(i), static_cast<int64_t>(*rec));
|
|
CHECK_EQ(rec, reinterpret_cast<Record*>(scq.StartDequeue()));
|
|
scq.FinishDequeue();
|
|
CHECK_NE(rec, reinterpret_cast<Record*>(scq.StartDequeue()));
|
|
}
|
|
// Consumption must still be possible as the first cell of the
|
|
// last chunk is not clean.
|
|
CHECK_NE(NULL, scq.StartDequeue());
|
|
}
|
|
|
|
|
|
namespace {
|
|
|
|
class ProducerThread: public i::Thread {
|
|
public:
|
|
typedef SamplingCircularQueue::Cell Record;
|
|
|
|
ProducerThread(SamplingCircularQueue* scq,
|
|
int records_per_chunk,
|
|
Record value,
|
|
i::Semaphore* finished)
|
|
: Thread("producer"),
|
|
scq_(scq),
|
|
records_per_chunk_(records_per_chunk),
|
|
value_(value),
|
|
finished_(finished) { }
|
|
|
|
virtual void Run() {
|
|
for (Record i = value_; i < value_ + records_per_chunk_; ++i) {
|
|
Record* rec = reinterpret_cast<Record*>(scq_->Enqueue());
|
|
CHECK_NE(NULL, rec);
|
|
*rec = i;
|
|
}
|
|
|
|
finished_->Signal();
|
|
}
|
|
|
|
private:
|
|
SamplingCircularQueue* scq_;
|
|
const int records_per_chunk_;
|
|
Record value_;
|
|
i::Semaphore* finished_;
|
|
};
|
|
|
|
} // namespace
|
|
|
|
TEST(SamplingCircularQueueMultithreading) {
|
|
// Emulate multiple VM threads working 'one thread at a time.'
|
|
// This test enqueues data from different threads. This corresponds
|
|
// to the case of profiling under Linux, where signal handler that
|
|
// does sampling is called in the context of different VM threads.
|
|
|
|
typedef ProducerThread::Record Record;
|
|
const int kRecordsPerChunk = 4;
|
|
SamplingCircularQueue scq(sizeof(Record),
|
|
kRecordsPerChunk * sizeof(Record),
|
|
3);
|
|
i::Semaphore* semaphore = i::OS::CreateSemaphore(0);
|
|
// Don't poll ahead, making possible to check data in the buffer
|
|
// immediately after enqueuing.
|
|
scq.FlushResidualRecords();
|
|
|
|
// Check that we are using non-reserved values.
|
|
ProducerThread producer1(&scq, kRecordsPerChunk, 1, semaphore);
|
|
ProducerThread producer2(&scq, kRecordsPerChunk, 10, semaphore);
|
|
ProducerThread producer3(&scq, kRecordsPerChunk, 20, semaphore);
|
|
|
|
CHECK_EQ(NULL, scq.StartDequeue());
|
|
producer1.Start();
|
|
semaphore->Wait();
|
|
for (Record i = 1; i < 1 + kRecordsPerChunk; ++i) {
|
|
Record* rec = reinterpret_cast<Record*>(scq.StartDequeue());
|
|
CHECK_NE(NULL, rec);
|
|
CHECK_EQ(static_cast<int64_t>(i), static_cast<int64_t>(*rec));
|
|
CHECK_EQ(rec, reinterpret_cast<Record*>(scq.StartDequeue()));
|
|
scq.FinishDequeue();
|
|
CHECK_NE(rec, reinterpret_cast<Record*>(scq.StartDequeue()));
|
|
}
|
|
|
|
CHECK_EQ(NULL, scq.StartDequeue());
|
|
producer2.Start();
|
|
semaphore->Wait();
|
|
for (Record i = 10; i < 10 + kRecordsPerChunk; ++i) {
|
|
Record* rec = reinterpret_cast<Record*>(scq.StartDequeue());
|
|
CHECK_NE(NULL, rec);
|
|
CHECK_EQ(static_cast<int64_t>(i), static_cast<int64_t>(*rec));
|
|
CHECK_EQ(rec, reinterpret_cast<Record*>(scq.StartDequeue()));
|
|
scq.FinishDequeue();
|
|
CHECK_NE(rec, reinterpret_cast<Record*>(scq.StartDequeue()));
|
|
}
|
|
|
|
CHECK_EQ(NULL, scq.StartDequeue());
|
|
producer3.Start();
|
|
semaphore->Wait();
|
|
for (Record i = 20; i < 20 + kRecordsPerChunk; ++i) {
|
|
Record* rec = reinterpret_cast<Record*>(scq.StartDequeue());
|
|
CHECK_NE(NULL, rec);
|
|
CHECK_EQ(static_cast<int64_t>(i), static_cast<int64_t>(*rec));
|
|
CHECK_EQ(rec, reinterpret_cast<Record*>(scq.StartDequeue()));
|
|
scq.FinishDequeue();
|
|
CHECK_NE(rec, reinterpret_cast<Record*>(scq.StartDequeue()));
|
|
}
|
|
|
|
CHECK_EQ(NULL, scq.StartDequeue());
|
|
|
|
delete semaphore;
|
|
}
|