f820041aba
This is a reland of 289b25765a
.
The fix for failures landed here:
https://chromium-review.googlesource.com/c/v8/v8/+/1599388
Original change's description:
> [Test] Update tests to work with lazy feedback allocation.
>
> This adds either %EnsureFeedbackVectorForFunction or
> %PrepareFunctionForOptimization to allocate feedback vectors when testing
> optimization, allocation sites, IC transitions etc.,
>
> Bug: v8:8394
> Change-Id: I6ad1b6d460e4abda693b326cddb87754e080a0a1
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593303
> Commit-Queue: Mythri Alle <mythria@chromium.org>
> Auto-Submit: Mythri Alle <mythria@chromium.org>
> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#61212}
Bug: v8:8394
Change-Id: Idb5bba221d138e6fd73155f959b9e16fc948c709
TBR: rmcilroy@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599607
Reviewed-by: Mythri Alle <mythria@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Auto-Submit: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61332}
162 lines
4.4 KiB
JavaScript
162 lines
4.4 KiB
JavaScript
// Copyright 2018 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax --opt --turbo-inlining
|
|
|
|
// Test that SpeculativeNumberEqual[SignedSmall] properly passes the
|
|
// kIdentifyZeros truncation.
|
|
(function() {
|
|
function foo(x, y) {
|
|
if (x * y === 0) return 0;
|
|
return 1;
|
|
}
|
|
|
|
%PrepareFunctionForOptimization(foo);
|
|
assertEquals(0, foo(0, 1));
|
|
assertEquals(1, foo(1, 1));
|
|
assertEquals(1, foo(1, 2));
|
|
%OptimizeFunctionOnNextCall(foo);
|
|
assertEquals(0, foo(0, 1));
|
|
assertEquals(1, foo(1, 1));
|
|
assertEquals(1, foo(1, 2));
|
|
assertOptimized(foo);
|
|
// Even if x*y produces -0 now, it should stay optimized.
|
|
assertEquals(0, foo(-3, 0));
|
|
assertEquals(0, foo(0, -3));
|
|
assertOptimized(foo);
|
|
})();
|
|
|
|
// Test that SpeculativeNumberEqual[Number] properly passes the
|
|
// kIdentifyZeros truncation.
|
|
(function() {
|
|
// Produce a SpeculativeNumberEqual with Number feedback.
|
|
function bar(x, y) { return x === y; }
|
|
%EnsureFeedbackVectorForFunction(bar);
|
|
bar(0.1, 0.5);
|
|
bar(-0, 100);
|
|
|
|
function foo(x, y) {
|
|
if (bar(x * y, 0)) return 0;
|
|
return 1;
|
|
}
|
|
|
|
%PrepareFunctionForOptimization(foo);
|
|
assertEquals(0, foo(0, 1));
|
|
assertEquals(1, foo(1, 1));
|
|
assertEquals(1, foo(1, 2));
|
|
%OptimizeFunctionOnNextCall(foo);
|
|
assertEquals(0, foo(0, 1));
|
|
assertEquals(1, foo(1, 1));
|
|
assertEquals(1, foo(1, 2));
|
|
assertOptimized(foo);
|
|
// Even if x*y produces -0 now, it should stay optimized.
|
|
assertEquals(0, foo(-3, 0));
|
|
assertEquals(0, foo(0, -3));
|
|
assertOptimized(foo);
|
|
})();
|
|
|
|
// Test that SpeculativeNumberLessThan[SignedSmall] properly passes the
|
|
// kIdentifyZeros truncation.
|
|
(function() {
|
|
function foo(x, y) {
|
|
if (x * y < 0) return 0;
|
|
return 1;
|
|
}
|
|
|
|
%PrepareFunctionForOptimization(foo);
|
|
assertEquals(0, foo(1, -1));
|
|
assertEquals(1, foo(1, 1));
|
|
assertEquals(1, foo(1, 2));
|
|
%OptimizeFunctionOnNextCall(foo);
|
|
assertEquals(0, foo(1, -1));
|
|
assertEquals(1, foo(1, 1));
|
|
assertEquals(1, foo(1, 2));
|
|
assertOptimized(foo);
|
|
// Even if x*y produces -0 now, it should stay optimized.
|
|
assertEquals(1, foo(-3, 0));
|
|
assertEquals(1, foo(0, -3));
|
|
assertOptimized(foo);
|
|
})();
|
|
|
|
// Test that SpeculativeNumberLessThan[Number] properly passes the
|
|
// kIdentifyZeros truncation.
|
|
(function() {
|
|
// Produce a SpeculativeNumberLessThan with Number feedback.
|
|
function bar(x, y) { return x < y; }
|
|
%EnsureFeedbackVectorForFunction(bar);
|
|
bar(0.1, 0.5);
|
|
bar(-0, 100);
|
|
|
|
function foo(x, y) {
|
|
if (bar(x * y, 0)) return 0;
|
|
return 1;
|
|
}
|
|
|
|
%PrepareFunctionForOptimization(foo);
|
|
assertEquals(0, foo(1, -1));
|
|
assertEquals(1, foo(1, 1));
|
|
assertEquals(1, foo(1, 2));
|
|
%OptimizeFunctionOnNextCall(foo);
|
|
assertEquals(0, foo(1, -1));
|
|
assertEquals(1, foo(1, 1));
|
|
assertEquals(1, foo(1, 2));
|
|
assertOptimized(foo);
|
|
// Even if x*y produces -0 now, it should stay optimized.
|
|
assertEquals(1, foo(-3, 0));
|
|
assertEquals(1, foo(0, -3));
|
|
assertOptimized(foo);
|
|
})();
|
|
|
|
// Test that SpeculativeNumberLessThanOrEqual[SignedSmall] properly passes the
|
|
// kIdentifyZeros truncation.
|
|
(function() {
|
|
function foo(x, y) {
|
|
if (x * y <= 0) return 0;
|
|
return 1;
|
|
}
|
|
|
|
%PrepareFunctionForOptimization(foo);
|
|
assertEquals(0, foo(0, 1));
|
|
assertEquals(1, foo(1, 1));
|
|
assertEquals(1, foo(1, 2));
|
|
%OptimizeFunctionOnNextCall(foo);
|
|
assertEquals(0, foo(0, 1));
|
|
assertEquals(1, foo(1, 1));
|
|
assertEquals(1, foo(1, 2));
|
|
assertOptimized(foo);
|
|
// Even if x*y produces -0 now, it should stay optimized.
|
|
assertEquals(0, foo(-3, 0));
|
|
assertEquals(0, foo(0, -3));
|
|
assertOptimized(foo);
|
|
})();
|
|
|
|
// Test that SpeculativeNumberLessThanOrEqual[Number] properly passes the
|
|
// kIdentifyZeros truncation.
|
|
(function() {
|
|
// Produce a SpeculativeNumberLessThanOrEqual with Number feedback.
|
|
function bar(x, y) { return x <= y; }
|
|
%EnsureFeedbackVectorForFunction(bar);
|
|
bar(0.1, 0.5);
|
|
bar(-0, 100);
|
|
|
|
function foo(x, y) {
|
|
if (bar(x * y, 0)) return 0;
|
|
return 1;
|
|
}
|
|
|
|
%PrepareFunctionForOptimization(foo);
|
|
assertEquals(0, foo(0, 1));
|
|
assertEquals(1, foo(1, 1));
|
|
assertEquals(1, foo(1, 2));
|
|
%OptimizeFunctionOnNextCall(foo);
|
|
assertEquals(0, foo(0, 1));
|
|
assertEquals(1, foo(1, 1));
|
|
assertEquals(1, foo(1, 2));
|
|
assertOptimized(foo);
|
|
// Even if x*y produces -0 now, it should stay optimized.
|
|
assertEquals(0, foo(-3, 0));
|
|
assertEquals(0, foo(0, -3));
|
|
assertOptimized(foo);
|
|
})();
|