AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
abf92c0614
v8/src/interpreter
History
Joyee Cheung f2fd4923f3 [class] error when accessing unused static private method at debug time 
At the moment when the static private method is unused
in source code (either explicitly or through eval) but is accessed
at runtime through the debugger, and there are no other potential
references to the class variable in the source code otherwise,
the reference to the class variable is lost here since the class
variable would not be context-allocated, then we could not rebuild
a proper brand check for it.

For now, a ReferenceError would be thrown and the method is considered
"optimized away", similar to how unused ordinary methods in closures
work. Before this patch it would DCHECK when generating bytecode
for the debugger instead of throwing errors.

Bug: v8:9839, v8:8330
Change-Id: I5d63131a7bdba141d01a3e6459bc27d0f5953c1a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2095637
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#66734}
2020-03-16 18:07:03 +00:00
..
block-coverage-builder.h
bytecode-array-accessor.cc Replace base::make_unique by std::make_unique 2019-09-10 11:21:51 +00:00
bytecode-array-accessor.h [iwyu] Add missing includes of <memory> for std::unique_ptr 2019-09-13 17:13:36 +00:00
bytecode-array-builder.cc [off-thread] Get rid of OffThreadHandle 2020-03-02 09:42:15 +00:00
bytecode-array-builder.h [off-thread] Get rid of OffThreadHandle 2020-03-02 09:42:15 +00:00
bytecode-array-iterator.cc [turbofan] Serialize bytecode array for concurrent graph building. 2019-06-27 07:08:11 +00:00
bytecode-array-iterator.h [iwyu] Add missing includes of <memory> for std::unique_ptr 2019-09-13 17:13:36 +00:00
bytecode-array-random-iterator.cc [turbofan] Serialize bytecode array for concurrent graph building. 2019-06-27 07:08:11 +00:00
bytecode-array-random-iterator.h [iwyu] Add missing includes of <memory> for std::unique_ptr 2019-09-13 17:13:36 +00:00
bytecode-array-writer.cc [off-thread] Get rid of OffThreadHandle 2020-03-02 09:42:15 +00:00
bytecode-array-writer.h [off-thread] Get rid of OffThreadHandle 2020-03-02 09:42:15 +00:00
bytecode-decoder.cc [base] Move v8memory.h to base/memory.h 2019-06-21 11:44:18 +00:00
bytecode-decoder.h Move remaining files in src/ 2019-05-24 18:24:36 +00:00
bytecode-flags.cc Move more relevant files to src/objects 2019-05-23 08:52:30 +00:00
bytecode-flags.h [cleanup] Split out bit-field.h and bounds.h from utils/utils.h 2019-11-15 13:00:08 +00:00
bytecode-generator.cc [class] error when accessing unused static private method at debug time 2020-03-16 18:07:03 +00:00
bytecode-generator.h [interpreter] Merge nested loops that share the same header offset 2020-03-09 12:41:27 +00:00
bytecode-jump-table.h Move utility code to src/utils 2019-05-23 14:13:34 +00:00
bytecode-label.cc Move more relevant files to src/objects 2019-05-23 08:52:30 +00:00
bytecode-label.h Reland "[ignition] Skip binding dead labels" 2019-02-28 14:06:15 +00:00
bytecode-node.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
bytecode-node.h Move remaining files in src/ 2019-05-24 18:24:36 +00:00
bytecode-operands.cc
bytecode-operands.h [cleanup] Split out bit-field.h and bounds.h from utils/utils.h 2019-11-15 13:00:08 +00:00
bytecode-register-allocator.h
bytecode-register-optimizer.cc [interpreter] Adapt interpreter to handle V8_REVERSE_JSARGS 2020-03-03 11:58:13 +00:00
bytecode-register-optimizer.h [interpreter] Move IterationBody StackChecks to end of loops 2020-03-11 18:12:09 +00:00
bytecode-register.cc [interpreter] Adapt interpreter to handle V8_REVERSE_JSARGS 2020-03-03 11:58:13 +00:00
bytecode-register.h Move remaining files in src/ 2019-05-24 18:24:36 +00:00
bytecode-source-info.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
bytecode-source-info.h Move remaining files in src/ 2019-05-24 18:24:36 +00:00
bytecode-traits.h [interpreter][cleanup] Using 'using' instead of 'typedef' 2019-04-03 15:30:00 +00:00
bytecodes.cc Reland "Update GetIterator bytecode to load and call object[Symbol.iterator]" 2019-09-06 13:44:12 +00:00
bytecodes.h Reland "Update GetIterator bytecode to load and call object[Symbol.iterator]" 2019-09-06 13:44:12 +00:00
constant-array-builder.cc [off-thread] Get rid of OffThreadHandle 2020-03-02 09:42:15 +00:00
constant-array-builder.h [off-thread] Get rid of OffThreadHandle 2020-03-02 09:42:15 +00:00
control-flow-builders.cc [interpreter] Move IterationBody StackChecks to end of loops 2020-03-11 18:12:09 +00:00
control-flow-builders.h [interpreter] Move IterationBody StackChecks to end of loops 2020-03-11 18:12:09 +00:00
handler-table-builder.cc [off-thread] Get rid of OffThreadHandle 2020-03-02 09:42:15 +00:00
handler-table-builder.h [off-thread] Get rid of OffThreadHandle 2020-03-02 09:42:15 +00:00
interpreter-assembler.cc [ptr-compr][csa] Use TaggedIndex nodes in IC builtins 2020-03-04 15:45:32 +00:00
interpreter-assembler.h [ptr-compr][csa] Use TaggedIndex nodes in IC builtins 2020-03-04 15:45:32 +00:00
interpreter-generator.cc [ptr-compr][csa] Use TaggedIndex nodes in IC builtins 2020-03-04 15:45:32 +00:00
interpreter-generator.h [interpreter] Use builtin names for bytecode handlers 2019-09-09 15:19:52 +00:00
interpreter-intrinsics-generator.cc Regex replaced "TNode<_> const" to "const TNode<_>" 2019-10-30 18:34:36 +00:00
interpreter-intrinsics-generator.h [csa] move TNode to separate header 2019-09-12 14:48:03 +00:00
interpreter-intrinsics.cc
interpreter-intrinsics.h [cleanup] Remove unused IsTypedArray runtime function 2019-05-21 07:25:39 +00:00
interpreter.cc [offthread] Fix double Compile compile 2020-03-12 09:31:52 +00:00
interpreter.h Set bytecode budget to interrupt_budget when allocating feedback vector 2020-02-25 13:24:06 +00:00
OWNERS Remove mstarzinger@ from OWNERS files. 2019-12-13 11:13:14 +00:00