23235b5fdb
Reason for revert: Crash fixed by https://codereview.chromium.org/1564923007 Original issue's description: > Revert of Ship ES2015 sloppy-mode function hoisting, let, class (patchset #7 id:120001 of https://codereview.chromium.org/1551443002/ ) > > Reason for revert: > Causes frequent crashes in Canary: chromium:537816 > > Original issue's description: > > Ship ES2015 sloppy-mode function hoisting, let, class > > > > This patch doesn't ship all features of ES2015 variable/scoping > > changes, notably omitting the removal of legacy const. I think > > function hoisting, let and class in sloppy mode can stand to > > themselves as a package, and the legacy const change is much > > riskier and more likely to be reverted, so my intention is to > > pursue those as a separate, follow-on patch. > > > > R=adamk@chromium.org > > BUG=v8:4285,v8:3305 > > LOG=Y > > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel > > > > Committed: https://crrev.com/fcff8588a5a01587643d6c2507c7b882c78a2957 > > Cr-Commit-Position: refs/heads/master@{#33133} > > TBR=adamk@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=v8:4285,v8:3305,chromium:537816 > LOG=Y > > Committed: https://crrev.com/adac5956c6216056a211cfaa460a00ac1500d8f8 > Cr-Commit-Position: refs/heads/master@{#33162} TBR=adamk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4285,v8:3305,chromium:537816 Review URL: https://codereview.chromium.org/1571793002 Cr-Commit-Position: refs/heads/master@{#33189}
43 lines
1.1 KiB
JavaScript
43 lines
1.1 KiB
JavaScript
// Copyright 2014 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --no-harmony-sloppy-let --no-harmony-sloppy-function
|
|
// Flags: --no-harmony-sloppy
|
|
|
|
function CheckError(source) {
|
|
var exception = null;
|
|
try {
|
|
eval(source);
|
|
} catch (e) {
|
|
exception = e;
|
|
}
|
|
assertNotNull(exception);
|
|
assertEquals(
|
|
"Block-scoped declarations (let, const, function, class) not yet supported outside strict mode",
|
|
exception.message);
|
|
}
|
|
|
|
|
|
function CheckOk(source) {
|
|
eval(source);
|
|
}
|
|
|
|
CheckError("let x = 1;");
|
|
CheckError("{ let x = 1; }");
|
|
CheckError("function f() { let x = 1; }");
|
|
CheckError("for (let x = 1; x < 1; x++) {}");
|
|
CheckError("for (let x of []) {}");
|
|
CheckError("for (let x in []) {}");
|
|
CheckError("class C {}");
|
|
CheckError("class C extends Array {}");
|
|
CheckError("(class {});");
|
|
CheckError("(class extends Array {});");
|
|
CheckError("(class C {});");
|
|
CheckError("(class C exends Array {});");
|
|
|
|
CheckOk("let = 1;");
|
|
CheckOk("{ let = 1; }");
|
|
CheckOk("function f() { let = 1; }");
|
|
CheckOk("for (let = 1; let < 1; let++) {}");
|