ec06bb6ce5
This is a reland of d1b27019d3
Fixes include:
Adding missing file to bazel build
Forward-declaring classing before friend-classing them to fix win/gcc
Add missing v8-isolate.h include for vtune builds
Original change's description:
> [include] Split out v8.h
>
> This moves every single class/function out of include/v8.h into a
> separate header in include/, which v8.h then includes so that
> externally nothing appears to have changed.
>
> Every include of v8.h from inside v8 has been changed to a more
> fine-grained include.
>
> Previously inline functions defined at the bottom of v8.h would call
> private non-inline functions in the V8 class. Since that class is now
> in v8-initialization.h and is rarely included (as that would create
> dependency cycles), this is not possible and so those methods have been
> moved out of the V8 class into the namespace v8::api_internal.
>
> None of the previous files in include/ now #include v8.h, which means
> if embedders were relying on this transitive dependency then it will
> give compile failures.
>
> v8-inspector.h does depend on v8-scripts.h for the time being to ensure
> that Chrome continue to compile but that change will be reverted once
> those transitive #includes in chrome are changed to include it directly.
>
> Full design:
> https://docs.google.com/document/d/1rTD--I8hCAr-Rho1WTumZzFKaDpEp0IJ8ejZtk4nJdA/edit?usp=sharing
>
> Bug: v8:11965
> Change-Id: I53b84b29581632710edc80eb11f819c2097a2877
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097448
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Reviewed-by: Camillo Bruni <cbruni@chromium.org>
> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Commit-Queue: Dan Elphick <delphick@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#76424}
Cq-Include-Trybots: luci.v8.try:v8_linux_vtunejit
Bug: v8:11965
Change-Id: I99f5d3a73bf8fe25b650adfaf9567dc4e44a09e6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3113629
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76460}
207 lines
6.6 KiB
C++
207 lines
6.6 KiB
C++
// Copyright 2021 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "include/v8-array-buffer.h"
|
|
#include "include/v8-initialization.h"
|
|
#include "include/v8-isolate.h"
|
|
#include "src/common/globals.h"
|
|
#include "src/handles/handles-inl.h"
|
|
#include "src/heap/heap.h"
|
|
#include "src/heap/read-only-spaces.h"
|
|
#include "src/objects/fixed-array-inl.h"
|
|
#include "src/objects/fixed-array.h"
|
|
#include "src/objects/heap-object.h"
|
|
#include "test/cctest/cctest.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
namespace {
|
|
const int kNumIterations = 2000;
|
|
|
|
template <typename Callback>
|
|
void SetupClientIsolateAndRunCallback(Isolate* shared_isolate,
|
|
Callback callback) {
|
|
std::unique_ptr<v8::ArrayBuffer::Allocator> allocator(
|
|
v8::ArrayBuffer::Allocator::NewDefaultAllocator());
|
|
|
|
v8::Isolate::CreateParams create_params;
|
|
create_params.array_buffer_allocator = allocator.get();
|
|
v8::Isolate* client_isolate = v8::Isolate::New(create_params);
|
|
Isolate* i_client_isolate = reinterpret_cast<Isolate*>(client_isolate);
|
|
i_client_isolate->AttachToSharedIsolate(shared_isolate);
|
|
|
|
callback(client_isolate, i_client_isolate);
|
|
|
|
client_isolate->Dispose();
|
|
}
|
|
|
|
class SharedOldSpaceAllocationThread final : public v8::base::Thread {
|
|
public:
|
|
explicit SharedOldSpaceAllocationThread(Isolate* shared)
|
|
: v8::base::Thread(
|
|
base::Thread::Options("SharedOldSpaceAllocationThread")),
|
|
shared_(shared) {}
|
|
|
|
void Run() override {
|
|
SetupClientIsolateAndRunCallback(shared_, [](v8::Isolate* client_isolate,
|
|
Isolate* i_client_isolate) {
|
|
HandleScope scope(i_client_isolate);
|
|
|
|
for (int i = 0; i < kNumIterations; i++) {
|
|
i_client_isolate->factory()->NewFixedArray(10,
|
|
AllocationType::kSharedOld);
|
|
}
|
|
|
|
CcTest::CollectGarbage(OLD_SPACE, i_client_isolate);
|
|
|
|
v8::platform::PumpMessageLoop(i::V8::GetCurrentPlatform(),
|
|
client_isolate);
|
|
});
|
|
}
|
|
|
|
Isolate* shared_;
|
|
};
|
|
} // namespace
|
|
|
|
UNINITIALIZED_TEST(ConcurrentAllocationInSharedOldSpace) {
|
|
if (!ReadOnlyHeap::IsReadOnlySpaceShared()) return;
|
|
std::unique_ptr<v8::ArrayBuffer::Allocator> allocator(
|
|
v8::ArrayBuffer::Allocator::NewDefaultAllocator());
|
|
|
|
v8::Isolate::CreateParams create_params;
|
|
create_params.array_buffer_allocator = allocator.get();
|
|
Isolate* shared_isolate = Isolate::NewShared(create_params);
|
|
|
|
std::vector<std::unique_ptr<SharedOldSpaceAllocationThread>> threads;
|
|
const int kThreads = 4;
|
|
|
|
for (int i = 0; i < kThreads; i++) {
|
|
auto thread =
|
|
std::make_unique<SharedOldSpaceAllocationThread>(shared_isolate);
|
|
CHECK(thread->Start());
|
|
threads.push_back(std::move(thread));
|
|
}
|
|
|
|
for (auto& thread : threads) {
|
|
thread->Join();
|
|
}
|
|
|
|
Isolate::Delete(shared_isolate);
|
|
}
|
|
|
|
namespace {
|
|
class SharedMapSpaceAllocationThread final : public v8::base::Thread {
|
|
public:
|
|
explicit SharedMapSpaceAllocationThread(Isolate* shared)
|
|
: v8::base::Thread(
|
|
base::Thread::Options("SharedMapSpaceAllocationThread")),
|
|
shared_(shared) {}
|
|
|
|
void Run() override {
|
|
SetupClientIsolateAndRunCallback(
|
|
shared_, [](v8::Isolate* client_isolate, Isolate* i_client_isolate) {
|
|
HandleScope scope(i_client_isolate);
|
|
|
|
for (int i = 0; i < kNumIterations; i++) {
|
|
i_client_isolate->factory()->NewMap(
|
|
NATIVE_CONTEXT_TYPE, kVariableSizeSentinel,
|
|
TERMINAL_FAST_ELEMENTS_KIND, 0, AllocationType::kSharedMap);
|
|
}
|
|
|
|
CcTest::CollectGarbage(OLD_SPACE, i_client_isolate);
|
|
|
|
v8::platform::PumpMessageLoop(i::V8::GetCurrentPlatform(),
|
|
client_isolate);
|
|
});
|
|
}
|
|
|
|
Isolate* shared_;
|
|
};
|
|
} // namespace
|
|
|
|
UNINITIALIZED_TEST(ConcurrentAllocationInSharedMapSpace) {
|
|
if (!ReadOnlyHeap::IsReadOnlySpaceShared()) return;
|
|
std::unique_ptr<v8::ArrayBuffer::Allocator> allocator(
|
|
v8::ArrayBuffer::Allocator::NewDefaultAllocator());
|
|
|
|
v8::Isolate::CreateParams create_params;
|
|
create_params.array_buffer_allocator = allocator.get();
|
|
Isolate* shared_isolate = Isolate::NewShared(create_params);
|
|
|
|
std::vector<std::unique_ptr<SharedMapSpaceAllocationThread>> threads;
|
|
const int kThreads = 4;
|
|
|
|
for (int i = 0; i < kThreads; i++) {
|
|
auto thread =
|
|
std::make_unique<SharedMapSpaceAllocationThread>(shared_isolate);
|
|
CHECK(thread->Start());
|
|
threads.push_back(std::move(thread));
|
|
}
|
|
|
|
for (auto& thread : threads) {
|
|
thread->Join();
|
|
}
|
|
|
|
Isolate::Delete(shared_isolate);
|
|
}
|
|
|
|
UNINITIALIZED_TEST(SharedCollectionWithoutClients) {
|
|
if (!ReadOnlyHeap::IsReadOnlySpaceShared()) return;
|
|
std::unique_ptr<v8::ArrayBuffer::Allocator> allocator(
|
|
v8::ArrayBuffer::Allocator::NewDefaultAllocator());
|
|
|
|
v8::Isolate::CreateParams create_params;
|
|
create_params.array_buffer_allocator = allocator.get();
|
|
Isolate* shared_isolate = Isolate::NewShared(create_params);
|
|
|
|
DCHECK_NULL(shared_isolate->heap()->new_space());
|
|
DCHECK_NULL(shared_isolate->heap()->new_lo_space());
|
|
|
|
CcTest::CollectGarbage(OLD_SPACE, shared_isolate);
|
|
Isolate::Delete(shared_isolate);
|
|
}
|
|
|
|
void AllocateInSharedSpace(Isolate* shared_isolate) {
|
|
SetupClientIsolateAndRunCallback(
|
|
shared_isolate,
|
|
[](v8::Isolate* client_isolate, Isolate* i_client_isolate) {
|
|
HandleScope scope(i_client_isolate);
|
|
std::vector<Handle<FixedArray>> arrays;
|
|
const int kKeptAliveArrays = 1000;
|
|
|
|
for (int i = 0; i < kNumIterations * 100; i++) {
|
|
HandleScope scope(i_client_isolate);
|
|
Handle<FixedArray> array = i_client_isolate->factory()->NewFixedArray(
|
|
100, AllocationType::kSharedOld);
|
|
if (i < kKeptAliveArrays) {
|
|
// Keep some of those arrays alive across GCs.
|
|
arrays.push_back(scope.CloseAndEscape(array));
|
|
}
|
|
}
|
|
|
|
for (Handle<FixedArray> array : arrays) {
|
|
CHECK_EQ(array->length(), 100);
|
|
}
|
|
});
|
|
}
|
|
|
|
UNINITIALIZED_TEST(SharedCollectionWithOneClient) {
|
|
FLAG_max_old_space_size = 8;
|
|
if (!ReadOnlyHeap::IsReadOnlySpaceShared()) return;
|
|
std::unique_ptr<v8::ArrayBuffer::Allocator> allocator(
|
|
v8::ArrayBuffer::Allocator::NewDefaultAllocator());
|
|
|
|
v8::Isolate::CreateParams create_params;
|
|
create_params.array_buffer_allocator = allocator.get();
|
|
Isolate* shared_isolate = Isolate::NewShared(create_params);
|
|
|
|
AllocateInSharedSpace(shared_isolate);
|
|
|
|
Isolate::Delete(shared_isolate);
|
|
}
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|