afd2f580c5
This adds and explicit check for the constructability of the new.target
value in the lowering of {JSCall} nodes known to call Reflect.construct.
The {JSConstruct} operator does not perform this check and relies on the
implicit validity of new.target in all other use cases.
R=jarin@chromium.org
TEST=mjsunit/regress/regress-crbug-768080
BUG=chromium:768080
Change-Id: I7c1921e787bae64ba83de3eb08aa00fc5523e251
Reviewed-on: https://chromium-review.googlesource.com/718100
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48543}
63 lines
1.5 KiB
JavaScript
63 lines
1.5 KiB
JavaScript
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax
|
|
|
|
(function TestReflectConstructBogusNewTarget1() {
|
|
class C {}
|
|
function g() {
|
|
Reflect.construct(C, arguments, 23);
|
|
}
|
|
function f() {
|
|
return new g();
|
|
}
|
|
assertThrows(f, TypeError);
|
|
assertThrows(f, TypeError);
|
|
%OptimizeFunctionOnNextCall(f);
|
|
assertThrows(f, TypeError);
|
|
})();
|
|
|
|
(function TestReflectConstructBogusNewTarget2() {
|
|
class C {}
|
|
// Note that {unescape} is an example of a non-constructable function. If that
|
|
// ever changes and this test needs to be adapted, make sure to choose another
|
|
// non-constructable {JSFunction} object instead.
|
|
function g() {
|
|
Reflect.construct(C, arguments, unescape);
|
|
}
|
|
function f() {
|
|
return new g();
|
|
}
|
|
assertThrows(f, TypeError);
|
|
assertThrows(f, TypeError);
|
|
%OptimizeFunctionOnNextCall(f);
|
|
assertThrows(f, TypeError);
|
|
})();
|
|
|
|
(function TestReflectConstructBogusTarget() {
|
|
function g() {
|
|
Reflect.construct(23, arguments);
|
|
}
|
|
function f() {
|
|
return new g();
|
|
}
|
|
assertThrows(f, TypeError);
|
|
assertThrows(f, TypeError);
|
|
%OptimizeFunctionOnNextCall(f);
|
|
assertThrows(f, TypeError);
|
|
})();
|
|
|
|
(function TestReflectApplyBogusTarget() {
|
|
function g() {
|
|
Reflect.apply(23, this, arguments);
|
|
}
|
|
function f() {
|
|
return g();
|
|
}
|
|
assertThrows(f, TypeError);
|
|
assertThrows(f, TypeError);
|
|
%OptimizeFunctionOnNextCall(f);
|
|
assertThrows(f, TypeError);
|
|
})();
|