b097a8e5de
String::NewFromLiteral is a templated function that takes a char[N] argument that can be used as an alternative to String::NewFromUtf8 and returns a Local<String> rather than a MaybeLocal<String> reducing the number of ToLocalChecked() or other checks. Since the string length is known at compile time, it can statically assert that the length is less than String::kMaxLength, which means that it can never fail at runtime. This also converts all found uses of NewFromUtf8 taking a string literal or a variable initialized from a string literal to use the new API. In some cases the types of stored string literals are changed from const char* to const char[] to ensure the size is retained. This API does introduce a small difference compared to NewFromUtf8. For a case like "abc\0def", NewFromUtf8 (using length -1 to infer length) would treat this as a 3 character string, whereas the new API will treat it as a 7 character string. As a drive-by fix, this also fixes all redundant uses of v8::NewStringType::kNormal when passed to any of the String::New* functions. Change-Id: Id96a44bc068d9c4eaa634aea688e024675a0e5b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2089935 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by: Mathias Bynens <mathias@chromium.org> Reviewed-by: Mythri Alle <mythria@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#66622}
120 lines
4.4 KiB
C++
120 lines
4.4 KiB
C++
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "testing/gtest/include/gtest/gtest.h"
|
|
|
|
#include "include/v8.h"
|
|
#include "src/api/api-inl.h"
|
|
#include "src/handles/handles.h"
|
|
#include "src/objects/objects-inl.h"
|
|
#include "test/unittests/test-utils.h"
|
|
|
|
namespace v8 {
|
|
namespace remote_object_unittest {
|
|
|
|
using RemoteObjectTest = TestWithIsolate;
|
|
|
|
namespace {
|
|
|
|
bool AccessCheck(Local<Context> accessing_context,
|
|
Local<Object> accessed_object, Local<Value> data) {
|
|
return false;
|
|
}
|
|
|
|
void NamedGetter(Local<Name> property,
|
|
const PropertyCallbackInfo<Value>& info) {}
|
|
|
|
void Constructor(const FunctionCallbackInfo<Value>& info) {
|
|
ASSERT_TRUE(info.IsConstructCall());
|
|
}
|
|
|
|
} // namespace
|
|
|
|
TEST_F(RemoteObjectTest, CreationContextOfRemoteContext) {
|
|
Local<ObjectTemplate> global_template = ObjectTemplate::New(isolate());
|
|
global_template->SetAccessCheckCallbackAndHandler(
|
|
AccessCheck, NamedPropertyHandlerConfiguration(NamedGetter),
|
|
IndexedPropertyHandlerConfiguration());
|
|
|
|
Local<Object> remote_context =
|
|
Context::NewRemoteContext(isolate(), global_template).ToLocalChecked();
|
|
EXPECT_TRUE(remote_context->CreationContext().IsEmpty());
|
|
}
|
|
|
|
TEST_F(RemoteObjectTest, CreationContextOfRemoteObject) {
|
|
Local<FunctionTemplate> constructor_template =
|
|
FunctionTemplate::New(isolate(), Constructor);
|
|
constructor_template->InstanceTemplate()->SetAccessCheckCallbackAndHandler(
|
|
AccessCheck, NamedPropertyHandlerConfiguration(NamedGetter),
|
|
IndexedPropertyHandlerConfiguration());
|
|
|
|
Local<Object> remote_object =
|
|
constructor_template->NewRemoteInstance().ToLocalChecked();
|
|
EXPECT_TRUE(remote_object->CreationContext().IsEmpty());
|
|
}
|
|
|
|
TEST_F(RemoteObjectTest, RemoteContextInstanceChecks) {
|
|
Local<FunctionTemplate> parent_template =
|
|
FunctionTemplate::New(isolate(), Constructor);
|
|
|
|
Local<FunctionTemplate> constructor_template =
|
|
FunctionTemplate::New(isolate(), Constructor);
|
|
constructor_template->InstanceTemplate()->SetAccessCheckCallbackAndHandler(
|
|
AccessCheck, NamedPropertyHandlerConfiguration(NamedGetter),
|
|
IndexedPropertyHandlerConfiguration());
|
|
constructor_template->Inherit(parent_template);
|
|
|
|
Local<Object> remote_context =
|
|
Context::NewRemoteContext(isolate(),
|
|
constructor_template->InstanceTemplate())
|
|
.ToLocalChecked();
|
|
EXPECT_TRUE(parent_template->HasInstance(remote_context));
|
|
EXPECT_TRUE(constructor_template->HasInstance(remote_context));
|
|
}
|
|
|
|
TEST_F(RemoteObjectTest, TypeOfRemoteContext) {
|
|
Local<ObjectTemplate> global_template = ObjectTemplate::New(isolate());
|
|
global_template->SetAccessCheckCallbackAndHandler(
|
|
AccessCheck, NamedPropertyHandlerConfiguration(NamedGetter),
|
|
IndexedPropertyHandlerConfiguration());
|
|
|
|
Local<Object> remote_context =
|
|
Context::NewRemoteContext(isolate(), global_template).ToLocalChecked();
|
|
String::Utf8Value result(isolate(), remote_context->TypeOf(isolate()));
|
|
EXPECT_STREQ("object", *result);
|
|
}
|
|
|
|
TEST_F(RemoteObjectTest, TypeOfRemoteObject) {
|
|
Local<FunctionTemplate> constructor_template =
|
|
FunctionTemplate::New(isolate(), Constructor);
|
|
constructor_template->InstanceTemplate()->SetAccessCheckCallbackAndHandler(
|
|
AccessCheck, NamedPropertyHandlerConfiguration(NamedGetter),
|
|
IndexedPropertyHandlerConfiguration());
|
|
|
|
Local<Object> remote_object =
|
|
constructor_template->NewRemoteInstance().ToLocalChecked();
|
|
String::Utf8Value result(isolate(), remote_object->TypeOf(isolate()));
|
|
EXPECT_STREQ("object", *result);
|
|
}
|
|
|
|
TEST_F(RemoteObjectTest, ClassOf) {
|
|
Local<FunctionTemplate> constructor_template =
|
|
FunctionTemplate::New(isolate(), Constructor);
|
|
constructor_template->InstanceTemplate()->SetAccessCheckCallbackAndHandler(
|
|
AccessCheck, NamedPropertyHandlerConfiguration(NamedGetter),
|
|
IndexedPropertyHandlerConfiguration());
|
|
constructor_template->SetClassName(
|
|
String::NewFromUtf8Literal(isolate(), "test_class"));
|
|
|
|
Local<Object> remote_object =
|
|
constructor_template->NewRemoteInstance().ToLocalChecked();
|
|
Local<String> class_name = Utils::ToLocal(
|
|
i::handle(Utils::OpenHandle(*remote_object)->class_name(), i_isolate()));
|
|
String::Utf8Value result(isolate(), class_name);
|
|
EXPECT_STREQ("test_class", *result);
|
|
}
|
|
|
|
} // namespace remote_object_unittest
|
|
} // namespace v8
|