eb89d2c92f
This is a reland of commit 60e9b50374
Original change's description:
> cppgc: Consistently treat sentinel pointer as live
>
> Sentinel pointers would be treated as live by the GC (through
> `HandleWeak()` but would be treated as dead when checked explicitly
> through the `LivenessBroker` in e.g. custom callbacks.
>
> Treat sentinel pointers as live consistently across all callsites
> and weak types.
>
> Change-Id: I9a4c096ddac1a111df808f3683325b55e7597eea
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3782800
> Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
> Reviewed-by: Omer Katz <omerkatz@chromium.org>
> Reviewed-by: Anton Bikineev <bikineev@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#81916}
Change-Id: Ie2476345b9ea8406015a3b07bd6880c1159ede08
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779913
Reviewed-by: Anton Bikineev <bikineev@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81975}
79 lines
2.3 KiB
C++
79 lines
2.3 KiB
C++
// Copyright 2020 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef INCLUDE_CPPGC_LIVENESS_BROKER_H_
|
|
#define INCLUDE_CPPGC_LIVENESS_BROKER_H_
|
|
|
|
#include "cppgc/heap.h"
|
|
#include "cppgc/member.h"
|
|
#include "cppgc/sentinel-pointer.h"
|
|
#include "cppgc/trace-trait.h"
|
|
#include "v8config.h" // NOLINT(build/include_directory)
|
|
|
|
namespace cppgc {
|
|
|
|
namespace internal {
|
|
class LivenessBrokerFactory;
|
|
} // namespace internal
|
|
|
|
/**
|
|
* The broker is passed to weak callbacks to allow (temporarily) querying
|
|
* the liveness state of an object. References to non-live objects must be
|
|
* cleared when `IsHeapObjectAlive()` returns false.
|
|
*
|
|
* \code
|
|
* class GCedWithCustomWeakCallback final
|
|
* : public GarbageCollected<GCedWithCustomWeakCallback> {
|
|
* public:
|
|
* UntracedMember<Bar> bar;
|
|
*
|
|
* void CustomWeakCallbackMethod(const LivenessBroker& broker) {
|
|
* if (!broker.IsHeapObjectAlive(bar))
|
|
* bar = nullptr;
|
|
* }
|
|
*
|
|
* void Trace(cppgc::Visitor* visitor) const {
|
|
* visitor->RegisterWeakCallbackMethod<
|
|
* GCedWithCustomWeakCallback,
|
|
* &GCedWithCustomWeakCallback::CustomWeakCallbackMethod>(this);
|
|
* }
|
|
* };
|
|
* \endcode
|
|
*/
|
|
class V8_EXPORT LivenessBroker final {
|
|
public:
|
|
template <typename T>
|
|
bool IsHeapObjectAlive(const T* object) const {
|
|
// - nullptr objects are considered alive to allow weakness to be used from
|
|
// stack while running into a conservative GC. Treating nullptr as dead
|
|
// would mean that e.g. custom collections could not be strongified on
|
|
// stack.
|
|
// - Sentinel pointers are also preserved in weakness and not cleared.
|
|
return !object || object == kSentinelPointer ||
|
|
IsHeapObjectAliveImpl(
|
|
TraceTrait<T>::GetTraceDescriptor(object).base_object_payload);
|
|
}
|
|
|
|
template <typename T>
|
|
bool IsHeapObjectAlive(const WeakMember<T>& weak_member) const {
|
|
return IsHeapObjectAlive<T>(weak_member.Get());
|
|
}
|
|
|
|
template <typename T>
|
|
bool IsHeapObjectAlive(const UntracedMember<T>& untraced_member) const {
|
|
return IsHeapObjectAlive<T>(untraced_member.Get());
|
|
}
|
|
|
|
private:
|
|
LivenessBroker() = default;
|
|
|
|
bool IsHeapObjectAliveImpl(const void*) const;
|
|
|
|
friend class internal::LivenessBrokerFactory;
|
|
};
|
|
|
|
} // namespace cppgc
|
|
|
|
#endif // INCLUDE_CPPGC_LIVENESS_BROKER_H_
|