b1f5eeabe5
This is a reland of 2b94e5677f
Original change's description:
> [inspector] Report [[Prototype]] as internal property.
>
> Previously the inspector was trying to add a special `__proto__`
> property to every JSObject, which looked and behaved like a real
> data property on the object. But this is confusing to developers
> since `__proto__` is not a real data property, but usually an
> accessor property on the `Object.prototype`.
>
> Additionally all other internal properties are reported using the
> [[Name]] notation, with the [[Prototype]] having been the strange
> outlier.
>
> Drive-by-cleanup: Use an ArrayList to collect the name/value pairs
> inside Runtime::GetInternalProperties(), which makes this function
> more readable and easier to add things.
>
> Bug: chromuium:1162229
> Fixed: chromium:1197019
> Screenshot: https://imgur.com/a/b7TZ32s.png
> Change-Id: Ic4c1e35e2e65f90619fcc12bf3a72806cadb0794
> Doc: http://doc/1Xetnc9s6r0yy4LnPbqeCwsnsOtBlvJsV4OCdXMZ1wCM
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2814565
> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#73881}
Bug: chromuium:1162229, chromium:1197019
Screenshot: https://imgur.com/a/b7TZ32s.png
Doc: http://doc/1Xetnc9s6r0yy4LnPbqeCwsnsOtBlvJsV4OCdXMZ1wCM
Change-Id: Ie1e2276b385b18a5f865fdae583d1ce0101157c0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2820970
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73899}
68 lines
1.9 KiB
Plaintext
68 lines
1.9 KiB
Plaintext
Checks Runtime.getProperties method while debugger is paused.
|
|
|
|
Running test: testObject5
|
|
foo own string cat
|
|
Internal properties
|
|
[[PrimitiveValue]] number 5
|
|
[[Prototype]] object undefined
|
|
|
|
Running test: testNotOwn
|
|
__defineGetter__ inherited function undefined
|
|
__defineSetter__ inherited function undefined
|
|
__lookupGetter__ inherited function undefined
|
|
__lookupSetter__ inherited function undefined
|
|
__proto__ inherited no value, getter, setter
|
|
a own number 2
|
|
b own no value, getter, setter
|
|
c inherited number 4
|
|
constructor inherited function undefined
|
|
d inherited no value, getter
|
|
hasOwnProperty inherited function undefined
|
|
isPrototypeOf inherited function undefined
|
|
propertyIsEnumerable inherited function undefined
|
|
toLocaleString inherited function undefined
|
|
toString inherited function undefined
|
|
valueOf inherited function undefined
|
|
Internal properties
|
|
[[Prototype]] object undefined
|
|
|
|
Running test: testAccessorsOnly
|
|
b own no value, getter, setter
|
|
d own no value, setter
|
|
|
|
Running test: testArray
|
|
0 own string red
|
|
1 own string green
|
|
2 own string blue
|
|
length own number 3
|
|
Internal properties
|
|
[[Prototype]] object undefined
|
|
|
|
Running test: testBound
|
|
length own number 0
|
|
name own string bound Number
|
|
Internal properties
|
|
[[BoundArgs]] object undefined
|
|
[[BoundThis]] object undefined
|
|
[[Prototype]] function undefined
|
|
[[TargetFunction]] function undefined
|
|
|
|
Running test: testObjectThrowsLength
|
|
length own no value, getter
|
|
Internal properties
|
|
[[Prototype]] object undefined
|
|
|
|
Running test: testTypedArrayWithoutLength
|
|
Internal properties
|
|
[[Prototype]] object undefined
|
|
|
|
Running test: testArrayBuffer
|
|
|
|
Running test: testArrayBufferWithBrokenUintCtor
|
|
Internal properties
|
|
[[ArrayBufferByteLength]] number 7
|
|
[[ArrayBufferData]] string 0x...
|
|
[[Int8Array]] object undefined
|
|
[[Prototype]] object undefined
|
|
[[Uint8Array]] object undefined
|